From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E0614317E for ; Mon, 16 Oct 2023 15:25:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 165554069F; Mon, 16 Oct 2023 15:25:44 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id 976134021D; Mon, 16 Oct 2023 15:25:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uxu5GmsMDzF2ga0vIPTiXrgULWyktH7N8tlgjbms7O7JNZYuqba92wTCj0P3s4AdmfgNomA2JMFXNMfpROsRnw/RHleq8VBkhPHha1SfL4dPwwGKNXzLVMyFajjpLgTJlvvTI/yw48/HomS0UHjDl1BDvLfy+lNihCYur7ATOidN46gSXOZ2m/xgVr77Hgu19sk8EmNxNFvlEmlidaX29GPnJx37wdAjYbg05/stviqLKwlq1bZE648pefFfxJISz+ZWxE6OXIzr0WPVC0zxSDQ9lOjRmoa43typW2FQ7eRjCkiZjILnvMaNYQo8tCL9H+2LQi+CC5tt6B6Ojl3xvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1e2+y3QAwLOhG2tErcArnN5OecPWM4nEQ52frplbGo=; b=Q5coINY3QTC/CZPeSyEoPsd3mJB3R28zvwY9X0VVZP1Vv/13HgPrDVXXPeZ2RbZFX1prPXgatzg9FVMTGV7qiIOba3xx6YXcbtoI6X/jKdWqPRvBXhCoSfg2datsQZ63T5srfbqlmdBsv+JwPFVmO1yoOP1o1V9f0vBMziMclzl7kbZoyg9PYLETqDgHLuKOAvLmq8lxVppa8IjzpO76WwKKHl9x+y46TAd/9O8AeFsr56t3+xzTG3pcde5UW/7CGanzHBe+QVLv/7CiLrB1dz+DxJkRd+LX6efHntNN7iDDb1XcvCqqakDWATfpTVg6ErtYwTG3xSnfC2/np0n+kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1e2+y3QAwLOhG2tErcArnN5OecPWM4nEQ52frplbGo=; b=eNnhjabJq92iJ8uHrg86EQhwVQArtgT5EZxIAaFs516TMwu0bCW9yVw4FgP4UdCka9FTz72EW2t+SFh+H617VWcFYYCF4jCYmFTa48lqTghSW2hs/eGLYq4P1gX0FJ7f1jxCo1j1hV485Q10sKl3bOGtqDeHMnl6TW4fSdrO3OY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4497.namprd12.prod.outlook.com (2603:10b6:5:2a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 13:25:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Mon, 16 Oct 2023 13:25:39 +0000 Message-ID: <4ee30fba-8b26-4dbe-80dc-71304c0861b3@amd.com> Date: Mon, 16 Oct 2023 14:25:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: fix jumbo packet descriptors for NFDk Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , stable@dpdk.org References: <20231010060652.205791-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231010060652.205791-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0139.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4497:EE_ X-MS-Office365-Filtering-Correlation-Id: c7142bc5-113a-41f3-8f78-08dbce4b6371 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I7Yne4SeFw2ZFCTQpeGR+pJV+UQEVl/JXLcrSAy+FNwdovMhpe4O3E8EMsUUT0Pq261nZ+VRF4s+0NY3Ock8Zp6RwMzzXZIEcBlv5hL1cKcPOe+ahWxoss+fBy9KaYmtHOQQNb0WXT+tq3kvANwKkLki1KaE9s0skbRg0cdSKNMJYVJhZao2hIMWBdAXoUOIUoy6nGmBaqQSNeln5WG24+rQLVrfJx0fwS1ucPpXyq6jmeioDQsrfXSrrpeo7xw9y7rAtKLWrxaVfeMv0YxH1/AN4vbAsWuoH28yV8VoCydD+Rr0Pey7Kd57sJhduTc8XCv9rSDuEt57H63w5Uu1DPRjyeIGIc/jGot3u3J+3eu75d05Q+x9ya2AbXvYjyrxqgRk886WWwTP79TefL+E5Pxt0UOR0rDSK76JTK8saCcAn9Fs7UOvRCeTMgx8R3IoDaiNOD+dnooCtSYdXhCNlLIehi5OGK31HDzlVAb3W4ZEtYT9AnMJ7QoMH93m6Ek/SzyV5tMkEcKQT64y2rD6s5Blgv1Zdi0n3+U+GttiS5CBdXF15thZAf5tfYFQoQQBh3050wNoFpUy7+ycUufuE7mweswj6JEtYH8DRSRkJiCX6Bcw/2//M7rBKHleiPukQ9JNQeNowZ8obZxdcSikvg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(346002)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(31686004)(478600001)(6486002)(66476007)(66556008)(66946007)(316002)(83380400001)(86362001)(38100700002)(6512007)(26005)(2616005)(53546011)(6506007)(36756003)(44832011)(41300700001)(31696002)(5660300002)(8936002)(8676002)(4326008)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUg3QmxYbnRsdG9JS2hVYkhZMkZ1V0IwaFB6Vm4xQTY1ajZjS3hLbzdSR2Vq?= =?utf-8?B?b2JVMk50T1M4SUJPRjRFaFkzVS9ER3lDYkcxWkY1cXBIMVBpYTNXamw2Rys4?= =?utf-8?B?T1RJM3hCNVdsS1ovQzBaM3p1UkZpTzNLT0RsUFdjMytPV1ZtR3NFY0FKaEJu?= =?utf-8?B?ZDIxeUY3YTZ4cVNudmJRWTFVQ0NuZmgvSFpocnk4aXREODV3dW16WG83VUxm?= =?utf-8?B?bGlTWmU0SzdiOEtpdU1CajNyR3g5eS8xRTB6KzYzRFNSMFJyWTlWYVZKeVAz?= =?utf-8?B?cGJQdmVZc3BTSmNHUkZjbGgrb3Z2VGZBM0xsV1dBQm9qWnJ2Y01IME91Uk1H?= =?utf-8?B?MW1uV3VhYkhReHB6N0VvdkNFVHlmYkVZbGpZbGRsRTFET2IvTERTTFBRNkQ2?= =?utf-8?B?VVNZN2tuRVF5WFRQQjN6UWY4YXQrcm5WaFFjVTV6U0l1MkoxOUpocmR6blF5?= =?utf-8?B?dmVtSVlUcE11RkVZRHUzcU1RMlNTbFRzc001SkUrZlhtaGtYa2tVSEVqa1Nn?= =?utf-8?B?d1MvOStmSk9pU2cyMEZvWURuR3FXbGxsSzM0RlFLMW9XOWhGOXBaNGNKU1FI?= =?utf-8?B?TVMwM0VCalpsSGwzajJQaitXSXhtaG92M3hrQWlCT0VsUWoxQkl2akZiaDdh?= =?utf-8?B?WHkwMExCczlxVkdXZSswZm9SK0Fab3BPa3ZuaCtTcVRIeVRSSmM2eTAxYzNN?= =?utf-8?B?K1Z2U0NRazFKdTJYYUhSYkd1L05vNGcrMlZ3VUhXY3EvYklPZ2JIOVlKaVJ5?= =?utf-8?B?WXFISHFDd21IOW4xSmgyZEgxUXdJYmNRMnRqYjZNZFE1UmdLdmNVNnY3TzVl?= =?utf-8?B?aGpLSzVGamZuRGptMUlFWmpJNzBxTnUzSWZ0Q3orUHQwTGx6SndhS2YyNndj?= =?utf-8?B?VkN2TDErTzJ6UG1SS1htbHB1c3Rsb1Fjb3lhU2p6eXdpOFlaWnhtdFlPcmx3?= =?utf-8?B?WDFOaWVsaEF4UFVMaDluQllrR3ZUZEh1UXhDT1k2UDJEU0pyRzI2d2NrSzRn?= =?utf-8?B?WnVVWStEditsWFZKNzQxa05oejg4NUZsQW5oUGdod3M1S0tJTXZTeVF0Z3Y3?= =?utf-8?B?aE5PQXFyb2tzMXpzV2tQd09HaDNrdG9PVEh2VlBwODRRQS9MSnROWjl4R2p5?= =?utf-8?B?d3A2NTFzWkE4SzV6SnI2aEFGbzFxeHJTRlBRQzNmUm9JUlpHZVdTS1hHN1Qv?= =?utf-8?B?dHdadHVCK2E0ek9pTlZaMFVIQVl2NU1jaWt6YTJSem9wSkh2SkROL2xySWgx?= =?utf-8?B?RzA2V2lZTkhxQ2FVU2lDSC9kcS9aT0p5V1FVYlFCclBrM2JRdTJLa3dEcG82?= =?utf-8?B?US9yM2JvazBtaE9jVkZ6eVVDcHkyR3hWU2txUlVwK1kwVm5kTkFyYndla1dl?= =?utf-8?B?MUxEQ2pVUGZYSFdyMjVYT2lWd3JQY2ZXM2FvN1djamJoUHM4KzFlSzF6NEI4?= =?utf-8?B?dy9qSmZuUHcyQ2JYcDJxSVBmeGpwNEl0V211TTU2bjhpMENubU82Ukd5K1hE?= =?utf-8?B?NGhDTkxqK2lrNStvQ2VPOW5COHN6ZXlnRklWeVBFVjlwM2ZRT3dhS3pzcVMw?= =?utf-8?B?dCs1anNmRFZTNVluL3doNHBSU1Y5bVkvOHR4NkhHb0JoT0kvbERVOXUvZktR?= =?utf-8?B?bjY5a29adG56Qi9CQ1FRREM2NEhMZkJNMjBZK25iZGlkSEtaYXVENkVhc0VG?= =?utf-8?B?cDRlTjl5TytianliT3I1dnVtSVhPUXAyL0I0OU9seXExUzBnK0hhcXBzclRS?= =?utf-8?B?QkRCaXZ6eHMrRjlFZEtMT3JmejdwOTdLQmZMRTV0N1d1aDFyZHNtK1l3bFAv?= =?utf-8?B?L1JaKy80ZGNzQ3JzU1R4S0NoRzlzemdYM1EzTGc0TnI0dElFUmtNWWUyZTVw?= =?utf-8?B?akxGL3lxMktHMk42OHVWRWhiNyt6RzM0WW92MDhRZFBhWE1sZlVtSEs5MnRQ?= =?utf-8?B?VC95RDR4V0czelNDOFpQaDZ2LzJkd1U4ZW02UjNxMXVWY002enh2NjZvWHlN?= =?utf-8?B?bVRBWlRnNVlScEhsNk5ROW5VZU1QZmlLTHMrR2dTZk9SQy8wTmdMKy8rQ0dm?= =?utf-8?B?UC9hQjB6MUlMcExweVdBL0RoTmJZYzJZR2NINmVXZnJZVzUvT2o2SWdVRmFD?= =?utf-8?Q?gVgPk46rZ0D1+j3aOLCthGPW+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7142bc5-113a-41f3-8f78-08dbce4b6371 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 13:25:39.0454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I1wl50vIfDv/s8cbXWY2sPPdNxqXjnaLJwxH0hVg7BS9Gau7xK/jKg89eRjs5Eap X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4497 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/10/2023 7:06 AM, Chaoyong He wrote: > From: Long Wu > > When sending a jumbo packet on NFDk the packet must be split between > multiple descriptors. The first descriptor contains the packet header > and is limited to NFDK_DESC_TX_DMA_LEN_HEAD bytes. If the packet is > large, one or more payload descriptors, without a packet header, and > a size limit of NFDK_DESC_TX_DMA_LEN bytes are appended. > > When adjusting the coding style for the for NFDk datapath an error was > made and the total packet size was modified when creating the first > descriptor. This resulted in no payload descriptors being created and > the jumbo packets where truncated. > > Fix this by not modifying the total packet length when constructing the > first descriptor, allowing one or more payload descriptors to be > created. > > Fixes: d7f6d9b21ffa ("net/nfp: adjust coding style for NFDk") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Applied to dpdk-next-net/main, thanks.