patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dapengx.yu@intel.com, xiaoyun.li@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd
Date: Thu, 8 Apr 2021 16:41:31 +0100	[thread overview]
Message-ID: <500b55c4-6ec5-1466-8ddf-60728e9cefcb@intel.com> (raw)
In-Reply-To: <20210401082844.401918-1-dapengx.yu@intel.com>

On 4/1/2021 9:28 AM, dapengx.yu@intel.com wrote:
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> Configure per queue rx offloading and per queue tx offloading command
> shouldn't trigger the rte_eth_dev_configure() to reconfigure device.
> 
> The patch sets the queue reconfiguration flag only, and does not set the
> device reconfiguration flag. Therefore after port is restarted,
> rte_eth_dev_configure() will not be called again.
> 

Just to clarify the impact, was calling 'rte_eth_dev_configure()' causing any 
problem, is this fixing any issue?
Or is this patch an optimization to eliminate an unnecessary call?

> Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>   app/test-pmd/cmdline.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 14110eb2e..b49e9f52b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void *parsed_result,
>   	else
>   		port->rx_conf[queue_id].offloads &= ~single_offload;
>   
> -	cmd_reconfig_device_queue(port_id, 1, 1);
> +	cmd_reconfig_device_queue(port_id, 0, 1);
>   }
>   
>   cmdline_parse_inst_t cmd_config_per_queue_rx_offload = {
> @@ -16044,7 +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result,
>   	else
>   		port->tx_conf[queue_id].offloads &= ~single_offload;
>   
> -	cmd_reconfig_device_queue(port_id, 1, 1);
> +	cmd_reconfig_device_queue(port_id, 0, 1);
>   }
>   
>   cmdline_parse_inst_t cmd_config_per_queue_tx_offload = {
> 


  parent reply	other threads:[~2021-04-08 15:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  8:28 dapengx.yu
2021-04-07  2:30 ` Li, Xiaoyun
2021-04-08 15:41 ` Ferruh Yigit [this message]
2021-04-09  5:25   ` Yu, DapengX
2021-04-09  7:50     ` Li, Xiaoyun
2021-04-09 10:29       ` Yu, DapengX
2021-04-12  2:21         ` Li, Xiaoyun
2021-04-12 12:46           ` Ferruh Yigit
2021-04-15  6:04             ` Yu, DapengX
2021-04-19 15:46               ` Ferruh Yigit
2021-04-20  8:12                 ` Yu, DapengX
2021-04-20  8:22                   ` Ferruh Yigit
2021-04-20  8:40                     ` Yu, DapengX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500b55c4-6ec5-1466-8ddf-60728e9cefcb@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).