From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3185DA05D3 for ; Thu, 23 May 2019 14:48:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D35404F91; Thu, 23 May 2019 14:48:57 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 301174F91; Thu, 23 May 2019 14:48:56 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57A6C307D986; Thu, 23 May 2019 12:48:30 +0000 (UTC) Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDB822E030; Thu, 23 May 2019 12:48:18 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, stephen@networkplumber.org, Dharmik.Thakkar@arm.com, stable@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara References: <1557907020-1548-1-git-send-email-david.marchand@redhat.com> <1558537617-27813-1-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: <500d2162-c835-dbf6-0db0-347b90090392@redhat.com> Date: Thu, 23 May 2019 14:48:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1558537617-27813-1-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 23 May 2019 12:48:55 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH v2 1/2] test/hash: use existing lcore API X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 5/22/19 5:06 PM, David Marchand wrote: > Prefer the existing apis rather than direct access the configuration > structure. > > test_hash_multi_add_lookup() currently starts n readers and N writers > using rte_eal_remote_launch(). > It then waits for the N writers to complete with a custom > multi_writer_done[] array to synchronise over. > Jump on the occasion to use rte_eal_wait_lcore() so that the code is > more straightforward: > - we start n readers with rte_eal_remote_launch(), > - we start N writers with rte_eal_remote_launch(), > - we wait for N writers to join with rte_eal_wait_lcore(), > - we wait for n readers to join with rte_eal_wait_lcore(), > > Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") > Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > app/test/test_hash_readwrite_lf.c | 41 ++++++++++++++++++--------------------- > 1 file changed, 19 insertions(+), 22 deletions(-) > Reviewed-by: Maxime Coquelin