From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76408A00C2 for ; Thu, 8 Dec 2022 17:55:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 703C3410D2; Thu, 8 Dec 2022 17:55:14 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id 91E6940E28 for ; Thu, 8 Dec 2022 17:55:12 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id bg10so1560876wmb.1 for ; Thu, 08 Dec 2022 08:55:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0/ykbP3xBVYJYXN23486Q2ZsaC5kliljn/ZTa6imxK0=; b=UWWhn1lK7VLXuVvbsHAYH712+72p+TZ2mIWLe9xULhJW2zOmdOSnnPwcFUjTfQv8qk I8IvPrLoy2C0EjMwhKdWGD2tYI4QhKUr+aAlJa/Hmi3MqtV0KnZL8U98T6M3HwFKlk1n I9PwNoI3pf8VVLa8dK8KoSQrunDjyKFy/aEJ8qJYure+L+M84B8xTIYljBegqrqjRsRQ KCWwJd10Of000VQO0CH1YmWxzv/qXFHgot2I8Fvjh0PuZg/ChE2Wok23SZD2JbdISY1b ZsdCGRMjiS/Xk9jFwSqhSlSrEvbiGiw1wezE6BVkwSj6wWa3uxeerj7+JgMw62Xf+Wte Q4lQ== X-Gm-Message-State: ANoB5pmkrAXWjjObSdUres81kI9uobi6mO8yAAOmJERegaHQ49Yi9GoD FWYDFRK8HdyrAUEE8RoQLHV79O9zEAU= X-Google-Smtp-Source: AA0mqf5oqjgytoN3g/GabAumq8BLcdjISHp+gzVAU01F/62TC/4USwwKUNzpLcw7dNCvZ0V2moJ3OA== X-Received: by 2002:a05:600c:6888:b0:3d1:d746:7bca with SMTP id fn8-20020a05600c688800b003d1d7467bcamr2394946wmb.4.1670518512204; Thu, 08 Dec 2022 08:55:12 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c430600b003cf5ec79bf9sm5158504wme.40.2022.12.08.08.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:55:11 -0800 (PST) Message-ID: <50950a6080f06c1a6535a71f80d5554b95429a0f.camel@debian.org> Subject: Re: [PATCH 20.11 1/4] net/ena: remove useless address check From: Luca Boccassi To: David Marchand , stable@dpdk.org Cc: Ferruh Yigit , Michal Krawczyk Date: Thu, 08 Dec 2022 16:55:10 +0000 In-Reply-To: <20221208144910.360883-1-david.marchand@redhat.com> References: <20221208144910.360883-1-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 2022-12-08 at 15:49 +0100, David Marchand wrote: > From: Ferruh Yigit >=20 > [ upstream commit 7a4edfd7bbcd0a3bcb726bc8a109419a600273be ] >=20 > Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": >=20 > ./drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_reta_query=E2= =80=99: > ./drivers/net/ena/ena_rss.c:140:66: > error: the comparison will always evaluate as =E2=80=98false=E2=80=99 fo= r the > pointer operand in =E2=80=98reta_conf + 136=E2=80=99 must not be NULL > [-Werror=3Daddress] > =C2=A0=C2=A0140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) = =3D=3D NULL))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| = ^~ >=20 > Fixing it by removing useless check. >=20 > Signed-off-by: Ferruh Yigit > Acked-by: Michal Krawczyk > Signed-off-by: David Marchand > --- > Note on backport: > - moved change to ena_ethdev.c, >=20 > --- > =C2=A0drivers/net/ena/ena_ethdev.c | 3 +-- > =C2=A01 file changed, 1 insertion(+), 2 deletions(-) Thanks, all applied and pushed. --=20 Kind regards, Luca Boccassi