From: Ferruh Yigit <ferruh.yigit@amd.com>
To: longli@microsoft.com, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Alan Elder <alan.elder@microsoft.com>,
sthemmin@microsoft.com, stable@dpdk.org
Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues
Date: Fri, 18 Oct 2024 01:05:10 +0100 [thread overview]
Message-ID: <51900dc4-babc-43be-a561-d910fbf572f2@amd.com> (raw)
In-Reply-To: <1729192829-30211-1-git-send-email-longli@linuxonhyperv.com>
On 10/17/2024 8:20 PM, longli@linuxonhyperv.com wrote:
> From: Alan Elder <alan.elder@microsoft.com>
>
> The previous code allowed the number of Tx queues to be set higher than
> the number of Rx queues. If a packet was sent on a Tx queue with index
>> = number Rx queues there was a segfault due to accessing beyond the end
> of the dev->data->rx_queues[] array.
>
> This commit fixes the issue by creating an Rx queue for every Tx queue
> meaning that an event buffer is allocated to handle receiving Tx
> completion messages.
>
> mbuf pool and Rx ring are not allocated for these additional Rx queues
> and RSS configuration ensures that no packets are received on them.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: sthemmin@microsoft.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Alan Elder <alan.elder@microsoft.com>
> Signed-off-by: Long Li <longli@microsoft.com>
>
Applied to dpdk-next-net/main, thanks.
Checkpatch warning fixed while merging.
prev parent reply other threads:[~2024-10-18 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 19:20 longli
2024-10-17 22:34 ` Stephen Hemminger
2024-10-17 22:38 ` Long Li
2024-10-17 23:02 ` Stephen Hemminger
2024-10-18 0:04 ` Ferruh Yigit
2024-10-17 23:03 ` Ferruh Yigit
2024-10-18 0:05 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51900dc4-babc-43be-a561-d910fbf572f2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=alan.elder@microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).