From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20048.outbound.protection.outlook.com [40.107.2.48]) by dpdk.org (Postfix) with ESMTP id 9F4AC239 for ; Wed, 23 Jan 2019 06:58:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8OYMnl1CwnPB3TRfzhC2VdGDbVVakGJefM3Y26Lxqk=; b=Il4+9RU6YMK2VnVgBzE1u8xfRU7JHvKkE1kT9411VoIzMQLGlqL9uxn1d6g5cW5T3pPUtiqc9NQF6YLkAxQesn+v2bZIfH3H0KSdyUyQt4DGNRqqAsqlzPNlKEo/3plwUdUzNw59eFHqTJs84pBtSf6AuMSzxDK/vgSjReD2AE4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4043.eurprd05.prod.outlook.com (52.134.68.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Wed, 23 Jan 2019 05:58:36 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c%2]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 05:58:36 +0000 From: Yongseok Koh To: Ali Alnubani CC: "stable@dpdk.org" Thread-Topic: [17.11] net/mlx5: fix initialization of struct members Thread-Index: AQHUsmH9BuJt/OgYj0eA88kqeunlMaW8XJaA Date: Wed, 23 Jan 2019 05:58:36 +0000 Message-ID: <52607FC6-A8DF-499F-A6D8-987500434BA1@mellanox.com> References: <20190122145059.31868-1-alialnu@mellanox.com> In-Reply-To: <20190122145059.31868-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [121.67.5.152] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4043; 6:xecCrlOrodmD7ak6ZHoxFNsnMxDxIgVUbzxWHRjtGoZnWJGFxim3xV/7hbVkK3SS3had9VXpYQ1+HtDt8hkBtCdInqgt737w+VGkRfZKEQN2IGOlRLj7h+u9lPgS96oxzhmuNCYFDktwfIGLwLtXxrKSQ1Fqs/g1rnh0AeUm7vQX7xYtBxc4X3h7/wuRDnY10P7rdd1e6psnt36K4bw1jXEdInU7rZ86nh0Lk889K39hdhBA7yCV447M0rVHcdSKjs1yjHl7ndPvbcqqCLmauyPIO1zm14x0OpLErHzBHALvpJzB659rC6QRB1vIdR4RrGlbm8y8m00oMOYs9jXe38wlYQJY4mowTVxgZewfWwrKabPp/B+bMxhk40v4qNE6cpV1sNfRadODIox4fUuMUGdp0x6MZjjiX5ljW9uLe0frvVyO09ZOVdMAzVKF3lphhMNNo7HbJKIUOmMOpXbK2g==; 5:HnLDWYWhfWfg6Y6hGVayU05LHsbbfNFRDIv4uy0TlyDoD5HmQGQ3YpcQdM4nt8dKZGx66fzC41PIB/p5ZCjAtvxxq3HfaeBZ11JOgPkqmDmW/iK01SgocIwx0Vi2eYf2Sif7iRU/lJ7GL60otZtC4bIIPWpI8qlDUDuqSIea7Yg1tiEp9Nv0GnTJURSOFWDmutt80pybnV7GZoTrnQHg8Q==; 7:ZmIkpZgLhT+826VbrM3UTi7Eym24km1bPoWfqiLd2HbrOLrL2MCklVo0jlEVPk3XSbHiOWekHMm24dS/bHmf+r6lW5Tpbx+D8vcFHOwPlTABCnniQBykMzQz0UWoDgz9x7F4ojFsVXJVFTnRD9t4Hw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 71f215d5-75ef-4943-672f-08d680f7d0da x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4043; x-ms-traffictypediagnostic: DB3PR0502MB4043: x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(136003)(366004)(376002)(189003)(199004)(76176011)(6636002)(53546011)(7736002)(6506007)(316002)(25786009)(26005)(68736007)(446003)(82746002)(53936002)(6436002)(186003)(14444005)(256004)(4326008)(37006003)(6486002)(102836004)(3846002)(71200400001)(71190400001)(6116002)(478600001)(33656002)(97736004)(305945005)(14454004)(229853002)(99286004)(83716004)(105586002)(2906002)(11346002)(8676002)(81156014)(81166006)(106356001)(6246003)(86362001)(6512007)(8936002)(36756003)(2616005)(66066001)(486006)(476003)(6862004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4043; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5kDO7hqLvEIsVP5PCn8ukvA+2p6641bWR/zb5B0KmN2K51SVNXdBvpTnlGuveHpUodi97B0Evd/0kczfX/POW41m4na4Clhhe1PN8N060oReGggcTYLhJHqWhi7xcSENUOcn42FWVIZRF7EGNVSevbK5gWtVVZEUMd/VvC9HAV0bs3MFPPqCM0HdGe90e62x6ySn7M5MInvwMmMZM5shd2RadHZZMDlZIcyncKbWUATXMlQW8+s47niEDGfcHfKWg2cNJeTa+4naDeAPwzzQvohd95XTr2QE7Jk3TMt9ZNvqoShjedcYoNjuibN599iOigPbLIeZWuS8vwI+lSpOkdidwr8ruwbtuFHA6jxv03iWVqYscW5SyU6ovLS5Pf/xSKqsrGUE3ldB2lODhjTvIZZ0FeVQKm0IalR6V2ZFM+s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <3F5DBCF5CAE9FD42B9CE65DE5BCE2E32@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71f215d5-75ef-4943-672f-08d680f7d0da X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 05:58:36.7474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4043 Subject: Re: [dpdk-stable] [17.11] net/mlx5: fix initialization of struct members X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 05:58:41 -0000 > On Jan 22, 2019, at 11:51 PM, Ali Alnubani wrote: >=20 > [ backported from upstream commit 0c15f3c010322853078c20a2a9926d3fb598654= 8 ] >=20 > This patch fixes compilation errors with meson and the clang > compiler caused by some of the struct members not being > initialized. >=20 > ``` > ../drivers/net/mlx5/mlx5_mr.c:345:37: error: missing field 'end' > initializer [-Werror,-Wmissing-field-initializers] > struct mlx5_mr_cache entry =3D { 0, }; > ^ > ../drivers/net/mlx5/mlx5_mr.c:389:36: error: missing field 'end' > initializer [-Werror,-Wmissing-field-initializers] > struct mlx5_mr_cache ret =3D { 0, }; > ^ > ../drivers/net/mlx5/mlx5_mr.c:691:35: error: missing field 'end' > initializer [-Werror,-Wmissing-field-initializers] > struct mlx5_mr_cache ret =3D { 0, }; > ^ > ``` >=20 > The compilation errors reproduce with > clang version 3.4.2 (tags/RELEASE_34/dot2-final) on RHEL. >=20 > Fixes: 87011737b715 ("mlx5: add software counters") >=20 > Signed-off-by: Ali Alnubani > Acked-by: Shahaf Shuler > --- Applied to stable/17.11 thanks, Yongseok > drivers/net/mlx5/mlx5_stats.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.= c > index 345ed7075..e880d24c5 100644 > --- a/drivers/net/mlx5/mlx5_stats.c > +++ b/drivers/net/mlx5/mlx5_stats.c > @@ -356,10 +356,11 @@ int > mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > struct priv *priv =3D dev->data->dev_private; > - struct rte_eth_stats tmp =3D {0}; > + struct rte_eth_stats tmp; > unsigned int i; > unsigned int idx; >=20 > + memset(&tmp, 0, sizeof(tmp)); > /* Add software counters. */ > for (i =3D 0; (i !=3D priv->rxqs_n); ++i) { > struct mlx5_rxq_data *rxq =3D (*priv->rxqs)[i]; > --=20 > 2.19.1 >=20