From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02AD0A0A0B for ; Tue, 26 Jan 2021 18:02:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E82F8140EFD; Tue, 26 Jan 2021 18:02:58 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9DF36140D61; Tue, 26 Jan 2021 18:02:53 +0100 (CET) IronPort-SDR: Za0JRI4xJ4KObFv8vbgfJSEKi8ALhlMnhYktVKkYBZc5ZjbofOfOqRilimyTvDojWAoi49dtP4 knHiYaF2gKRw== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="244014553" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="244014553" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 09:02:51 -0800 IronPort-SDR: ByYpZj2nQI7/ERmyLJdF1nGpnFCOZeOXBMVTvO+e3MKz6HN+kgHOjKiVt1umLSzcbM/bsyfaPe 4lCDW5FZaajA== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="362053889" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 09:02:49 -0800 To: lironh@marvell.com, jerinj@marvell.com Cc: dev@dpdk.org, Yuri Chipchev , stable@dpdk.org, Andrew Rybchenko References: <20201202101212.4717-1-lironh@marvell.com> <20210122191925.24308-1-lironh@marvell.com> <20210122191925.24308-4-lironh@marvell.com> From: Ferruh Yigit Message-ID: <53364cb0-389d-52a8-a282-c756336547d0@intel.com> Date: Tue, 26 Jan 2021 17:02:48 +0000 MIME-Version: 1.0 In-Reply-To: <20210122191925.24308-4-lironh@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes statistics X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/22/2021 7:18 PM, lironh@marvell.com wrote: > From: Yuri Chipchev > > 4B of CRC was not included in the bytes statistics > > Fixes: bdffe0c70 ("net/mrvl: support basic stats") > Cc: stable@dpdk.org > > Signed-off-by: Yuri Chipchev > Reviewed-by: Liron Himi > --- > drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index bfe496ff7..a1a3c0e31 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -1278,7 +1278,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > rx_stats.drop_fullq + > rx_stats.drop_bm + > rxq->drop_mac; > - stats->ibytes += rxq->bytes_recv; > drop_mac += rxq->drop_mac; > } > > @@ -1306,7 +1305,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > > stats->q_opackets[idx] = tx_stats.deq_desc; > stats->q_obytes[idx] = txq->bytes_sent; > - stats->obytes += txq->bytes_sent; > } > > ret = pp2_ppio_get_statistics(priv->ppio, &ppio_stats, 0); > @@ -1315,6 +1313,8 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > return ret; > } > > + stats->ibytes += ppio_stats.rx_bytes; > + stats->obytes += ppio_stats.tx_bytes; > stats->ipackets += ppio_stats.rx_packets - drop_mac; > stats->opackets += ppio_stats.tx_packets; > stats->imissed += ppio_stats.rx_fullq_dropped + > Is this patch adding CRC to the stats? If so that is wrong, stats should not have the CRC. A recent clarification from Andrew: https://patches.dpdk.org/patch/86975/