patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>, fiona.trahe@intel.com
Cc: stable@dpdk.org, Damian Nowak <damianx.nowak@intel.com>
Subject: Re: [dpdk-stable] [PATCH 17.11] crypto/qat: fix null auth issues when using vfio_pci
Date: Thu, 09 Jan 2020 09:07:06 +0000
Message-ID: <5451ff6b22a9182517507243d1fe3b22a84def57.camel@debian.org> (raw)
In-Reply-To: <20200108153301.9916-1-arkadiuszx.kusztal@intel.com>

On Wed, 2020-01-08 at 16:33 +0100, Arek Kusztal wrote:
> [ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ]
> 
> When running auth NULL cases while using vfio_pci,
> DMAR read/write faults appear. It happens even if
> digest_length is set to 0. This is caused by auth_res_addr
> initialized as 0x0.
> 
> Fixes: 4e0955bddb08
> Cc: 
> stable@dpdk.org
> 
> 
> Signed-off-by: Damian Nowak <
> damianx.nowak@intel.com
> >
> Signed-off-by: Arek Kusztal <
> arkadiuszx.kusztal@intel.com
> >
> ---
>  drivers/crypto/qat/qat_crypto.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_crypto.c
> b/drivers/crypto/qat/qat_crypto.c
> index 85a9ba0..05b37e6 100644
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -1370,10 +1370,8 @@ qat_write_hw_desc_entry(struct rte_crypto_op
> *op, uint8_t *out_msg,
>  
>  		}
>  		min_ofs = auth_ofs;
> -
> -		if (likely(ctx->qat_hash_alg !=
> ICP_QAT_HW_AUTH_ALGO_NULL))
> -			auth_param->auth_res_addr =
> -					op->sym->auth.digest.phys_addr;
> +		auth_param->auth_res_addr =
> +			op->sym->auth.digest.phys_addr;
>  
>  	}
>  

Thank you, applied with a small fix to the commit message (Fixes: line
and removed CC).

-- 
Kind regards,
Luca Boccassi

      reply	other threads:[~2020-01-09  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 15:33 Arek Kusztal
2020-01-09  9:07 ` Luca Boccassi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5451ff6b22a9182517507243d1fe3b22a84def57.camel@debian.org \
    --to=bluca@debian.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=damianx.nowak@intel.com \
    --cc=fiona.trahe@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git