patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>, dev@dpdk.org
Cc: "Chaoyong.He" <chaoyong.he@corigine.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: fix nfp multiport syntax
Date: Mon, 1 Mar 2021 13:45:41 +0000	[thread overview]
Message-ID: <54de2177-d56c-2281-2e92-8603450a99c6@intel.com> (raw)
In-Reply-To: <20210225114622.2431-1-heinrich.kuhn@netronome.com>

On 2/25/2021 11:46 AM, Heinrich Kuhn wrote:
> From: "Chaoyong.He" <chaoyong.he@corigine.com>
> 
> 1. Fixup the suffix of the PCI ID to be consistent with the code.
> 2. Add specification of using MAC address to identify port.
> 
> Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaoyong.He <chaoyong.he@corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> ---
>   doc/guides/nics/nfp.rst | 14 +++++++++-----
>   1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/nics/nfp.rst b/doc/guides/nics/nfp.rst
> index fef99973b..2b170539d 100644
> --- a/doc/guides/nics/nfp.rst
> +++ b/doc/guides/nics/nfp.rst
> @@ -117,15 +117,19 @@ although once they are created, DPDK apps should be able to use them as normal
>   PCI ports.
>   
>   NFP ports belonging to same PF can be seen inside PMD initialization with a
> -suffix added to the PCI ID: wwww:xx:yy.z_port_n. For example, a PF with PCI ID
> +suffix added to the PCI ID: wwww:xx:yy.z_portn. For example, a PF with PCI ID
>   0000:03:00.0 and four ports is seen by the PMD code as:
>   
>      .. code-block:: console
>   
> -      0000:03:00.0_port_0
> -      0000:03:00.0_port_1
> -      0000:03:00.0_port_2
> -      0000:03:00.0_port_3
> +      0000:03:00.0_port0
> +      0000:03:00.0_port1
> +      0000:03:00.0_port2
> +      0000:03:00.0_port3
> +

+1 to fix.

> +Some dpdk applications can choose to use the MAC address to identify ports,
> +OVS-DPDK is one such example, please refer to:
> +https://docs.openvswitch.org/en/latest/howto/dpdk/

This is not PMD specific information, not sure to have here,
also not sure to have an external link here, basically for the maintenance 
concerns, should we document this usage withing DPDK in a wider than a PMD scope?


      reply	other threads:[~2021-03-01 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 11:46 Heinrich Kuhn
2021-03-01 13:45 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54de2177-d56c-2281-2e92-8603450a99c6@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=heinrich.kuhn@netronome.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).