patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eal: mark version parts API as experimental
@ 2021-03-17 15:15 Thomas Monjalon
  2021-03-18 12:29 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2021-03-17 15:15 UTC (permalink / raw)
  To: dev; +Cc: stable, David Marchand, Ray Kinsella, Neil Horman, Bruce Richardson

Some functions were introduced in DPDK 21.05 to query the version parts
(prefix, year, month, minor, suffix, release) at runtime.
Per guidelines, these new public functions must be marked with
__rte_experimental and ABI versioned as EXPERIMENTAL.

Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: stable@dpdk.org

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/include/rte_version.h |  7 +++++++
 lib/librte_eal/version.map           | 14 ++++++++------
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h
index 736c5703be..b06a62e7a2 100644
--- a/lib/librte_eal/include/rte_version.h
+++ b/lib/librte_eal/include/rte_version.h
@@ -18,6 +18,7 @@ extern "C" {
 #include <string.h>
 #include <stdio.h>
 #include <rte_common.h>
+#include <rte_compat.h>
 
 /**
  * Macro to compute a version number usable for comparisons
@@ -36,31 +37,37 @@ extern "C" {
 /**
  * Function to return DPDK version prefix string
  */
+__rte_experimental
 const char *rte_version_prefix(void);
 
 /**
  * Function to return DPDK version year
  */
+__rte_experimental
 unsigned int rte_version_year(void);
 
 /**
  * Function to return DPDK version month
  */
+__rte_experimental
 unsigned int rte_version_month(void);
 
 /**
  * Function to return DPDK minor version number
  */
+__rte_experimental
 unsigned int rte_version_minor(void);
 
 /**
  * Function to return DPDK version suffix for any release candidates
  */
+__rte_experimental
 const char *rte_version_suffix(void);
 
 /**
  * Function to return DPDK version release candidate value
  */
+__rte_experimental
 unsigned int rte_version_release(void);
 
 /**
diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map
index 756c60ed1d..48a2b55d57 100644
--- a/lib/librte_eal/version.map
+++ b/lib/librte_eal/version.map
@@ -200,12 +200,6 @@ DPDK_21 {
 	rte_uuid_parse;
 	rte_uuid_unparse;
 	rte_version;
-	rte_version_minor;
-	rte_version_month;
-	rte_version_prefix;
-	rte_version_release;
-	rte_version_suffix;
-	rte_version_year;
 	rte_vfio_clear_group;
 	rte_vfio_container_create;
 	rte_vfio_container_destroy;
@@ -419,6 +413,14 @@ EXPERIMENTAL {
 	rte_thread_tls_key_delete;
 	rte_thread_tls_value_get;
 	rte_thread_tls_value_set;
+
+	# added in 21.05
+	rte_version_minor;
+	rte_version_month;
+	rte_version_prefix;
+	rte_version_release;
+	rte_version_suffix;
+	rte_version_year;
 };
 
 INTERNAL {
-- 
2.30.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] eal: mark version parts API as experimental
  2021-03-17 15:15 [dpdk-stable] [PATCH] eal: mark version parts API as experimental Thomas Monjalon
@ 2021-03-18 12:29 ` Bruce Richardson
  2021-03-19 15:21   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2021-03-18 12:29 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, stable, David Marchand, Ray Kinsella, Neil Horman

On Wed, Mar 17, 2021 at 04:15:35PM +0100, Thomas Monjalon wrote:
> Some functions were introduced in DPDK 21.05 to query the version parts
> (prefix, year, month, minor, suffix, release) at runtime.
> Per guidelines, these new public functions must be marked with
> __rte_experimental and ABI versioned as EXPERIMENTAL.
> 
> Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> Cc: stable@dpdk.org
> 
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: mark version parts API as experimental
  2021-03-18 12:29 ` Bruce Richardson
@ 2021-03-19 15:21   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-03-19 15:21 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, stable, David Marchand, Ray Kinsella

18/03/2021 13:29, Bruce Richardson:
> On Wed, Mar 17, 2021 at 04:15:35PM +0100, Thomas Monjalon wrote:
> > Some functions were introduced in DPDK 21.05 to query the version parts
> > (prefix, year, month, minor, suffix, release) at runtime.
> > Per guidelines, these new public functions must be marked with
> > __rte_experimental and ABI versioned as EXPERIMENTAL.
> > 
> > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
> > Cc: stable@dpdk.org
> > 
> > Suggested-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-19 15:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 15:15 [dpdk-stable] [PATCH] eal: mark version parts API as experimental Thomas Monjalon
2021-03-18 12:29 ` Bruce Richardson
2021-03-19 15:21   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git