From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEEE741CC4 for ; Fri, 17 Feb 2023 23:34:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B72904113F; Fri, 17 Feb 2023 23:34:40 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 069CF40EE3; Fri, 17 Feb 2023 23:34:38 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3A6AD5C00A9; Fri, 17 Feb 2023 17:34:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 17 Feb 2023 17:34:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676673276; x= 1676759676; bh=9NUGOZpR6XuH79er+i+zlKHCzD/rf1Jz6iWHMINrWLE=; b=H LK/MdZ/w6No1XmPf6rwC/RJWEITKnA4CLw8zqugqEj+GeNoQQeU+bgxz83tSQJr0 O3ox1Sg/B+yACc9C+fAPn5djBSbuttO3IdD0xZjtM/Q/FsiEkcB6qJUQVtD0RQe9 k1Yq/mfc1ytAI32ZA58FQ198DSOSJ/R7CRzElhyYgcGetB+0gvnQyUQkrbyhMJS/ G3x4Yen3wSoKQD171bFRNmm+w7hSTU6+hXVFOzSSHcnQ/mIMwzjsSFUuWpqNhd2k he9IMKDTJSNCR7r94LHm8/RYJJWdu4t+DWgfHHXkyeEGCqDN9ALtgk1IA9wVoeHH ibgC4/bu8L+tK9sgIOc2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676673276; x= 1676759676; bh=9NUGOZpR6XuH79er+i+zlKHCzD/rf1Jz6iWHMINrWLE=; b=q HEGf202JiOu3TwuGQWV025Pa5vYL09QFudNdaNZ5cr/4zep+BBiAiMz1a/cDsTLc WqiuBfPaF5HioL13fRimDro3ujzsGicwsjclJWVl2itZnpmzImfI2h8YJplo/pkY VGYjVMfJEcHvNN1pLRoF8k2BKvVsANis9FXywRCC4a6x5qQnLOlAy6RfVOXaUS7L 6pAGlW4F9ow0e/mm8PxVO6dSsrLNrTyYdXgKGoP4qap/sAvpOArXFl7P5FGX1B4G IIdmHrgyEZ9P1upqgm2GGXzpoCdQwGJ7xuZwuuFacFdQ2VRdOF6xKyZqUFvdyv9b 6fP1bbXwYU9McyKijktaw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 17:34:35 -0500 (EST) From: Thomas Monjalon To: "Xing, Beilei" , "Wu, Jingjing" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH] net/idpf: fix build option check Date: Fri, 17 Feb 2023 23:34:33 +0100 Message-ID: <5743955.zQ0Gbyo6oJ@thomas> In-Reply-To: References: <20221208033127.57161-1-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 13/12/2022 02:52, Zhang, Qi Z: > From: Xing, Beilei > > From: Wu, Jingjing > > > When enable_iova_as_pa option is disabled, idpf driver should avoid > > > the building in its build file. > > > > > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue > > > model) > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Jingjing Wu > > > --- > > > --- a/drivers/net/idpf/meson.build > > > +++ b/drivers/net/idpf/meson.build > > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 > > > + build = false > > > + reason = 'driver does not support disabling IOVA as PA mode' > > > + subdir_done() > > > +endif > > > > Acked-by: Beilei Xing > > Applied to dpdk-next-net-intel. I think this patch is not needed since we have this check done for all drivers: + pmd_supports_disable_iova_as_pa = false [...] + if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path) + build = false + reason = 'driver does not support disabling IOVA as PA mode' + endif I will skip this patch and mark it as Rejected in patchwork. Please confirm the decision is OK.