From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Sebastian Scheinkman <sscheink@redhat.com>,
dpdk stable <stable@dpdk.org>, Aaron Conole <aconole@redhat.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
rasland@nvidia.com, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux
Date: Tue, 06 Oct 2020 01:13:06 +0200 [thread overview]
Message-ID: <5847579.AWupWrHo64@thomas> (raw)
In-Reply-To: <b97c4ad3-636d-0ea0-1b84-25a4f69876aa@intel.com>
02/10/2020 14:12, Burakov, Anatoly:
> On 02-Oct-20 10:36 AM, David Marchand wrote:
> > On Thu, Sep 17, 2020 at 4:47 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> >>
> >> On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly
> >> <anatoly.burakov@intel.com> wrote:
> >>> Anonymous hugepages shouldn't matter, yes, but single-file segments mode
> >>> does fallocate() and remove - you have the remove part covered, but i'm
> >>> just curious if fallocate() would also cause any issues with SELinux.
> >>
> >> I found no hook in the kernel for fallocate + selinux...
> >> Looked into fallocate itself and it ends up validating lsm write
> >> access on the file.
> >>
> >> I don't have the full setup atm but since I could truncate and write
> >> to it, I'd say we are good.
> >
> > I could not gain access to the same setup again.
> >
> > FWIW, I tried with my reproducer:
> > - no issue with --in-memory option (with or without patch)
> >
> > - error correctly detected (with this patch) in normal mode after restarting:
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-10-05 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:24 [dpdk-stable] " David Marchand
2020-09-11 12:46 ` Burakov, Anatoly
2020-09-17 13:47 ` David Marchand
2020-09-17 14:17 ` Burakov, Anatoly
2020-09-17 14:44 ` Aaron Conole
2020-09-17 14:47 ` David Marchand
2020-10-02 9:36 ` David Marchand
2020-10-02 12:12 ` Burakov, Anatoly
2020-10-05 23:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5847579.AWupWrHo64@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=rasland@nvidia.com \
--cc=sscheink@redhat.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).