From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65D49431F0 for ; Tue, 24 Oct 2023 16:49:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52A11406A2; Tue, 24 Oct 2023 16:49:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 96ED9402C5; Tue, 24 Oct 2023 16:49:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698158953; x=1729694953; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=OvN7XpFpmfKEIi15O+gDPFjsCMPP+vFkA2+rsWaO8TY=; b=VQ36zRur3E//V7FMFGAKP3bRJAucH3DRWmoWYzN+AHgnaPNjzR02x0Xm mFjzrKbctSuYrusnmLeYoM6rHvxrTCR21wK5aOvZzq338fT6aFHUMy8+2 pbZ1QguZK/2p8cfYxPbtCm2ZD7zrfvau1YnIhup8qJd3I3TFmyKe6hXhX BhODQdyiDK6u7CH5p8TTnHCb6rJ0jgmJ/sn/uTOrJbYxckYHtq0i7uCuf wA4aAVTuDLi6KQv2y9ec/IopftmTjAt6X5RkvhP9ZXZFpqmBEkVjbMr65 J6XRBiJj2eUpODx97oCpG0YhAxCCDlveAOAy5Zt1wqU2TrH2vvOcKpA20 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="372130376" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="372130376" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 07:49:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="828850654" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="828850654" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 07:49:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 07:49:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 07:49:07 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 07:49:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEvyct1ohNl7XL2g8uttOOSFzpicuBVkc6pQrvPf97c/k0yQOl6ZTl+Zo1+MFNPCfsJVUracz7MOKcNbVRiNzOdjbUEU1bRRC99yHczfyhmfgsym31y/gResWy6EQA3joTLryw1cGUSnYHFKmgd/duLEKFEyxtEqHUEtf/QdhQNoudiVzkGhEmjkNeOr6b762oIo99d4cEgZVyK5MtjCB1OtkcvCa3vT78wwHMNQuO6laLnsANuZvpRTCClV8Ge1cA2r7A8W6DYbL6+NP/tNtcjLpXfV3CgGxIxMgORMFRZR2esWPdePY4UPOIAcQ8LHYN/n5aNqJN+fNsKMywOUJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvN7XpFpmfKEIi15O+gDPFjsCMPP+vFkA2+rsWaO8TY=; b=Zlrn9Xp04e3x5LG7HbWufvPbWSGRIwxbmLuIZXa7pz4PgTbJ9pSNBiBltcIPKbs0nWbZK+byJNBVUgr1/DKRFuOJZUrhyMO67JTdfFuBjpclzCq+m3m3FBQGS0Z7e7nWEmWpnkYdAkd7MOYdkvgwMA4eRJkzdZjsoBCZ6o/gYqeS1bdeLIWtMXS6zmh/C0qoMuNVx8DrwhOu8P8nCbdf1g4QHtyHp5dWRIIMum9HoVG47zzj4ONXyBfm0krBgM/rmB3VWC6hda010dH0AFgxFnQnrS9s9Qx6kel3Q6qAuODaHR15ETzjecx9ElISaF9UC6f++EWLdEWrUq4RD0WczA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by CY5PR11MB6343.namprd11.prod.outlook.com (2603:10b6:930:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Tue, 24 Oct 2023 14:48:59 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 14:48:59 +0000 Message-ID: <59156c1c-c023-2504-6de5-6a84457e5ede@intel.com> Date: Tue, 24 Oct 2023 15:48:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition To: "Zhang, Qi Z" , "Marchand, David" CC: "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "stable@dpdk.org" References: <20231024091328.11933-1-radu.nicolau@intel.com> <54859de7-c108-8389-43bc-9602a9897afc@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0151.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::13) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|CY5PR11MB6343:EE_ X-MS-Office365-Filtering-Correlation-Id: f2d11539-86f6-4d6b-8a8a-08dbd4a05b33 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PdAZlt18X5G+N4y//WrZ/BNJ08sh2vbB02rQwoQKFYwuc95gR7S0mC7yZlMhdTki9kYs4AnNqhkuunFSC7XIbxAc2dWFOMDrLgmQZUfl7d23csNE45LtGdR+5jib61IKkNJULQt5+TurDI6hn2XNxIx4gq+5HdM3/D/Bjr4ycTOigV7jmBRykVtZuQPkkTKKmMc5w41+Mq2P50kmfD+9alu3hM1zJJkhGugcrPby7GLNQ3NWkVoF+Fjfx5lJz5wSJvrtLHaMFbxZdcR0l+7n1Tmh+vDv/pCiZJVax43jG7e71iJfzBHf37QGp2Gc4PS6F4Vf806NOemiIswfXgXnUZI7nkmf51ocgtS4OpSEpzCmqjp/fX4+SD2ygGZkCBMeGH1PlZPaTKosfo10SumPc47f/EgD1IvUotFzLpRSvgvpALg1y1sQCgjKO8VxmIuumKhJS3Kr29esBvt36SQWXTPXkV1G1ta4tuYEjOOpyXr3JCtKyei4CeU0WQau3q+mHRDDjAtzqB36Rs8cHeTJdyUdErQFt7LddYHC8c9QGhRcKd5r1cShcfxxonZl+elqlBDCwQIdD0MoJV0jYf20J5U5rwvqNrDySQUkwSVOX3oCthvBCffHRsPoihrty+BnMGTvU/JfolHI3Vod74av7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(2906002)(38100700002)(316002)(110136005)(2616005)(66946007)(54906003)(82960400001)(66476007)(66556008)(6506007)(478600001)(6486002)(55236004)(6512007)(53546011)(6666004)(83380400001)(36756003)(4326008)(86362001)(44832011)(41300700001)(31696002)(5660300002)(8676002)(8936002)(26005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUxNdDZGTkhlVDdXQU5XQlVuVXowYkI2QXV3akdKTkVTenkvMGpldkdwL3dU?= =?utf-8?B?SWJ6eit6MXlhMEkxMDl2TldXa1Z3RUxhdkgrb1VreHV4cjMrcUFJNXRNRWRa?= =?utf-8?B?QkVjN1RWbEVPUGlhU0Y4Z2tWUTNMRDJ0NGR6SERCbnc1bW0rQ2toVEFlaHNX?= =?utf-8?B?VjFOTDdrdVVhOW8wQ0J4dGFYbHBYWFpkUDI2TzJhMzE4dklDYXpNY0FzKzlI?= =?utf-8?B?SVFPVWdzOUpmdWNUbkhRNEhlc1lXVXp4NWFKYytuc2NLMExPc1p0Ni9SZHlu?= =?utf-8?B?bXA5L041Z1p5UnYzemN3aFVGNzZHdVNFTHVuQ2VlWldZTjRvYjRNeUY4NG1I?= =?utf-8?B?c3VVS2dsTHBPMExleHJEa0l1cTQ4K3ppTm1hcStXL0VXQjI3Rm5IM2lCQ2to?= =?utf-8?B?VDdKbGcveXVqTjNVelA3SWVRZktHL0RNaTM5aDUraUtmblFDcERFRVUzbjY1?= =?utf-8?B?NFBVOFNXbWVpbWxuMVl5MkFUcWloeTVGRUx0OWVlaG5CV2VPTGNuNmpDQ1Zv?= =?utf-8?B?VWt1SWZ4VTM5Mlg0c01kdytNWjZIMis4cHd3cWw5MjQ4b0xWVGg2Y3NqM2ZK?= =?utf-8?B?VkduMFRIdEViTDY2R1VHTjRxUWtsMUVXd2pCOEJNQmRWUVZweS9nUHB4a0t5?= =?utf-8?B?bE5nZ0hselRsbkYySWJoZmNZaU4wamZiY2JzdnlZamVhamQraDJuU0t4dlll?= =?utf-8?B?cmNZdWxVV3h5NDhTcFdnaHNlRGo5QUVqS0hpOU1vWW9vaE9WUTVkTGFreGx1?= =?utf-8?B?aFdzRncxMU1wS2cxVSt4ai9TRmpwTjZONTNMRVhBcU1FTHkrR0ZEYmVqVmNv?= =?utf-8?B?NE8yOEI4TTVMZUZ5YWo1YWpEVytyeklZR2tQT3lQODZUZjlNR1hxekxHRUYw?= =?utf-8?B?MkhkZGk2UmwvTXpnVi9kL1ZKdERHK0tSYjd3YklnN3BacWNwdFZNc2NVaEZD?= =?utf-8?B?UStURWlkVVVDemU0TDFlYUIyL0pmdVJhdnN0WlFRRVNCbGNsMnFTSHltcHZ0?= =?utf-8?B?Ymkwc2ZtRmFoUVpmYXJnajhFc2FxVlhxc1RTOStWekZXMWthbUtabGpQK21v?= =?utf-8?B?QmtsdHhudlIxQTRzMGt0cmhXNjdLa1orSjhUTDBGS0tpYWVSR0tuMzRtRFQ0?= =?utf-8?B?TjBlK2l3SXVnR1NjOERQMWE5TzAwc1R3L3U0cjhCeHhRUk1xdDRlVEV0OERl?= =?utf-8?B?d1ZOVllIVzNJWFJmcXZJWk55ZXFmUHg1V2MzL0JlOGU0ZXo0bmJrZEpBRmFo?= =?utf-8?B?Nkx1R1hReDF3amcrd1FjeUlSVjV1VFZ5MVE1ZlJvSk05d0lhZzJuOVYwS0ZI?= =?utf-8?B?OWNuOG1PVFhtNVNhNVYyQ0E2R2Y0TVhoQkpxM2kvN01Qelc3Z3FCLzloWWtl?= =?utf-8?B?bGYxRkdkdm5yazErQUxORlpFYm93dUxVWjVRY3NhUXMrbUMrRG13VWVrc3BC?= =?utf-8?B?b0FNN0owZENqdVFSbjhWS0VRTTUzTVFQTDFRTW9VSS93eTRzWHB6Ujc0ZjFV?= =?utf-8?B?WHB5aEZJK0wwVkFiSitiY3ZzbXhWR3Z2T01NTHloY2NSRVZ6U1psSTFzQml2?= =?utf-8?B?WittaWhyVmhYVTg0bE1TUTcxT0F1cTB2N1VMa1lMTUlLVzBSaUFRa0c4Vkhu?= =?utf-8?B?MkVWcW9TRGxCNENsQzhoSVNkME1GK1RqU003bEs3bXNTVlYrVGxyTE54V3R1?= =?utf-8?B?dEMwNXhIbk9RKzRESlBLNU1aaE5WdEhORnhyVmF1RzlKNzdPc1UzK1AwSXJH?= =?utf-8?B?RlovSjdsMjdtd0cyMlZxN3FaR3JhMks2K3pQZnkvMTZhME5sbW9NZHB2WXJR?= =?utf-8?B?T0QvaFFlTkZjODF4TjZsNEoyOVMwSmhqdThrWk44REdTZ1plYk9Rb0huMTA5?= =?utf-8?B?U1FMNnNjeGFqczVWa3J5bW9NWGRlalhmQmFwZDgvN0tWNVhwRjhVWktKQ0Vq?= =?utf-8?B?bDRpRnB1eEI5NVVxMG5oZXRaZyt5ZjlKOXhETk12TFZzTmpCNnBjSHRzR3RF?= =?utf-8?B?VUhmTUJObk1tNWhOeXFiV1NtTkJQTGlqY2JGSkJkWlBQWlowOU9SbzVpcjRQ?= =?utf-8?B?dUl5dHBMVWJRZUdLejJOYmdwVFVaVEVvYkhZYmdUc1lqS3JDaS9NTko5S3pW?= =?utf-8?B?SGJLR01sdlhhem1TSnFUWEt1YjdkN0o4aHRMWllWOSsrRjl2NXVGcnNwTGx1?= =?utf-8?B?TEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f2d11539-86f6-4d6b-8a8a-08dbd4a05b33 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 14:48:59.5856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qS+FsT3xEb9oqFRX/ZC5/aBXQVWHl9lRGwa8A7fqhBJX/Ui3edOt70fbAfaqmASIx9cPonSGVK6sjceHt01Abw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6343 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 24-Oct-23 12:24 PM, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Radu Nicolau >> Sent: Tuesday, October 24, 2023 6:23 PM >> To: Marchand, David >> Cc: Wu, Jingjing ; Xing, Beilei ; >> dev@dpdk.org; stable@dpdk.org >> Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition >> >> >> On 24-Oct-23 10:49 AM, David Marchand wrote: >>> On Tue, Oct 24, 2023 at 11:13 AM Radu Nicolau >> wrote: >>>> IAVF_TX_OFFLOAD_MASK definition contained >> RTE_ETH_TX_OFFLOAD_SECURITY >>>> instead of RTE_MBUF_F_TX_SEC_OFFLOAD. >>>> >>>> Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Radu Nicolau >>> Something is not clear to me. >>> How was the IPsec inline crypto feature supposed to work with this >>> driver so far? >>> >>> Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have been >>> refused in iavf_prep_pkts. >>> >> It worked because the IPsec sample app doesn't call rte_eth_tx_prepare, and >> from what I can see no other sample app does. > To keep consistent, its better to refine the IAVF_TX_OFFLOAD_NOTSUP_MASK definition. You mean like this? #define IAVF_TX_OFFLOAD_NOTSUP_MASK ( \         RTE_MBUF_F_TX_OFFLOAD_MASK ^ (  \             RTE_MBUF_F_TX_OUTER_IPV6 |         \             RTE_MBUF_F_TX_OUTER_IPV4 |         \             RTE_MBUF_F_TX_IPV6 |             \             RTE_MBUF_F_TX_IPV4 |             \             RTE_MBUF_F_TX_VLAN |         \             RTE_MBUF_F_TX_IP_CKSUM |         \             RTE_MBUF_F_TX_L4_MASK |         \             RTE_MBUF_F_TX_TCP_SEG |         \             RTE_MBUF_F_TX_UDP_SEG |      \             RTE_MBUF_F_TX_TUNNEL_MASK |    \             RTE_MBUF_F_TX_OUTER_IP_CKSUM |  \             RTE_MBUF_F_TX_OUTER_UDP_CKSUM | \             RTE_MBUF_F_TX_SEC_OFFLOAD))