patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: 197020236@qq.com
Cc: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code
Date: Fri, 17 Jul 2020 13:46:15 +0100
Message-ID: <5925dbda-d5ad-d8be-0b7a-2b6b468f5d16@intel.com> (raw)
In-Reply-To: <103832be-5f45-8d6b-3114-86336caa774d@huawei.com>

On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> 
> 
> On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
>>
>>
>> On 2020/7/4 9:15, 197020236@qq.com wrote:
>>> From: pandongyang <197020236@qq.com>
>>>
>>> The function valid_bonded_port_id() has already contains function
>>> rte_eth_dev_is_valid_port(), so delete redundant check.
>>>
>>> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: pandongyang <197020236@qq.com>

Hi pandongyang,

Can you please provide the sign-off in following format:
Name Surname <email@address.com>

We need this to be able to accept the patch.

Thanks,
ferruh


>> Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>>> ---
>>> v1 -> v2: Adjust commit info
>>> ---
>>>   drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>>>   1 file changed, 6 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
>>> b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> index b77a37ddb..339374337 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
>>> @@ -1675,9 +1675,6 @@ 
>>> rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>>>       dev = &rte_eth_devices[port];
>>>       internals = dev->data->dev_private;
>>>   -    if (check_for_bonded_ethdev(dev) != 0)
>>> -        return -1;
>>> -
>>>       if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>>>           return -1;
>>>   @@ -1704,9 +1701,6 @@ 
>>> rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>>>       dev = &rte_eth_devices[port];
>>>       internals = dev->data->dev_private;
>>>   -    if (check_for_bonded_ethdev(dev) != 0)
>>> -        return -1;
>>> -
>>>       /* Device must be stopped to set up slow queue */
>>>       if (dev->data->dev_started)
>>>           return -1;
>>
> 


  reply	other threads:[~2020-07-17 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com>
2020-07-04  1:22 ` Wei Hu (Xavier)
2020-07-17 11:22   ` Wei Hu (Xavier)
2020-07-17 12:46     ` Ferruh Yigit [this message]
2020-07-20 22:51   ` Ferruh Yigit
2020-07-04  1:15 197020236

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5925dbda-d5ad-d8be-0b7a-2b6b468f5d16@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=197020236@qq.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git