From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20378A0A0A
	for <public@inbox.dpdk.org>; Fri, 21 May 2021 17:10:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0AB3041100;
	Fri, 21 May 2021 17:10:47 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25])
 by mails.dpdk.org (Postfix) with ESMTP id C123240143;
 Fri, 21 May 2021 17:10:44 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 9C88813A5;
 Fri, 21 May 2021 11:10:43 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 21 May 2021 11:10:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 NwECsH4EUJyWrSLe+G/rf6yQAaxALaDZxrs0k+dPgwg=; b=uO6mFXaT35p24IwP
 sb1Y7BY8QFM7jjYp2iqVQrunVBivR0/j+cAbgXpBLC7PDH2eR7RHSyBH4fDyYXDj
 BwmA7fO/f96w/qK0eJrN5svBulsyW2KXFVmr2E5OTP6N0gl/+Z+fOlCm+uDt9htj
 lCb54gqRbVT3XfL5X5jovsbpWdzYmAdecPd4uyALVtlQI3Ci7vGi/h15ECvEEIDN
 mhLvjOOsux2ClKn41CjrYyvna/myLTIcjNVVysIySnkMJuu9vmZilMIt8brD6iOC
 wTCh8wAqDIuhd9CEXbgk6nfRVAEPL8LO3OAVIve3ew6Y3mPagUGV3r8JT0X46dN1
 dSvh1w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=NwECsH4EUJyWrSLe+G/rf6yQAaxALaDZxrs0k+dPg
 wg=; b=wPp5RSRUP2OH1wAZAIVfAu9ubhou7lFBnrcyNSsKW+9ycGlbN/tQs++em
 OyALMpB3c2oa0DGQCx2GGVZhmJq4KTECnmFXYS5G/QlXqilTvTSIVRzGGLOHbwia
 HpzkhDZze1ACmA5rPfNeFdfnbWfaqYZBdS7kT8nJ5eDPwj8xmVhAPND+5yeAKNrq
 1OZzhKkjAE8As5scIYLrvgcwJZRHAzT/Rznlbk8BPmRmQCbUZG4Vd9f5c3Wl7tWC
 Mm7a0W36o0HTFh7nQ1LniZ9xinkn4GmHu3c5Im8+DQdgs7OL+RElVfGrJWbZV7xJ
 SYy95dbzIbfVKx8UcupVJaXWt2Bnw==
X-ME-Sender: <xms:cs2nYHTi8gfm1jakaKFm81j8gW2N3tRTjO5yGudsbxcHV5b3paTjnw>
 <xme:cs2nYIy_xDxM2AoXvRaQtCazC6g1J5CzstbJh867rLqFSbJs4KFFV4h3oZbCOa74k
 JLJ9_ZQ1HdZIaYhXw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgkeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu
 tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:cs2nYM2uTZjUmOdmRffIrstAnVX_bnAaU7AIYeI5mh6yhjQraM3tDA>
 <xmx:cs2nYHAH_9MuC-cgT6_gUiaoQ8W8p89qpRiR2qbGT_fanEXr8hXnug>
 <xmx:cs2nYAiPyJuLjufbuoxpqB-CFyr3Pq30FN0ku4SotAhfymkjsvM1Sg>
 <xmx:c82nYMaQBXi9ZZE_Km3YFSvh9qQm2xKyPv-1eOJ7dSdROhVn7ED7jg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 11:10:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: liangma@liangbit.com, Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Date: Fri, 21 May 2021 17:10:41 +0200
Message-ID: <5942248.XgMt1RgFVE@thomas>
In-Reply-To: <20210521144207.13802-1-konstantin.ananyev@intel.com>
References: <20210521144207.13802-1-konstantin.ananyev@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] acl: fix build with GCC 6.3
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

21/05/2021 16:42, Konstantin Ananyev:
> --buildtype=3Ddebug with gcc 6.3 produces the following error:
>=20
> ../lib/librte_acl/acl_run_avx512_common.h: In function
> =E2=80=98resolve_match_idx_avx512x16=E2=80=99:
> ../lib/librte_acl/acl_run_avx512x16.h:33:18: error:
> 	the last argument must be an 8-bit immediate
>                                ^
> ../lib/librte_acl/acl_run_avx512_common.h:373:9: note:
> 	in expansion of macro =E2=80=98_M_I_=E2=80=99
>       return _M_I_(slli_epi32)(mi, match_log);
>              ^~~~~
>=20
> Seems like gcc-6.3 complains about the following construct:
>=20
> static const uint32_t match_log =3D 5;
>     ...
> _mm512_slli_epi32(mi, match_log);
>=20
> It can't substitute constant variable 'match_log' with its actual value.
> The fix replaces constant variable with its immediate value.
>=20
> Bugzilla ID: 717
> Fixes: b64c2295f7fc ("acl: add 256-bit AVX512 classify method")
> Fixes: 45da22e42ec3 ("acl: add 512-bit AVX512 classify method")
> Cc: stable@dpdk.org
>=20
> Reported-by: Liang Ma <liangma@liangbit.com>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

How much critical is it?
It looks safer to wait for 21.08 cycle?