From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Sunil Kumar Kori <skori@marvell.com>
Cc: Alfredo Cardigliano <cardigliano@ntop.org>,
dpdk-dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/1] net/ionic: use standard stdbool.h
Date: Mon, 9 Mar 2020 08:43:33 +0000 [thread overview]
Message-ID: <5aa619e5-0b2d-79b5-2eda-4cfec903b35e@intel.com> (raw)
In-Reply-To: <CALBAE1Pxue+TKaim0JNiJi15D4rKfeT+0a6_0ts8DB6Tu1mXEw@mail.gmail.com>
On 3/9/2020 8:16 AM, Jerin Jacob wrote:
> On Mon, Mar 9, 2020 at 1:23 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>>
>> Any DPDK public header file which includes stdbool.h may conflict with
>> local definition of bool, if any, which further results in compilation
>> error. To avoid, used standard stdbool.h instead of defining bool
>> internally.
>>
>> I observed this issue during a development where I included rte_uuid.h
>> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
>> throwing error as given below:
>>
>> CC ionic_rxtx.o
>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>> from .../dpdk/build/include/rte_ethdev.h:161,
>> from .../dpdk/build/include/rte_ethdev_driver.h:18,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
>> typedef uint8_t bool;
>> ^
>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>> from .../dpdk/drivers/net/ionic/ionic.h:13,
>> from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
>> typedef uint8_t bool;
>> ^~~~~~~
>> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>
>>
>> diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h
>> index ecdbc24e6..6ca5426ec 100644
>> --- a/drivers/net/ionic/ionic_osdep.h
>> +++ b/drivers/net/ionic/ionic_osdep.h
>> @@ -45,7 +45,6 @@ typedef uint32_t __le32;
>> typedef uint64_t __le64;
>>
>> #ifndef __cplusplus
>> -typedef uint8_t bool;
>> #define false 0
>> #define true 1
>
> You could remove the above as well(#define false and #define true)
+1,
I need to do same thing for ionic in other patch to be able to use bool:
https://patches.dpdk.org/patch/66225/
next prev parent reply other threads:[~2020-03-09 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 7:53 [dpdk-stable] " Sunil Kumar Kori
2020-03-09 8:16 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-03-09 8:43 ` Ferruh Yigit [this message]
2020-03-09 9:10 ` [dpdk-stable] [EXT] " Sunil Kumar Kori
2020-03-09 9:09 ` [dpdk-stable] [PATCH v3 " Sunil Kumar Kori
2020-03-10 15:21 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2020-03-10 15:31 ` Alfredo Cardigliano
2020-03-10 17:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa619e5-0b2d-79b5-2eda-4cfec903b35e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).