From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8E24A04B3 for ; Tue, 28 Jan 2020 12:07:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C21051C239; Tue, 28 Jan 2020 12:07:06 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 91EC42629 for ; Mon, 27 Jan 2020 09:30:59 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id t23so5850894wmi.1 for ; Mon, 27 Jan 2020 00:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LNeJp+IaWA8jJ74FsvSzEMm8SepP7dZUuTh7TJl8c5Q=; b=P0GbHZFollSkgeuKmDOUN1p4m6UrScvf4gKUGRf0mWB1gHSPFRdwhdoNT3NI7nsnP7 5OjeZsHNa7KH9shEfF5a62Q7enuCL5YBKhoIX2nu5yVjodyiEokhprIOXRUgTN4y/pyS nsu6M0sR8GnSZdFkyH88oDnIdUsX2YRCOGzu3KZn8xPyztrxhic4Jp5WQ20qLxGxV6pa eqGkR7CMdj+/eLGRtYw28s4aNAe2xl/4m1DnwmkMUQ+dlHiEqBKLiQcX8eMMW0MDQ8ke 3q5Ay8j7KkGG7eErynmpV9B1X4FhP50L+t8bjUkRJVV7z1MFHVNcHMAp3DX8f30wM/+d Kugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=LNeJp+IaWA8jJ74FsvSzEMm8SepP7dZUuTh7TJl8c5Q=; b=UZac47TfOvg3a2Fxcv5pfOmCwyw+juTuy72pPp/QHzcVDtmTOLipydF4OO6bTSaczD 8ZyXhzTEOGqoO6BVjHdc9zLmYGVS/msUbDnLmVqntF/0Tj8Qd1if3amjzzvcQmWukppx CWwpr76UnQEW5n56HiqPjTePXcPZLQHOfenvHDf1mzrzLulTt+Ls3TmjIFkrjeZg+fLd 2ad3OYCq9YPv9F3MB7KqJShJ4tOdyAev5xrEmGSjFBcyC0Oc8PKFwX/FOz9FKGatqwJ5 dTIEwATOyZ/zW0YPDas55fgIhI6r3m/t0+oxZVQlQDpRCBnuRRRFgSrhDi4tsRWwF7+F en+Q== X-Gm-Message-State: APjAAAWjI750aWBq3Thm9gmK6gbTHvFEWGdO8Mm5P+RRguyMs/1/d80v eu2udeh5wfheY5zVmbnNOxFj1Q== X-Google-Smtp-Source: APXvYqxZy3SPGTQrxZ/zcgOYylw3xnfPb5nyoVTLBjg1ZEDlDixPAmzhqxub9KkILlgL01kxi8mDOQ== X-Received: by 2002:a05:600c:141:: with SMTP id w1mr11648542wmm.61.1580113859256; Mon, 27 Jan 2020 00:30:59 -0800 (PST) Received: from [10.0.0.1] (system.cloudius-systems.com. [199.203.229.89]) by smtp.gmail.com with ESMTPSA id z8sm19454236wrq.22.2020.01.27.00.30.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2020 00:30:58 -0800 (PST) To: =?UTF-8?Q?Rafael_=c3=81vila_de_Esp=c3=adndola?= , seastar-dev@googlegroups.com Cc: stable@dpdk.org References: <20200127013307.22633-1-espindola@scylladb.com> From: Avi Kivity Organization: ScyllaDB Message-ID: <5ab62801-ee49-d01c-2835-65b631b726b4@scylladb.com> Date: Mon, 27 Jan 2020 10:30:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200127013307.22633-1-espindola@scylladb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Mailman-Approved-At: Tue, 28 Jan 2020 12:07:05 +0100 Subject: Re: [dpdk-stable] [seastar-dev] [PATCH] mk: avoid combining -r and -export-dynamic linker options X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 27/01/2020 03.33, Rafael Ávila de Espíndola wrote: > Running ld with -r switches the linker to a very special mode where > some other linker options don't make sense. > > In particular, -export-dynamic normally requires that all global > symbols be included in the dynamic symbol table, but a .o file doesn't > even have a dynamic symbol table. > > When given both options it looks like the gnu linker just ignores > -export-dynamic. > > Unfortunately some versions of lld (https://lld.llvm.org/) have a bug > that causes it to try to create a dynamic symbol table in the output > .o file and ends up corrupting it > (https://bugs.llvm.org/show_bug.cgi?id=43552). Current (git) version > of lld now issues an error. > > This patch filters out -export-dynamic from $(LDFLAGS) when using > -r. With this patch I can build dpdk with lld. > > Fixes: 3d781ca32874 ("mk: do post processing on objects that register a driver") > Cc: stable@dpdk.org > > Signed-off-by: Rafael Ávila de Espíndola > (cherry picked from commit 5a352a3a98e3297555cb08d2db6e45a93ce7e058) > --- > Once seastar is updated to use this it should be possible to build > seastar and scylla with lld, which might help with the bots running > out of resources during the link. That turned out to be a configuration problem (docker was limited to a small number of tasks, and multithreaded linking overflowed it). Not to say we shouldn't support lld, of course. > mk/internal/rte.compile-pre.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk > index 0cf3791b4..82fe098f7 100644 > --- a/mk/internal/rte.compile-pre.mk > +++ b/mk/internal/rte.compile-pre.mk > @@ -61,7 +61,7 @@ CHECK_EXPERIMENTAL = $(EXPERIMENTAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@ > > PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -c -o $@.pmd.o $@.pmd.c > -PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > +PMDINFO_LD = $(CROSS)ld -r $(filter-out -export-dynamic,$(LDFLAGS)) -o $@.o $@.pmd.o $@ > PMDINFO_TO_O = if grep -q 'RTE_PMD_REGISTER_.*(.*)' $<; then \ > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > $(PMDINFO_GEN) && \