From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A86A01B44A for ; Mon, 7 Jan 2019 11:23:33 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9D2E81256; Mon, 7 Jan 2019 10:23:32 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B5C95D73F; Mon, 7 Jan 2019 10:23:30 +0000 (UTC) To: Hideyuki Yamashita Cc: Yasufumi Ogawa , Tiwei Bie , dpdk stable References: <20190104132455.15170-1-ktraynor@redhat.com> <20190104132455.15170-64-ktraynor@redhat.com> <201901070006.x0706IxZ018889@ccmail04.silk.ntt-tx.co.jp> From: Kevin Traynor Organization: Red Hat Message-ID: <5b0a23d0-5e58-c77e-507b-4209bef6bb58@redhat.com> Date: Mon, 7 Jan 2019 10:23:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <201901070006.x0706IxZ018889@ccmail04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 07 Jan 2019 10:23:33 +0000 (UTC) Subject: Re: [dpdk-stable] patch 'net/vhost: fix double free of MAC address' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 10:23:34 -0000 On 01/07/2019 12:04 AM, Hideyuki Yamashita wrote: > Hello Kevin, > Hi Hideyuki, > Thanks for your answering me. > > I understand that now my patch is queued to LTS 18.11.1. > > I would like to ask general rules which kind of patch is queued > to LTS and which is not. > (If I CCed stable@dpdk.org when I submmit patch, it is automatically > queued? If that is true then how (or where) can I watch the status > of my patch?) > In short yes with 'Cc: stable@dpdk.org' tag, and a relevant 'Fixes:..' tag. See fuller answer here: http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported Status is through emails like this one, and a summary email before release. e.g for 18.08 https://mails.dpdk.org/archives/stable/2018-December/011828.html Kevin. > The reason why I ask this is that from user perspective > I want as much patches be queued to LTS so that we can > use LTS as stable one. > Yes, I agree :-) > Thanks! > > BR, > Hideyuki Yamashita > NTT TechnoCross > >> Hi, >> >> FYI, your patch has been queued to LTS release 18.11.1 >> >> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. >> It will be pushed if I get no objections before 01/11/19. So please >> shout if anyone has objections. >> >> Also note that after the patch there's a diff of the upstream commit vs the >> patch applied to the branch. This will indicate if there was any rebasing >> needed to apply to the stable branch. If there were code changes for rebasing >> (ie: not only metadata diffs), please double check that the rebase was >> correctly done. >> >> Thanks. >> >> Kevin Traynor >> >> --- >> From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 >> From: Hideyuki Yamashita >> Date: Wed, 19 Dec 2018 13:37:18 +0900 >> Subject: [PATCH] net/vhost: fix double free of MAC address >> >> [ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] >> >> The common data freeing has been moved to rte_eth_dev_release_port(), >> so freeing mac_addrs like this in eth_dev_close() is unnecessary and >> will cause double free. >> >> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") >> >> Signed-off-by: Hideyuki Yamashita >> Signed-off-by: Yasufumi Ogawa >> Reviewed-by: Tiwei Bie >> --- >> drivers/net/vhost/rte_eth_vhost.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c >> index 42bdfcbd5..b2cda0483 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.c >> +++ b/drivers/net/vhost/rte_eth_vhost.c >> @@ -1001,5 +1001,4 @@ eth_dev_close(struct rte_eth_dev *dev) >> rte_free(dev->data->tx_queues[i]); >> >> - rte_free(dev->data->mac_addrs); >> free(internal->dev_name); >> free(internal->iface_name); >> -- >> 2.19.0 >> >> --- >> Diff of the applied patch vs upstream commit (please double-check if non-empty: >> --- >> --- - 2019-01-04 13:23:09.004712018 +0000 >> +++ 0064-net-vhost-fix-double-free-of-MAC-address.patch 2019-01-04 13:23:07.000000000 +0000 >> @@ -1,14 +1,15 @@ >> -From 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 Mon Sep 17 00:00:00 2001 >> +From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 >> From: Hideyuki Yamashita >> Date: Wed, 19 Dec 2018 13:37:18 +0900 >> Subject: [PATCH] net/vhost: fix double free of MAC address >> >> +[ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] >> + >> The common data freeing has been moved to rte_eth_dev_release_port(), >> so freeing mac_addrs like this in eth_dev_close() is unnecessary and >> will cause double free. >> >> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") >> -Cc: stable@dpdk.org >> >> Signed-off-by: Hideyuki Yamashita >> Signed-off-by: Yasufumi Ogawa > >