On 5/17/21 8:21 PM, Christian Ehrhardt wrote: > Hi commit authors (and maintainers), > > I didn't apply following commits from DPDK main to 19.11 > stable branch, as conflicts or build errors occur. > > To authors, could you please check your patches in the following list and either: > - Backport your patches to the 19.11 branch, or > - Indicate that the patch should not be backported > > Please do either of the above by 05/24/21. > ... > 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering for listening socket Hi. I've sent a backport of this patch for 20.11 earlier today: https://inbox.dpdk.org/stable/20210517124500.143341-1-i.maximets@ovn.org/ It can be applied on top of 19.11 branch with 3-way merge, i.e. `git am -3 <patch>` works fine. Will that work for you or should I rebase and send a version for 19.11 specifically? Bets regards, Ilya Maximets.
On Mon, May 17, 2021 at 8:46 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 5/17/21 8:21 PM, Christian Ehrhardt wrote: > > Hi commit authors (and maintainers), > > > > I didn't apply following commits from DPDK main to 19.11 > > stable branch, as conflicts or build errors occur. > > > > To authors, could you please check your patches in the following list and either: > > - Backport your patches to the 19.11 branch, or > > - Indicate that the patch should not be backported > > > > Please do either of the above by 05/24/21. > > > > ... > > > 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering for listening socket > > Hi. I've sent a backport of this patch for 20.11 earlier today: > > https://inbox.dpdk.org/stable/20210517124500.143341-1-i.maximets@ovn.org/ > > It can be applied on top of 19.11 branch with 3-way merge, i.e. > `git am -3 <patch>` works fine. Will that work for you Thanks Ilya, Yeah - I'm not trial&error'ing every 20.11 backport, but I'm totally fine to merge those once pointed to them by the Author. > or should > I rebase and send a version for 19.11 specifically? > > Bets regards, Ilya Maximets. -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd
Hi, Christian, Xueming > 569ffbc981 Viacheslav Ovsiienko common/mlx5: add timestamp format support to DevX > d61381ad46 Viacheslav Ovsiienko net/mlx5: support timestamp format The patches above are not applicable to 19.11-LTS, should be discarded. > da845ae9d7 Viacheslav Ovsiienko net/mlx5: fix drop action for Direct Rules/Verbs This one is backported and sent to ML: http://inbox.dpdk.org/stable/20210519170811.29769-1-viacheslavo@nvidia.com/T/#u With best regards, Slava
On Mon, May 17, 2021 at 8:22 PM Christian Ehrhardt <christian.ehrhardt@canonical.com> wrote: > 3cd7290c16 David Marchand ci: catch coredumps For this one, I don't think Travis and GHA matter in 19.11. I guess what is important to you guys is the part that disables coredump generation in app/test/* This was what bothered Luca first: http://inbox.dpdk.org/dev/20210225194857.1991315-1-luca.boccassi@gmail.com/ If you do have issues in Salsa with 19.11, you can simply take those bits. Else let's just skip this patch for 19.11. -- David Marchand
[-- Attachment #1: Type: text/plain, Size: 7867 bytes --] Hi Christian Ehrhardt, Below is the backporting status of bnxt PMD patches to 19.11.9. e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup [Kalesh] : The patch above is not applicable to 19.11-LTS, should be discarded. 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute 39a03b401e Kalesh AP net/bnxt: fix double free in port start failure 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command response 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not supported 01406837bf Kalesh AP net/bnxt: fix VF info allocation eac4fc71cd Somnath Kotur net/bnxt: fix xstats get [Kalesh] : The above ones are backported and sent to ML. 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status [Kalesh] : Will check with Lance and push later. Regards, Kalesh On Thu, May 20, 2021 at 1:26 PM Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Hi commit authors (and maintainers), > > First of all I have to apoligize, you might think "haven't I seen this > before?". > Yes you have, but the first time due to a script accident and myself not > being > suspicious enough I've sent the mail to a way too big receipient list. > Other than the joy of having to excuse a lot this also meant that quite > some > mail servers seem to have blocked this. > Therefore (and since I touched it anyway looking at 21.05-rc4 today) I > thought > it might be good to send this again. > Finally since I'm out next week anyway I extended the usual deadline a bit > and > hope that will help to backport some of these changes. > > I didn't apply following commits from DPDK main to 19.11 > stable branch, as conflicts or build errors occur. > > Can authors check your patches in the following list and either: > - Backport your patches to the 19.11 branch, or > - Indicate that the patch should not be backported > > Please do either of the above by 05/30/21. > > You can find the a temporary work-in-progress branch 19.11 of the coming > 19.11.9 > release in branch 19.11 at: > https://github.com/cpaelzer/dpdk-stable-queue > It is recommended to backport on top of that to minimize further conflicts > or > misunderstandings. > > Some notes on stable backports: > > A backport should contain a reference to the DPDK main branch commit > in it's commit message in the following fashion: > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] > > For example: > > https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > When sending the backported patch, please indicate the target branch in the > subject line, as we have multiple branches, for example: > [PATCH 19.11.9] foo/bar: fix baz > > With git format-patch, this can be achieved by appending the parameter: > --subject-prefix='PATCH 19.11.9' > > Please send the backported patch to myself and "stable@dpdk.org" but not " > dev@dpdk.org". > > Thanks. > > Christian Ehrhardt <christian.ehrhardt@canonical.com> > > --- > e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup > 144127ba56 Alexander Kozyrev net/mlx5: adjust modify field action > endianness > 0588d64ffd Alexander Kozyrev net/mlx5: check extended metadata for mark > modification > 8660e202b3 Alexander Kozyrev net/mlx5: check field size in modify field > action > 5cc6764267 Alexander Kozyrev net/mlx5: reject tunnel ID modification > 25fb790f78 Chengchang Tang net/hns3: fix HW buffer size on MTU update > 1e28e842e0 Chengchang Tang net/hns3: fix imprecise statistics > 6911e7c22c Chengchang Tang net/hns3: fix long task queue pairs reset time > a1d0caa92c Chengchang Tang net/hns3: fix processing Tx offload flags > d566bfcff0 Chengchang Tang net/hns3: fix timing in mailbox > fde636caf4 Chengchang Tang net/hns3: fix timing in resetting queues > 8f01e2f847 Chengchang Tang net/hns3: fix Tx checksum for UDP packets > with special port > a32eaf435a Chengchang Tang net/hns3: fix use of command status > enumeration > d7ec2c0765 Chengchang Tang net/hns3: select Tx prepare based on Tx > offload > ec2ed976ac Chengwen Feng net/hns3: delete mailbox arq ring > fae9b062b0 Chengwen Feng net/hns3: fix handling link update > 7d6df32cf7 Chengwen Feng net/hns3: fix missing outer L4 UDP flag for > VXLAN > c8dec72de0 Chengwen Feng net/hns3: fix possible mismatched response of > mailbox > 76a3836b98 Chengwen Feng net/hns3: fix setting default MAC address in > bonding of VF > 1f303606e8 Chengwen Feng net/hns3: fix some packet types > 78dbb6f999 Chengwen Feng net/hns3: fix time delta calculation > b80c527a9c Chengwen Feng net/hns3: increase readability in logs > e316530d79 Chengwen Feng net/hns3: remove VLAN/QinQ ptypes from > support list > 3cd7290c16 David Marchand ci: catch coredumps > 3e08081637 David Marchand eal: fix evaluation of log level option > ca7036b4af David Marchand vhost: fix offload flags in Rx path > d345d6c957 Ferruh Yigit drivers/net: fix FW version query > f9f24ecd79 Hongbo Zheng net/hns3: fix concurrent interrupt handling > 230d4940ed Huisong Li net/hns3: fix link speed when port is down > 64308555d5 Huisong Li net/hns3: fix link status when port is stopped > 398ee80192 Huisong Li net/hns3: fix link update when failed to get > link info > 17ff95283f Huisong Li net/hns3: remove redundant mailbox response > 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering for > listening socket > 5aa67931ec John Daley net/enic: fix flow initialization error > handling > 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute > 39a03b401e Kalesh AP net/bnxt: fix double free in port start > failure > 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling > 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command > response > 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor > ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not > supported > 01406837bf Kalesh AP net/bnxt: fix VF info allocation > 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status > af68c1d699 Luc Pelletier eal: fix hang in control thread creation > 34cc55cce6 Luc Pelletier eal: fix race in control thread creation > e6988afdc7 Matan Azrad net/mlx5: fix imissed statistics > 53ef1b3477 Min Hu (Connor) ethdev: add sanity checks in control APIs > 4a072ad434 Murphy Yang net/i40e: fix flow director config after flow > validate > ff04964ea6 Murphy Yang net/i40e: fix flow director for common pctypes > 052a5d3867 Pavan Nikhilesh event/octeontx2: fix XAQ pool reconfigure > 1edf7a796d Pu Xu ip_frag: fix fragmenting IPv4 packet with > header option > 83306d6c46 Shun Hao net/mlx5: fix meter statistics > eac4fc71cd Somnath Kotur net/bnxt: fix xstats get > 16afcbfa30 Tal Shnaiderman eal/windows: fix default thread priority > e412a138db Tengfei Zhang net/pcap: fix file descriptor leak on close > c6d527a1c8 Thomas Monjalon app/testpmd: fix usage text > e0ae50c687 Thomas Monjalon build: remove redundant _GNU_SOURCE > definitions > 204a7f44bc Thomas Monjalon bus/pci: support I/O port operations with musl > e0473c6d5b Thomas Monjalon eal: fix build with musl > 569ffbc981 Viacheslav Ovsiienko common/mlx5: add timestamp format support > to DevX > da845ae9d7 Viacheslav Ovsiienko net/mlx5: fix drop action for Direct > Rules/Verbs > d61381ad46 Viacheslav Ovsiienko net/mlx5: support timestamp format > 687833fffa Wei Huang raw/ifpga/base: check size before assigning > 978bb0b33f Wei Huang raw/ifpga: fix device name format > -- Regards, Kalesh A P
On Thu, May 20, 2021 at 2:33 PM Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com> wrote: > > Hi Christian Ehrhardt, > > Below is the backporting status of bnxt PMD patches to 19.11.9. Thanks a lot! I've got the 8 listed patches plus the cleanup "net/bnxt: fix build failures after merging patches" that you submitted. They are applied and pushed on the WIP 19.11 branch that is available on github. > e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup > [Kalesh] : The patch above is not applicable to 19.11-LTS, should be > discarded. > > 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute > 39a03b401e Kalesh AP net/bnxt: fix double free in port start failure > 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling > 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command > response > 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor > ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not > supported > 01406837bf Kalesh AP net/bnxt: fix VF info allocation > eac4fc71cd Somnath Kotur net/bnxt: fix xstats get > [Kalesh] : The above ones are backported and sent to ML. > > 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status > [Kalesh] : Will check with Lance and push later. > > Regards, > Kalesh > > On Thu, May 20, 2021 at 1:26 PM Christian Ehrhardt < > christian.ehrhardt@canonical.com> wrote: > > > Hi commit authors (and maintainers), > > > > First of all I have to apoligize, you might think "haven't I seen this > > before?". > > Yes you have, but the first time due to a script accident and myself not > > being > > suspicious enough I've sent the mail to a way too big receipient list. > > Other than the joy of having to excuse a lot this also meant that quite > > some > > mail servers seem to have blocked this. > > Therefore (and since I touched it anyway looking at 21.05-rc4 today) I > > thought > > it might be good to send this again. > > Finally since I'm out next week anyway I extended the usual deadline a bit > > and > > hope that will help to backport some of these changes. > > > > I didn't apply following commits from DPDK main to 19.11 > > stable branch, as conflicts or build errors occur. > > > > Can authors check your patches in the following list and either: > > - Backport your patches to the 19.11 branch, or > > - Indicate that the patch should not be backported > > > > Please do either of the above by 05/30/21. > > > > You can find the a temporary work-in-progress branch 19.11 of the coming > > 19.11.9 > > release in branch 19.11 at: > > https://github.com/cpaelzer/dpdk-stable-queue > > It is recommended to backport on top of that to minimize further conflicts > > or > > misunderstandings. > > > > Some notes on stable backports: > > > > A backport should contain a reference to the DPDK main branch commit > > in it's commit message in the following fashion: > > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] > > > > For example: > > > > https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > > > When sending the backported patch, please indicate the target branch in the > > subject line, as we have multiple branches, for example: > > [PATCH 19.11.9] foo/bar: fix baz > > > > With git format-patch, this can be achieved by appending the parameter: > > --subject-prefix='PATCH 19.11.9' > > > > Please send the backported patch to myself and "stable@dpdk.org" but not " > > dev@dpdk.org". > > > > Thanks. > > > > Christian Ehrhardt <christian.ehrhardt@canonical.com> > > > > --- > > e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup > > 144127ba56 Alexander Kozyrev net/mlx5: adjust modify field action > > endianness > > 0588d64ffd Alexander Kozyrev net/mlx5: check extended metadata for mark > > modification > > 8660e202b3 Alexander Kozyrev net/mlx5: check field size in modify field > > action > > 5cc6764267 Alexander Kozyrev net/mlx5: reject tunnel ID modification > > 25fb790f78 Chengchang Tang net/hns3: fix HW buffer size on MTU update > > 1e28e842e0 Chengchang Tang net/hns3: fix imprecise statistics > > 6911e7c22c Chengchang Tang net/hns3: fix long task queue pairs reset time > > a1d0caa92c Chengchang Tang net/hns3: fix processing Tx offload flags > > d566bfcff0 Chengchang Tang net/hns3: fix timing in mailbox > > fde636caf4 Chengchang Tang net/hns3: fix timing in resetting queues > > 8f01e2f847 Chengchang Tang net/hns3: fix Tx checksum for UDP packets > > with special port > > a32eaf435a Chengchang Tang net/hns3: fix use of command status > > enumeration > > d7ec2c0765 Chengchang Tang net/hns3: select Tx prepare based on Tx > > offload > > ec2ed976ac Chengwen Feng net/hns3: delete mailbox arq ring > > fae9b062b0 Chengwen Feng net/hns3: fix handling link update > > 7d6df32cf7 Chengwen Feng net/hns3: fix missing outer L4 UDP flag for > > VXLAN > > c8dec72de0 Chengwen Feng net/hns3: fix possible mismatched response of > > mailbox > > 76a3836b98 Chengwen Feng net/hns3: fix setting default MAC address in > > bonding of VF > > 1f303606e8 Chengwen Feng net/hns3: fix some packet types > > 78dbb6f999 Chengwen Feng net/hns3: fix time delta calculation > > b80c527a9c Chengwen Feng net/hns3: increase readability in logs > > e316530d79 Chengwen Feng net/hns3: remove VLAN/QinQ ptypes from > > support list > > 3cd7290c16 David Marchand ci: catch coredumps > > 3e08081637 David Marchand eal: fix evaluation of log level option > > ca7036b4af David Marchand vhost: fix offload flags in Rx path > > d345d6c957 Ferruh Yigit drivers/net: fix FW version query > > f9f24ecd79 Hongbo Zheng net/hns3: fix concurrent interrupt handling > > 230d4940ed Huisong Li net/hns3: fix link speed when port is down > > 64308555d5 Huisong Li net/hns3: fix link status when port is stopped > > 398ee80192 Huisong Li net/hns3: fix link update when failed to get > > link info > > 17ff95283f Huisong Li net/hns3: remove redundant mailbox response > > 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering for > > listening socket > > 5aa67931ec John Daley net/enic: fix flow initialization error > > handling > > 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute > > 39a03b401e Kalesh AP net/bnxt: fix double free in port start > > failure > > 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling > > 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command > > response > > 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor > > ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not > > supported > > 01406837bf Kalesh AP net/bnxt: fix VF info allocation > > 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status > > af68c1d699 Luc Pelletier eal: fix hang in control thread creation > > 34cc55cce6 Luc Pelletier eal: fix race in control thread creation > > e6988afdc7 Matan Azrad net/mlx5: fix imissed statistics > > 53ef1b3477 Min Hu (Connor) ethdev: add sanity checks in control APIs > > 4a072ad434 Murphy Yang net/i40e: fix flow director config after flow > > validate > > ff04964ea6 Murphy Yang net/i40e: fix flow director for common pctypes > > 052a5d3867 Pavan Nikhilesh event/octeontx2: fix XAQ pool reconfigure > > 1edf7a796d Pu Xu ip_frag: fix fragmenting IPv4 packet with > > header option > > 83306d6c46 Shun Hao net/mlx5: fix meter statistics > > eac4fc71cd Somnath Kotur net/bnxt: fix xstats get > > 16afcbfa30 Tal Shnaiderman eal/windows: fix default thread priority > > e412a138db Tengfei Zhang net/pcap: fix file descriptor leak on close > > c6d527a1c8 Thomas Monjalon app/testpmd: fix usage text > > e0ae50c687 Thomas Monjalon build: remove redundant _GNU_SOURCE > > definitions > > 204a7f44bc Thomas Monjalon bus/pci: support I/O port operations with musl > > e0473c6d5b Thomas Monjalon eal: fix build with musl > > 569ffbc981 Viacheslav Ovsiienko common/mlx5: add timestamp format support > > to DevX > > da845ae9d7 Viacheslav Ovsiienko net/mlx5: fix drop action for Direct > > Rules/Verbs > > d61381ad46 Viacheslav Ovsiienko net/mlx5: support timestamp format > > 687833fffa Wei Huang raw/ifpga/base: check size before assigning > > 978bb0b33f Wei Huang raw/ifpga: fix device name format > > > > > -- > Regards, > Kalesh A P -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd
[-- Attachment #1: Type: text/plain, Size: 9508 bytes --] Thank you Christian Ehrhardt, I backported the remaining one bnxt PMD patch and sent it to the ML. 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status Also, I had sent another backported patch "[dpdk-stable] [PATCH 19.11] net/bnxt: reset filter indices on free" on April 29. Kindly include that to 19.11 LTSas well. Regards, Kalesh On Thu, May 20, 2021 at 7:24 PM Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > On Thu, May 20, 2021 at 2:33 PM Kalesh Anakkur Purayil > <kalesh-anakkur.purayil@broadcom.com> wrote: > > > > Hi Christian Ehrhardt, > > > > Below is the backporting status of bnxt PMD patches to 19.11.9. > > Thanks a lot! > I've got the 8 listed patches plus the cleanup "net/bnxt: fix build > failures after merging patches" that you submitted. > They are applied and pushed on the WIP 19.11 branch that is available on > github. > > > e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup > > [Kalesh] : The patch above is not applicable to 19.11-LTS, should be > > discarded. > > > > 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute > > 39a03b401e Kalesh AP net/bnxt: fix double free in port start > failure > > 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling > > 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command > > response > > 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor > > ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not > > supported > > 01406837bf Kalesh AP net/bnxt: fix VF info allocation > > eac4fc71cd Somnath Kotur net/bnxt: fix xstats get > > [Kalesh] : The above ones are backported and sent to ML. > > > > 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status > > [Kalesh] : Will check with Lance and push later. > > > > Regards, > > Kalesh > > > > On Thu, May 20, 2021 at 1:26 PM Christian Ehrhardt < > > christian.ehrhardt@canonical.com> wrote: > > > > > Hi commit authors (and maintainers), > > > > > > First of all I have to apoligize, you might think "haven't I seen this > > > before?". > > > Yes you have, but the first time due to a script accident and myself > not > > > being > > > suspicious enough I've sent the mail to a way too big receipient list. > > > Other than the joy of having to excuse a lot this also meant that quite > > > some > > > mail servers seem to have blocked this. > > > Therefore (and since I touched it anyway looking at 21.05-rc4 today) I > > > thought > > > it might be good to send this again. > > > Finally since I'm out next week anyway I extended the usual deadline a > bit > > > and > > > hope that will help to backport some of these changes. > > > > > > I didn't apply following commits from DPDK main to 19.11 > > > stable branch, as conflicts or build errors occur. > > > > > > Can authors check your patches in the following list and either: > > > - Backport your patches to the 19.11 branch, or > > > - Indicate that the patch should not be backported > > > > > > Please do either of the above by 05/30/21. > > > > > > You can find the a temporary work-in-progress branch 19.11 of the > coming > > > 19.11.9 > > > release in branch 19.11 at: > > > https://github.com/cpaelzer/dpdk-stable-queue > > > It is recommended to backport on top of that to minimize further > conflicts > > > or > > > misunderstandings. > > > > > > Some notes on stable backports: > > > > > > A backport should contain a reference to the DPDK main branch commit > > > in it's commit message in the following fashion: > > > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] > > > > > > For example: > > > > > > > https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > > > > > When sending the backported patch, please indicate the target branch > in the > > > subject line, as we have multiple branches, for example: > > > [PATCH 19.11.9] foo/bar: fix baz > > > > > > With git format-patch, this can be achieved by appending the parameter: > > > --subject-prefix='PATCH 19.11.9' > > > > > > Please send the backported patch to myself and "stable@dpdk.org" but > not " > > > dev@dpdk.org". > > > > > > Thanks. > > > > > > Christian Ehrhardt <christian.ehrhardt@canonical.com> > > > > > > --- > > > e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup > > > 144127ba56 Alexander Kozyrev net/mlx5: adjust modify field action > > > endianness > > > 0588d64ffd Alexander Kozyrev net/mlx5: check extended metadata for > mark > > > modification > > > 8660e202b3 Alexander Kozyrev net/mlx5: check field size in modify > field > > > action > > > 5cc6764267 Alexander Kozyrev net/mlx5: reject tunnel ID modification > > > 25fb790f78 Chengchang Tang net/hns3: fix HW buffer size on MTU update > > > 1e28e842e0 Chengchang Tang net/hns3: fix imprecise statistics > > > 6911e7c22c Chengchang Tang net/hns3: fix long task queue pairs reset > time > > > a1d0caa92c Chengchang Tang net/hns3: fix processing Tx offload flags > > > d566bfcff0 Chengchang Tang net/hns3: fix timing in mailbox > > > fde636caf4 Chengchang Tang net/hns3: fix timing in resetting queues > > > 8f01e2f847 Chengchang Tang net/hns3: fix Tx checksum for UDP packets > > > with special port > > > a32eaf435a Chengchang Tang net/hns3: fix use of command status > > > enumeration > > > d7ec2c0765 Chengchang Tang net/hns3: select Tx prepare based on Tx > > > offload > > > ec2ed976ac Chengwen Feng net/hns3: delete mailbox arq ring > > > fae9b062b0 Chengwen Feng net/hns3: fix handling link update > > > 7d6df32cf7 Chengwen Feng net/hns3: fix missing outer L4 UDP flag > for > > > VXLAN > > > c8dec72de0 Chengwen Feng net/hns3: fix possible mismatched > response of > > > mailbox > > > 76a3836b98 Chengwen Feng net/hns3: fix setting default MAC address > in > > > bonding of VF > > > 1f303606e8 Chengwen Feng net/hns3: fix some packet types > > > 78dbb6f999 Chengwen Feng net/hns3: fix time delta calculation > > > b80c527a9c Chengwen Feng net/hns3: increase readability in logs > > > e316530d79 Chengwen Feng net/hns3: remove VLAN/QinQ ptypes from > > > support list > > > 3cd7290c16 David Marchand ci: catch coredumps > > > 3e08081637 David Marchand eal: fix evaluation of log level option > > > ca7036b4af David Marchand vhost: fix offload flags in Rx path > > > d345d6c957 Ferruh Yigit drivers/net: fix FW version query > > > f9f24ecd79 Hongbo Zheng net/hns3: fix concurrent interrupt > handling > > > 230d4940ed Huisong Li net/hns3: fix link speed when port is down > > > 64308555d5 Huisong Li net/hns3: fix link status when port is > stopped > > > 398ee80192 Huisong Li net/hns3: fix link update when failed to > get > > > link info > > > 17ff95283f Huisong Li net/hns3: remove redundant mailbox > response > > > 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering > for > > > listening socket > > > 5aa67931ec John Daley net/enic: fix flow initialization error > > > handling > > > 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute > > > 39a03b401e Kalesh AP net/bnxt: fix double free in port start > > > failure > > > 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error > handling > > > 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for > command > > > response > > > 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor > > > ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not > > > supported > > > 01406837bf Kalesh AP net/bnxt: fix VF info allocation > > > 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status > > > af68c1d699 Luc Pelletier eal: fix hang in control thread creation > > > 34cc55cce6 Luc Pelletier eal: fix race in control thread creation > > > e6988afdc7 Matan Azrad net/mlx5: fix imissed statistics > > > 53ef1b3477 Min Hu (Connor) ethdev: add sanity checks in control APIs > > > 4a072ad434 Murphy Yang net/i40e: fix flow director config after > flow > > > validate > > > ff04964ea6 Murphy Yang net/i40e: fix flow director for common > pctypes > > > 052a5d3867 Pavan Nikhilesh event/octeontx2: fix XAQ pool reconfigure > > > 1edf7a796d Pu Xu ip_frag: fix fragmenting IPv4 packet with > > > header option > > > 83306d6c46 Shun Hao net/mlx5: fix meter statistics > > > eac4fc71cd Somnath Kotur net/bnxt: fix xstats get > > > 16afcbfa30 Tal Shnaiderman eal/windows: fix default thread priority > > > e412a138db Tengfei Zhang net/pcap: fix file descriptor leak on > close > > > c6d527a1c8 Thomas Monjalon app/testpmd: fix usage text > > > e0ae50c687 Thomas Monjalon build: remove redundant _GNU_SOURCE > > > definitions > > > 204a7f44bc Thomas Monjalon bus/pci: support I/O port operations with > musl > > > e0473c6d5b Thomas Monjalon eal: fix build with musl > > > 569ffbc981 Viacheslav Ovsiienko common/mlx5: add timestamp format > support > > > to DevX > > > da845ae9d7 Viacheslav Ovsiienko net/mlx5: fix drop action for Direct > > > Rules/Verbs > > > d61381ad46 Viacheslav Ovsiienko net/mlx5: support timestamp format > > > 687833fffa Wei Huang raw/ifpga/base: check size before > assigning > > > 978bb0b33f Wei Huang raw/ifpga: fix device name format > > > > > > > > > -- > > Regards, > > Kalesh A P > > > > -- > Christian Ehrhardt > Staff Engineer, Ubuntu Server > Canonical Ltd > -- Regards, Kalesh A P
Hi Christian, Below patch should not be backported 687833fffa Wei Huang raw/ifpga/base: check size before assigning So the patch can be backported to 19.11 is 978bb0b33f Wei Huang raw/ifpga: fix device name format Thanks, Wei -----Original Message----- From: Christian Ehrhardt <christian.ehrhardt@canonical.com> Sent: Thursday, May 20, 2021 15:56 Cc: Aaron Conole <aconole@redhat.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>; Alexander Kozyrev <akozyrev@nvidia.com>; Anand Rawat <anand.rawat@intel.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Andrew Rybchenko <arybchenko@solarflare.com>; Andy Gospodarek <gospo@broadcom.com>; Xing, Beilei <beilei.xing@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Bing Zhao <bingz@nvidia.com>; Richardson, Bruce <bruce.richardson@intel.com>; Chengchang Tang <tangchengchang@huawei.com>; Chengwen Feng <fengchengwen@huawei.com>; David Marchand <david.marchand@redhat.com>; Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Hongbo Zheng <zhenghongbo3@huawei.com>; Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Huisong Li <lihuisong@huawei.com>; Hyong Youb Kim <hyonkim@cisco.com>; Igor Russkikh <igor.russkikh@aquantia.com>; Ilya Maximets <i.maximets@ovn.org>; Jakub Grajciar <jgrajcia@cisco.com>; Jens Freimann <jfreimann@redhat.com>; Jerin Jacob <jerinj@marvell.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Wu, Jingjing <jingjing.wu@intel.com>; Daley, John <johndale@cisco.com>; Mcnamara, John <john.mcnamara@intel.com>; Kalesh AP <kalesh-anakkur.purayil@broadcom.com>; Laatz, Kevin <kevin.laatz@intel.com>; Kevin Traynor <ktraynor@redhat.com>; Kiran Kumar K <kirankumark@marvell.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Lance Richardson <lance.richardson@broadcom.com>; Lijun Ou <oulijun@huawei.com>; Luca Boccassi <bluca@debian.org>; Luc Pelletier <lucp.at.work@gmail.com>; Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>; Kovacevic, Marko <marko.kovacevic@intel.com>; Matan Azrad <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Michael Santana <maicolgabriel@hotmail.com>; Min Hu (Connor) <humin29@huawei.com>; Yang, MurphyX <murphyx.yang@intel.com>; Natanael Copa <ncopa@alpinelinux.org>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Odi Assli <odia@nvidia.com>; Olivier Matz <olivier.matz@6wind.com>; Omar Cardona <ocardona@microsoft.com>; Ori Kam <orika@nvidia.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Pavel Belous <pavel.belous@aquantia.com>; Pu Xu <583493798@qq.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Rasesh Mody <rmody@marvell.com>; Ravi Kumar <ravi1.kumar@amd.com>; Xu, Rosen <rosen.xu@intel.com>; Sachin Saxena <sachin.saxena@nxp.com>; Shahaf Shuler <shahafs@nvidia.com>; Shahed Shaikh <shshaikh@marvell.com>; Shun Hao <shunh@nvidia.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Tal Shnaiderman <talshn@nvidia.com>; Tengfei Zhang <zypscode@outlook.com>; Thomas Monjalon <thomas@monjalon.net>; Zhang, Tianfei <tianfei.zhang@intel.com>; Tiwei Bie <tiwei.bie@intel.com>; Vamsi Attunuru <vattunuru@marvell.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Huang, Wei <wei.huang@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Zhihong Wang <zhihong.wang@intel.com> Subject: please help backporting some patches to stable release 19.11.9 Hi commit authors (and maintainers), First of all I have to apoligize, you might think "haven't I seen this before?". Yes you have, but the first time due to a script accident and myself not being suspicious enough I've sent the mail to a way too big receipient list. Other than the joy of having to excuse a lot this also meant that quite some mail servers seem to have blocked this. Therefore (and since I touched it anyway looking at 21.05-rc4 today) I thought it might be good to send this again. Finally since I'm out next week anyway I extended the usual deadline a bit and hope that will help to backport some of these changes. I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur. Can authors check your patches in the following list and either: - Backport your patches to the 19.11 branch, or - Indicate that the patch should not be backported Please do either of the above by 05/30/21. You can find the a temporary work-in-progress branch 19.11 of the coming 19.11.9 release in branch 19.11 at: https://github.com/cpaelzer/dpdk-stable-queue It is recommended to backport on top of that to minimize further conflicts or misunderstandings. Some notes on stable backports: A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion: [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] For example: https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example: [PATCH 19.11.9] foo/bar: fix baz With git format-patch, this can be achieved by appending the parameter: --subject-prefix='PATCH 19.11.9' Please send the backported patch to myself and "stable@dpdk.org" but not "dev@dpdk.org". Thanks. Christian Ehrhardt <christian.ehrhardt@canonical.com> --- e2895305a5 Ajit Khaparde net/bnxt: fix resource cleanup 144127ba56 Alexander Kozyrev net/mlx5: adjust modify field action endianness 0588d64ffd Alexander Kozyrev net/mlx5: check extended metadata for mark modification 8660e202b3 Alexander Kozyrev net/mlx5: check field size in modify field action 5cc6764267 Alexander Kozyrev net/mlx5: reject tunnel ID modification 25fb790f78 Chengchang Tang net/hns3: fix HW buffer size on MTU update 1e28e842e0 Chengchang Tang net/hns3: fix imprecise statistics 6911e7c22c Chengchang Tang net/hns3: fix long task queue pairs reset time a1d0caa92c Chengchang Tang net/hns3: fix processing Tx offload flags d566bfcff0 Chengchang Tang net/hns3: fix timing in mailbox fde636caf4 Chengchang Tang net/hns3: fix timing in resetting queues 8f01e2f847 Chengchang Tang net/hns3: fix Tx checksum for UDP packets with special port a32eaf435a Chengchang Tang net/hns3: fix use of command status enumeration d7ec2c0765 Chengchang Tang net/hns3: select Tx prepare based on Tx offload ec2ed976ac Chengwen Feng net/hns3: delete mailbox arq ring fae9b062b0 Chengwen Feng net/hns3: fix handling link update 7d6df32cf7 Chengwen Feng net/hns3: fix missing outer L4 UDP flag for VXLAN c8dec72de0 Chengwen Feng net/hns3: fix possible mismatched response of mailbox 76a3836b98 Chengwen Feng net/hns3: fix setting default MAC address in bonding of VF 1f303606e8 Chengwen Feng net/hns3: fix some packet types 78dbb6f999 Chengwen Feng net/hns3: fix time delta calculation b80c527a9c Chengwen Feng net/hns3: increase readability in logs e316530d79 Chengwen Feng net/hns3: remove VLAN/QinQ ptypes from support list 3cd7290c16 David Marchand ci: catch coredumps 3e08081637 David Marchand eal: fix evaluation of log level option ca7036b4af David Marchand vhost: fix offload flags in Rx path d345d6c957 Ferruh Yigit drivers/net: fix FW version query f9f24ecd79 Hongbo Zheng net/hns3: fix concurrent interrupt handling 230d4940ed Huisong Li net/hns3: fix link speed when port is down 64308555d5 Huisong Li net/hns3: fix link status when port is stopped 398ee80192 Huisong Li net/hns3: fix link update when failed to get link info 17ff95283f Huisong Li net/hns3: remove redundant mailbox response 23abee9dea Ilya Maximets net/virtio: fix interrupt unregistering for listening socket 5aa67931ec John Daley net/enic: fix flow initialization error handling 4f28d9a1a6 Kalesh AP net/bnxt: drop unused attribute 39a03b401e Kalesh AP net/bnxt: fix double free in port start failure 94131e4ab7 Kalesh AP net/bnxt: fix firmware fatal error handling 4f1d8fdc3f Kalesh AP net/bnxt: fix memory allocation for command response 53f98141ee Kalesh AP net/bnxt: fix PTP support for Thor ab15dd5a1c Kalesh AP net/bnxt: fix timesync when PTP is not supported 01406837bf Kalesh AP net/bnxt: fix VF info allocation 25fefa2b17 Lance Richardson net/bnxt: fix Rx descriptor status af68c1d699 Luc Pelletier eal: fix hang in control thread creation 34cc55cce6 Luc Pelletier eal: fix race in control thread creation e6988afdc7 Matan Azrad net/mlx5: fix imissed statistics 53ef1b3477 Min Hu (Connor) ethdev: add sanity checks in control APIs 4a072ad434 Murphy Yang net/i40e: fix flow director config after flow validate ff04964ea6 Murphy Yang net/i40e: fix flow director for common pctypes 052a5d3867 Pavan Nikhilesh event/octeontx2: fix XAQ pool reconfigure 1edf7a796d Pu Xu ip_frag: fix fragmenting IPv4 packet with header option 83306d6c46 Shun Hao net/mlx5: fix meter statistics eac4fc71cd Somnath Kotur net/bnxt: fix xstats get 16afcbfa30 Tal Shnaiderman eal/windows: fix default thread priority e412a138db Tengfei Zhang net/pcap: fix file descriptor leak on close c6d527a1c8 Thomas Monjalon app/testpmd: fix usage text e0ae50c687 Thomas Monjalon build: remove redundant _GNU_SOURCE definitions 204a7f44bc Thomas Monjalon bus/pci: support I/O port operations with musl e0473c6d5b Thomas Monjalon eal: fix build with musl 569ffbc981 Viacheslav Ovsiienko common/mlx5: add timestamp format support to DevX da845ae9d7 Viacheslav Ovsiienko net/mlx5: fix drop action for Direct Rules/Verbs d61381ad46 Viacheslav Ovsiienko net/mlx5: support timestamp format 687833fffa Wei Huang raw/ifpga/base: check size before assigning 978bb0b33f Wei Huang raw/ifpga: fix device name format
On Thu, May 20, 2021 at 11:17 AM David Marchand <david.marchand@redhat.com> wrote: > > On Mon, May 17, 2021 at 8:22 PM Christian Ehrhardt > <christian.ehrhardt@canonical.com> wrote: > > 3cd7290c16 David Marchand ci: catch coredumps > > For this one, I don't think Travis and GHA matter in 19.11. > > I guess what is important to you guys is the part that disables > coredump generation in app/test/* > This was what bothered Luca first: > http://inbox.dpdk.org/dev/20210225194857.1991315-1-luca.boccassi@gmail.com/ > > If you do have issues in Salsa with 19.11, you can simply take those bits. > Else let's just skip this patch for 19.11. Agreed, thanks for your feedback > -- > David Marchand > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd