From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id B2909A0679
	for <public@inbox.dpdk.org>; Tue, 30 Apr 2019 18:53:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 852B458FA;
	Tue, 30 Apr 2019 18:53:27 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id B376558FA
 for <stable@dpdk.org>; Tue, 30 Apr 2019 18:53:25 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 187D9308330B;
 Tue, 30 Apr 2019 16:53:25 +0000 (UTC)
Received: from [10.36.117.211] (ovpn-117-211.ams2.redhat.com [10.36.117.211])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 6D2BC379C;
 Tue, 30 Apr 2019 16:53:24 +0000 (UTC)
To: Anatoly Burakov <anatoly.burakov@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
References: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <5d70936a-7be7-039e-7d73-2d417be67d17@redhat.com>
Date: Tue, 30 Apr 2019 17:53:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.44]); Tue, 30 Apr 2019 16:53:25 +0000 (UTC)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 18.11] eal: fix cleanup in
	no-shconf mode
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On 24/04/2019 16:26, Anatoly Burakov wrote:
> In no-shconf mode, there is no need to clean runtime directory
> because it's not created in the first place.
> 
> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 30138b638..59497d04a 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>  	 * whether we are primary or secondary process, but we cannot remove
>  	 * primary process' files because secondary should be able to run even
>  	 * if primary process is dead.
> +	 *
> +	 * In no_shconf mode, no runtime directory is created in the first
> +	 * place, so no cleanup needed.
>  	 */
> -	if (eal_clean_runtime_dir() < 0) {
> +	if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>  		rte_eal_init_alert("Cannot clear runtime directory\n");
>  		return -1;
>  	}
> 

Thanks Anatoly. Added reference to master commit in msg and pushed into
the queue.