From: Timothy Redaelli <tredaelli@redhat.com>
To: stable@dpdk.org
Cc: dev@dpdk.org, david.marchand@redhat.com, cristian.dumitrescu@intel.com
Subject: [dpdk-stable] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10
Date: Wed, 5 Feb 2020 15:12:20 +0100 [thread overview]
Message-ID: <5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com> (raw)
In-Reply-To: <cover.1580910264.git.tredaelli@redhat.com>
GCC 10 defaults to -fno-common, this means a linker error will now be
reported if the same global variable is defined in more than one
compilation unit.
Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
Cc: cristian.dumitrescu@intel.com
Cc: stable@dpdk.org
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
v2:
app is already declared as extern in main.h. (as reported by David)
---
app/test-pipeline/config.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c
index 28ac9fcc0..33f3f1c82 100644
--- a/app/test-pipeline/config.c
+++ b/app/test-pipeline/config.c
@@ -42,8 +42,6 @@
#include "main.h"
-struct app_params app;
-
static const char usage[] = "\n";
void
--
2.24.1
next prev parent reply other threads:[~2020-02-05 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 13:47 [dpdk-stable] [PATCH 0/3] examples: " Timothy Redaelli
2020-02-05 13:47 ` [dpdk-stable] [PATCH 1/3] examples/vhost_blk: " Timothy Redaelli
2020-02-05 15:12 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2020-02-05 14:12 ` Timothy Redaelli [this message]
2020-02-05 14:21 ` [dpdk-stable] [PATCH v2 3/3] app/test-pipeline: " Dumitrescu, Cristian
2020-02-05 17:05 ` [dpdk-stable] [PATCH 2/3] examples/eventdev_pipeline: " Timothy Redaelli
2020-02-05 17:05 ` [dpdk-stable] [PATCH 3/3] examples/qos_sched: " Timothy Redaelli
2020-03-04 9:37 ` [dpdk-stable] [dpdk-dev] [PATCH 0/3] examples: " David Marchand
2020-03-04 10:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com \
--to=tredaelli@redhat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).