* [dpdk-stable] [PATCH] net/failsafe: fix RSS hash offload reporting
@ 2020-12-22 8:00 Andrew Rybchenko
2021-02-19 8:49 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2020-12-22 8:00 UTC (permalink / raw)
To: dev; +Cc: stable, Gaetan Rivet, Pavan Nikhilesh, Andrew Rybchenko, Ferruh Yigit
If sub-devices support RSS hash offload, the offload should be
reported by the failsafe device since handling is transparent
from failsafe point of view.
Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/failsafe/failsafe_ops.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
index 492047f587..9946b696f3 100644
--- a/drivers/net/failsafe/failsafe_ops.c
+++ b/drivers/net/failsafe/failsafe_ops.c
@@ -1192,7 +1192,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_SCATTER |
DEV_RX_OFFLOAD_TIMESTAMP |
- DEV_RX_OFFLOAD_SECURITY;
+ DEV_RX_OFFLOAD_SECURITY |
+ DEV_RX_OFFLOAD_RSS_HASH;
infos->rx_queue_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
@@ -1209,7 +1210,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_SCATTER |
DEV_RX_OFFLOAD_TIMESTAMP |
- DEV_RX_OFFLOAD_SECURITY;
+ DEV_RX_OFFLOAD_SECURITY |
+ DEV_RX_OFFLOAD_RSS_HASH;
infos->tx_offload_capa =
DEV_TX_OFFLOAD_MULTI_SEGS |
--
2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting
2020-12-22 8:00 [dpdk-stable] [PATCH] net/failsafe: fix RSS hash offload reporting Andrew Rybchenko
@ 2021-02-19 8:49 ` Ferruh Yigit
2021-02-22 15:25 ` Gaëtan Rivet
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2021-02-19 8:49 UTC (permalink / raw)
To: Andrew Rybchenko, dev
Cc: stable, Gaetan Rivet, Pavan Nikhilesh, Andrew Rybchenko
On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
> If sub-devices support RSS hash offload, the offload should be
> reported by the failsafe device since handling is transparent
> from failsafe point of view.
>
> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
It looks reasonable, but would be good to get ack from maintainer.
Gaetan, can you please look at this?
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting
2021-02-19 8:49 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
@ 2021-02-22 15:25 ` Gaëtan Rivet
2021-02-22 16:31 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Gaëtan Rivet @ 2021-02-22 15:25 UTC (permalink / raw)
To: Ferruh Yigit, Andrew Rybchenko, dev
Cc: stable, Pavan Nikhilesh, Andrew Rybchenko
On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote:
> On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
> > If sub-devices support RSS hash offload, the offload should be
> > reported by the failsafe device since handling is transparent
> > from failsafe point of view.
> >
> > Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> It looks reasonable, but would be good to get ack from maintainer.
>
> Gaetan, can you please look at this?
>
> Thanks.
>
Hi Ferruh,
Indeed, sorry Andrew about the delay.
I agree that this looks reasonable,
Acked-by: Gaetan Rivet <grive@u256.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting
2021-02-22 15:25 ` Gaëtan Rivet
@ 2021-02-22 16:31 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2021-02-22 16:31 UTC (permalink / raw)
To: Gaëtan Rivet, Andrew Rybchenko, dev
Cc: stable, Pavan Nikhilesh, Andrew Rybchenko
On 2/22/2021 3:25 PM, Gaëtan Rivet wrote:
> On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote:
>> On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
>>> If sub-devices support RSS hash offload, the offload should be
>>> reported by the failsafe device since handling is transparent
>>> from failsafe point of view.
>>>
>>> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> Acked-by: Gaetan Rivet <grive@u256.net>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 16:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-22 8:00 [dpdk-stable] [PATCH] net/failsafe: fix RSS hash offload reporting Andrew Rybchenko
2021-02-19 8:49 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-02-22 15:25 ` Gaëtan Rivet
2021-02-22 16:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).