From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A0BA09EA for ; Wed, 9 Dec 2020 10:31:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6415FBE75; Wed, 9 Dec 2020 10:31:04 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 96191BE75 for ; Wed, 9 Dec 2020 10:31:02 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id y17so934802wrr.10 for ; Wed, 09 Dec 2020 01:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=XxXjpPBGZd8B4p/pBBggOGYo1FTq8gHFPN3D5hO/wp0=; b=NwOxT7QoN0vO3sE0crfK4o67Wbvm1lDQa94LduYwFVW+WclH53G8MDYsf6I51RkA3+ +Eo+gmluqTBkFlGketxT8iGT2ydurVWnGN8+92pqN0299Uatp/10vU0sMdx86Ohy5YRm J6NzJ7NkD8ecKJIzzMPgVh5CCQLLvo/cG4X/GmKYgsGCK5W6l8MafXVbBmmgR1Botsvh jHH3c/cVqMw4/C/luFsnGVdeEHrsH157qBZgrFEGpP6R2t2DHb03R8NG5QDnSK6NSph/ HggadDAHDcLxhoHrjbb8p/sN6S9ySy9CvOjF88c3eX57ucYVjldC2oBHNAnHatbgIEW1 K4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XxXjpPBGZd8B4p/pBBggOGYo1FTq8gHFPN3D5hO/wp0=; b=GONJbS+fbcbr/m53+aIAwUGA8VQfsm5RY76XprmKsRINnfxZ/1dSC5lPcWS/ItZCZB ZBbqmf/yLKY9fV2bosbIwyT2q4nNoC6VJKnU9n0RyCa48tgBi3l9Fgd55RD0mI/bFmQP V0NfqrQGQFLIIeyqiJcHjY1FBqDRRmRKnYzwWwvYagaFpT2ahPrYxCcCkohUuVAAExyb OerPEBrOe06y4I9S5sNVEqEd7jQl5SiDdN7eZTsuUfZwlQldRoi17e1B41g5Q1TiS8WE O8k9u+UeRnhIIWcp12t7JeEbvADuZVFniBfZKeokbqQJmJd/7DyHsLBZ2E9sClC7lyFm P6XQ== X-Gm-Message-State: AOAM5324fE67TLSqq4AlCuTbQE880bZuiPaJhWVrdzNGTB/TR/Zr15yb XW9B5VtXChsyHsjkUwfQxqcDourKmrg7bMjG X-Google-Smtp-Source: ABdhPJwWHq16QFZJOpVpy6Rhm1lpVZ9ULwOxm2BzKDbYJ0xqejhVR8AlHYf1zg1lsiQLgyx6cosaKQ== X-Received: by 2002:adf:db8e:: with SMTP id u14mr1582889wri.233.1607506260929; Wed, 09 Dec 2020 01:31:00 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id r13sm2154388wrm.25.2020.12.09.01.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Dec 2020 01:31:00 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , David Marchand , Dmitry Kozlyuk , pallavi.kadam@intel.com, stable@dpdk.org References: <20201127113623.26707-1-nick.connolly@mayadata.io> <20201129160024.879-1-nick.connolly@mayadata.io> <20201203030215.0e7c6fce@sovereign> <6379652.DfeunkggAM@thomas> Message-ID: <607f92b6-18dd-c240-75bc-691b7851f50d@mayadata.io> Date: Wed, 9 Dec 2020 09:30:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <6379652.DfeunkggAM@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] windows: build warnings with clang X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Copying stable@dpdk.org - given that 20.11 has now been released I assume this needs to be applied there as well. On 07/12/2020 20:34, Thomas Monjalon wrote: > 03/12/2020 01:02, Dmitry Kozlyuk: >> On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote: >>> Microsoft CRT defines Windows-specific secure alternatives to >>> standard library functions and triggers warnings when "insecure" >>> functions are used [1]. However, calling code already has all >>> necessary checks around those functions, so these warnings are not >>> useful for DPDK. MinGW provides its own CRT without this issue. >>> >>> [1]: >>> https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160 >>> >>> Disable this by defining -D_CRT_SECURE_NO_WARNINGS. >>> >>> Signed-off-by: Nick Connolly >>> --- >>> v2: >>> * Adjust commit wording as per Dmitry Kozlyuk >>> >>> Note: It is unclear exactly which commit this fixes. It is probably a >>> consequence of building more libraries for Windows. >> Acked-by: Dmitry Kozlyuk > Applied, thanks > >