From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 4D53629AC; Thu, 17 Jan 2019 23:08:11 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 26D3E1442; Thu, 17 Jan 2019 17:08:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 17:08:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=k9u57zSzC7cPN8Gzv1h2/GVJpLk3iMhV5fqbG/WKvE4=; b=gyIj5BVUs94y VNU8cg4YEYnivK68DOd7XdFxMZ6oIrmHVAPZhdxv5+MgUa8/bVSukJvmdlAzaBBF YYAUkmQHkS80j0C7DZbntobHLygfwyQBDfmJoGpOSNLU0GP1jXwJw7RZ0U3o21EN BKYsVYC2GrS3uUKk5tcb2vLbY4RAqVU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=k9u57zSzC7cPN8Gzv1h2/GVJpLk3iMhV5fqbG/WKv E4=; b=SnPm7febxGrk51k09UbiiQs5tWGbU1OW50XCsvNeyv/Sj4oev1icqixMK dKNKeFlPezySqHXgERu3ssvQhAwSm+AWuPSC1yP8IQMDMW4/oVdvmAcHRGH56RIY uFZCw2Nq+bipAm4AsK40a57gaGA8/LBRkFh3ZixtjPEe4NG4iZhMuJvQuypZpE0c 4uqv0yBkIrYV9lEwh3IMJedhpGIsctINcJSBru7hQ6nOoQKGQjnbB8ZR/Awz4a3n Wa1Hj8gkXQB1gal3orxpXzmlXxszTKIs4f5wOmJA6RSKJboMQoG0Z83v7u+yFY81 RVSAxWZNR7hv0XGtMW5bm/E8eCOEg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A3F47100E4; Thu, 17 Jan 2019 17:08:08 -0500 (EST) From: Thomas Monjalon To: "Hu, Jiayu" Cc: stable@dpdk.org, "Kovacevic, Marko" , "dev@dpdk.org" , "Ananyev, Konstantin" Date: Thu, 17 Jan 2019 23:08:07 +0100 Message-ID: <6102338.UvBRKH1dAI@xps> In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F660207DB1F@IRSMSX104.ger.corp.intel.com> References: <1547021995-14231-1-git-send-email-jiayu.hu@intel.com> <1547604822-9920-1-git-send-email-jiayu.hu@intel.com> <6DC05C7C5F25994B81B3F2F214251F660207DB1F@IRSMSX104.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 22:08:11 -0000 17/01/2019 14:55, Kovacevic, Marko: > > +GRO Library Limitations > > +----------------------- > > + > > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ > > + outer_l3_len/packet_type to get protocol headers for the > > + input packet, rather than parsing the packet header. Therefore, > > + before call GRO APIs to merge packets, user applications > > + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len/ > > + packet_type to the same values as the protocol headers of the > > + packet. > > + > > +- GRO library doesn't support to process the packets with IPv4 > > + Options or VLAN tagged. > > + > > +- GRO library just supports to process the packet organized > > + in a single MBUF. If the input packet consists of multiple > > + MBUFs (i.e. chained MBUFs), GRO reassembly behaviors are > > + unknown. > > -- > > Would it be better said like this ?? > > - GRO library uses different MBUF->packet_types for example > ``l2_len, l3_len, l4_len, outer_l2_len, outer_l3_len`` to get protocol > headers for the input packet, rather than parsing the packet header. > Therefore, before calling GRO APIs to merge packets, user applications > must set MBUF->packet_type to the same values as the protocol headers of > the packet. packet_type is really a field in mbuf. I think the wording from Jiayu is more correct.