From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2F3CA04B1 for ; Tue, 24 Nov 2020 10:38:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6933EC90C; Tue, 24 Nov 2020 10:38:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 90DD1C90C for ; Tue, 24 Nov 2020 10:38:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606210731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w7FF6HRlVcp/kMCRrdDhEMytDQTXiJylcl2XZzgc0Ss=; b=Zl5FONyY95EWXvM2Drmw5hr7x5vwwYiTV9Pa84KjhBQ0mzbm0WSyaZIxLI1ksE10REoG7H 3dTuZ5tQKMe2NmpRn6YwohrFnX8LesPYCzjXepysQU9CESvRBCXJoXr6S+B+Fu8EM6mgw9 L8m2NDQ21xgaj+Ihgck22Y/7xpb+r0M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-suAMNKG4OUaGOP3KyGxLNQ-1; Tue, 24 Nov 2020 04:38:49 -0500 X-MC-Unique: suAMNKG4OUaGOP3KyGxLNQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 972DD835B7B; Tue, 24 Nov 2020 09:38:47 +0000 (UTC) Received: from [10.36.112.19] (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CD5160C13; Tue, 24 Nov 2020 09:38:42 +0000 (UTC) To: David Marchand Cc: Ferruh Yigit , Qi Zhang , Andrew Rybchenko , Igor Romanov , dpdk stable References: <20201123171222.79398-1-ktraynor@redhat.com> <20201123171222.79398-17-ktraynor@redhat.com> From: Kevin Traynor Message-ID: <62a4461d-ae35-59b2-c289-518e7d9d91c9@redhat.com> Date: Tue, 24 Nov 2020 09:38:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] patch 'app/testpmd: fix MTU after device configure' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 23/11/2020 18:35, David Marchand wrote: > On Mon, Nov 23, 2020 at 6:13 PM Kevin Traynor wrote: >> From 922feed76bd5d8fe06b95a56afabd3a95987b047 Mon Sep 17 00:00:00 2001 >> From: Ferruh Yigit >> Date: Fri, 13 Nov 2020 11:44:00 +0000 >> Subject: [PATCH] app/testpmd: fix MTU after device configure >> >> [ upstream commit 1c21ee95cf5298fe7b6a8b7d8a997ff3c402a08f ] >> >> In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set >> the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). >> This is mistake because for the PMDs that has frame size bigger than >> "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes >> less than 1500, causing a valid frame with 1500 bytes payload to be >> dropped. >> >> Since 'rte_eth_dev_set_mtu()' works as expected, it is called after >> 'rte_eth_dev_configure()' to fix the MTU. >> It may look redundant to set MTU after 'rte_eth_dev_configure()', both >> with default values, but it is not, the resulting MTU config can be >> different in the device based on frame overhead of the PMD. >> >> And instead of setting the MTU to default value, it is first get via >> 'rte_eth_dev_get_mtu()' and set again, this is to cover cases MTU >> changed from testpmd command line. >> >> 'rte_eth_dev_set_mtu()', '-ENOTSUP' error is ignored to prevent >> irrelevant warning messages for the virtual PMDs. >> >> Fixes: af75078fece3 ("first public release") >> >> Signed-off-by: Ferruh Yigit >> Reviewed-by: Qi Zhang >> Acked-by: Andrew Rybchenko >> Tested-by: Igor Romanov > > Hey Kevin, > > This patch has been reverted in rc5. > > Thanks David. I dropped this patch and the later revert from 18.11 queue.