patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] app/testpmd: remove port stop check for macsec
@ 2019-05-09  7:20 Wei Zhao
  2019-05-10  8:41 ` [dpdk-stable] [PATCH v2] " Wei Zhao
  0 siblings, 1 reply; 9+ messages in thread
From: Wei Zhao @ 2019-05-09  7:20 UTC (permalink / raw)
  To: dev; +Cc: stable, yuan.peng, ferruh.yigit, wenzhuo.lu, Wei Zhao

There is no need to do such a check when set macsec for ixgbe,
reconfig_device_queueand is also useless. If ew do not delete this
unnessarycode, users have to sotp port before enable macsec, then
restart this port after make configuration. All these process is
useless. As this cmdline is a private API only use by ixgbe NIC,
so remove it.

Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 app/test-pmd/cmdline.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c1042dd..b969745 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(
 
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
 		return;
-	if (!port_is_stopped(port_id)) {
-		printf("Please stop port %d first\n", port_id);
-		return;
-	}
 
 	rte_eth_dev_info_get(port_id, &dev_info);
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {
@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(
 	case 0:
 		ports[port_id].dev_conf.txmode.offloads |=
 						DEV_TX_OFFLOAD_MACSEC_INSERT;
-		cmd_reconfig_device_queue(port_id, 1, 1);
 		break;
 	case -ENODEV:
 		printf("invalid port_id %d\n", port_id);
-- 
2.7.5


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-07-01 16:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09  7:20 [dpdk-stable] [PATCH] app/testpmd: remove port stop check for macsec Wei Zhao
2019-05-10  8:41 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2019-05-13  3:30   ` Zhao1, Wei
2019-06-07 13:59     ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2019-06-10  6:40       ` Zhao1, Wei
2019-06-10  6:07   ` [dpdk-stable] [PATCH v3] " Wei Zhao
2019-06-27 17:23     ` Ferruh Yigit
2019-06-30 21:50       ` Thomas Monjalon
2019-07-01 16:39         ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).