patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Andrew Boyer <aboyer@pensando.io>
To: David Marchand <david.marchand@redhat.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] eal: don't log uninitialized string
Date: Tue, 9 Feb 2021 09:35:12 -0500
Message-ID: <631D0A59-4851-4D4B-8131-FC9DB1D99334@pensando.io> (raw)
In-Reply-To: <CAJFAV8wjYDivzMY=VcCb8f1LGd1X7FXfeKpWjZ9xbt_b_RHkVg@mail.gmail.com>


> On Jan 6, 2021, at 4:35 AM, David Marchand <david.marchand@redhat.com> wrote:
> 
> On Fri, Dec 11, 2020 at 6:07 PM Andrew Boyer <aboyer@pensando.io <mailto:aboyer@pensando.io>> wrote:
>> 
>> Our Coverity scan pointed out that path[] is never initialized.
>> The official DPDK Coverity has not reported this so there is
>> no public CID for it.
>> 
>> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
>> Cc: anatoly.burakov@intel.com
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>> ---
>> lib/librte_eal/common/eal_common_fbarray.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
>> index 1220e2bae..6ce89af83 100644
>> --- a/lib/librte_eal/common/eal_common_fbarray.c
>> +++ b/lib/librte_eal/common/eal_common_fbarray.c
>> @@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len)
>> static int
>> resize_and_map(int fd, void *addr, size_t len)
>> {
>> -       char path[PATH_MAX];
>>        void *map_addr;
>> 
>>        if (eal_file_truncate(fd, len)) {
>> -               RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path);
>> +               RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd);
> 
> Logging a fd number won't help much, but I guess this was not really
> helpful with path[] either :-).
> If we keep this log, I would move it to the callers of the functions,
> where the filename is available.
> 
> 
> -- 
> David Marchand

Can this be taken for 21.02? I realize the log isn’t that useful, but it doesn’t seem worth it (to me at least) to do much more work on it.

-Andrew

      reply	other threads:[~2021-02-09 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 17:06 Andrew Boyer
2020-12-14 23:23 ` [dpdk-stable] [dpdk-dev] " Mcnamara, John
2021-01-06  9:35 ` [dpdk-stable] " David Marchand
2021-02-09 14:35   ` Andrew Boyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=631D0A59-4851-4D4B-8131-FC9DB1D99334@pensando.io \
    --to=aboyer@pensando.io \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git