From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 940CCA04B1 for ; Wed, 4 Nov 2020 20:35:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 241732BF9; Wed, 4 Nov 2020 20:35:29 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0935F2BE2; Wed, 4 Nov 2020 20:35:25 +0100 (CET) IronPort-SDR: nOqscCm+a/7gFZ9dQyZyjiaKTd8blD9jWLQy4WzVoveUhHPBRFehPgjRGxyEN4krEPkcgQBmlS 0aRcb8ULBVsg== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="166687968" X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="166687968" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 11:35:21 -0800 IronPort-SDR: HV6gg95fitEGc7RXlWG+K4tSANE7F5p7FZl7EIL97QPGdY8E5fL8UYNzYIPYna4UVwEcqPBlTD 9juzM+9joiSw== X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="529049748" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.23.60]) ([10.252.23.60]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 11:35:19 -0800 To: Dharmik Thakkar , Bruce Richardson , Honnappa Nagarahalli , Ruifeng Wang , Gavin Hu Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org References: <20201103222352.11566-1-dharmik.thakkar@arm.com> <20201104185858.18397-1-dharmik.thakkar@arm.com> <20201104185858.18397-4-dharmik.thakkar@arm.com> From: "Medvedkin, Vladimir" Message-ID: <639396e2-7682-5bb4-a6ef-469673fb5e35@intel.com> Date: Wed, 4 Nov 2020 19:35:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201104185858.18397-4-dharmik.thakkar@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v5 3/4] test/lpm: remove error checking in rcu qsbr perf X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 04/11/2020 18:58, Dharmik Thakkar wrote: > Remove redundant error checking for reader threads > since they never return error. > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_lpm_perf.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c > index 873ecf511c97..c8e70ec89ff5 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -556,11 +556,10 @@ test_lpm_rcu_perf_multi_writer(void) > __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED) > / TOTAL_WRITES); > > - /* Wait and check return value from reader threads */ > writer_done = 1; > + /* Wait until all readers have exited */ > for (i = 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); > > rte_lpm_free(lpm); > rte_free(rv); > @@ -605,10 +604,9 @@ test_lpm_rcu_perf_multi_writer(void) > / TOTAL_WRITES); > > writer_done = 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i = 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); > > rte_lpm_free(lpm); > > @@ -712,10 +710,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); > > writer_done = 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i = 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); > > rte_lpm_free(lpm); > rte_free(rv); > @@ -771,11 +768,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); > > writer_done = 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i = 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - printf("Warning: lcore %u not finished.\n", > - enabled_core_ids[i]); > + rte_eal_wait_lcore(enabled_core_ids[i]); > > rte_lpm_free(lpm); > > Acked-by: Vladimir Medvedkin -- Regards, Vladimir