From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D8D8A04DE for ; Fri, 23 Oct 2020 18:31:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DE6A5A93; Fri, 23 Oct 2020 18:31:45 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C855C56A3; Fri, 23 Oct 2020 18:31:40 +0200 (CEST) IronPort-SDR: GWKlju/az1y+xWew4+vWtAdo7jKNm+UNLfLkk095tq95ZMJlDG0RttFyweIoTtJPK7HWQ7onbJ 18lwBm+0iguw== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="167821496" X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="167821496" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 09:31:38 -0700 IronPort-SDR: 9VUwIIXzf4iwARlYTcNn1qeYSg5Qv3I0f1ZXMRUaj7zBM4zA6wJt3ldetGhBVEzyBy7IHDArCH 8zrEnFZ4WcEQ== X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="534459889" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.253]) ([10.213.224.253]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 09:31:36 -0700 To: Liron Himi , wangyunjian , "dev@dpdk.org" Cc: "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" References: From: Ferruh Yigit Message-ID: <64413c49-7548-9f1a-f336-54edd870ee70@intel.com> Date: Fri, 23 Oct 2020 17:31:33 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix memory leak in error path X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/22/2020 7:40 AM, Liron Himi wrote: <...> > Subject: [EXT] [dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path > > External Email > > ---------------------------------------------------------------------- > From: Yunjian Wang > > In mrvl_create() allocated memory for 'mtr', we don't free it when profile get fails and it will lead to memory leak. > > We can get profile at the beginning of the function to fix it, before calling mtr = rte_zmalloc_socket(). > > Fixes: cdb53f8da628 ("net/mvpp2: support metering") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > > Acked-by: Liron Himi > Applied to dpdk-next-net/main, thanks.