From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42]) by dpdk.org (Postfix) with ESMTP id ED9CB4C8F for ; Tue, 12 Mar 2019 23:19:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCXpE+TDw5SCZQEml34yphoOXe/lk/d63RnkwmMzTRo=; b=J05MuvGSfESaySCVMG/55l1Z9P0EF7pCnR7p+2lbkqlW7sQH9iM2wZdX7pBuIDzAYggeAuyBERgImCBn2NtYE8SyThpSIZWa3CfRdwWsdzeEq99/T0JPUD2+QN5wy3f3q/kWE2por1tgY02Y7SxzSNyHRlEXkU5aPkGZQ7LjiLk= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3945.eurprd05.prod.outlook.com (52.134.65.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Tue, 12 Mar 2019 22:19:49 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1709.011; Tue, 12 Mar 2019 22:19:49 +0000 From: Yongseok Koh To: Radu Nicolau CC: "stable@dpdk.org" Thread-Topic: [17.11] examples/bond: fix crash when there is no active slave Thread-Index: AQHU2M36HXNuvgXUdE2BRy2gZhewNKYIkcwA Date: Tue, 12 Mar 2019 22:19:49 +0000 Message-ID: <65633994-82F3-4ECC-9385-EDD90EAF08D9@mellanox.com> References: <1552392830-6198-1-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1552392830-6198-1-git-send-email-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3547e061-b10e-42ae-54fe-08d6a738d74d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3945; x-ms-traffictypediagnostic: DB3PR0502MB3945: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB3945; 23:Q6xQ+cQnIu++SCqm/NCsUM5WSOqcEizxx2RVh9U?= =?us-ascii?Q?EUFc534TWsv5skojyNajzH1r7jikHZ8FqFHUXvnf2hkIFOfTn/5tQE4nlVXK?= =?us-ascii?Q?lbkjTjEVhC2sOCoQU6MIWcdg6JZanFFKCJGQ4/xLZr0fNpVLWnkdaw1Q/A9r?= =?us-ascii?Q?c49ZzXwfNYVygard3NpORwefI0ChT0cIuVRKS1qkY00ia7JkCPYCV0SEof0N?= =?us-ascii?Q?OjCcKNQuVsDRpEtj4XZBSpd+3C1Qxfzt3prlek3uHtC97t6SEttyAbPsEL7x?= =?us-ascii?Q?MDNfwVjPEYfqK6Ck97gzDrYHf0ezyzNerNmiPhmLE+8T2xJ7wXE/3x78vDjl?= =?us-ascii?Q?2UZD1ceTe5ttgEMVq2MKn6pOMwqPOVBvZkVzuG+DOBQSV1IZJRL5rSm2eQsy?= =?us-ascii?Q?IwOVtgBJgs7rQS+XCwpZpC8IYHhwb+RaD3ECPglflBrIoVAYLGwnCvFzWsMw?= =?us-ascii?Q?h+bpJ4BtZ7rhzz3PgoUIKQ/+vg1130QC+5oFIsjF/397K04aC+Vrdv2tDSv7?= =?us-ascii?Q?N4no4eVr/v+JjCKS+4aISkFiaFoLIe8AMF3yoNEYCILk4hnVktdrrLvsloa7?= =?us-ascii?Q?KQaLgQFwEGMCY3gN1w1XACYAwuRA9Udu5K9/o0x4UeQekthxdY9bWDUcki8O?= =?us-ascii?Q?eaiS3CHX19i7uMp0WsFxygIh3ASQW+ac8rNhKeaDTO4B522Jmbceqfwig4Oo?= =?us-ascii?Q?sZ8kZK1iThffnFeyP3YT2+zxtt5eagZwA3MqvoRRWGYagaiIhakir0NJHBS3?= =?us-ascii?Q?m/X2rtYI7SGm870YUd/Gv4w/3GZGXwSKHP1+IMeebac2KuDZmkVDd5y3w0qA?= =?us-ascii?Q?HTKZpO/4RG6I4+G9FBO1IL/mweOPx9vcJtA3djqgm7eR2cYKxa94uT/blh4c?= =?us-ascii?Q?00oZSZzhzZx+b1gptt2bf9wE7eFLLsi1VmaoFxcSulYZ0tqcoYVLEn2wpip5?= =?us-ascii?Q?gcr2R5cY/cd64UEAieeIFD2wMP2+BaOIlN87riyDpxv+X3Vf3LeeML8jnH/W?= =?us-ascii?Q?4NK8cEPmc4pNeGU3dvoAJ0DJ/GuaGKM49YXGle/B0S4sjN6XuxwUziZhVFk6?= =?us-ascii?Q?q3ceXv6HM4sAeLSpFrqI7oUgfbpWUhRk9aBnX79RedWusaF9jyM3JmleUvfQ?= =?us-ascii?Q?06E1MytSMkvIzg+MMzTV5P/gPJIYyoDLYJMoiGAtuM6Urr5gm0nMJ0wbY5sy?= =?us-ascii?Q?eJZX1ARm9+XTZIgkY99c/8psvt/m9agytn9ExJrlaM2IPraHNfLsbemxXbBU?= =?us-ascii?Q?MNCmUReco4SkBm9twm6I=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(366004)(396003)(346002)(39860400002)(199004)(189003)(99286004)(186003)(106356001)(68736007)(4744005)(6916009)(105586002)(6246003)(97736004)(36756003)(25786009)(4326008)(86362001)(66066001)(26005)(3846002)(6116002)(6506007)(316002)(53546011)(7736002)(8676002)(6436002)(229853002)(71200400001)(446003)(81156014)(8936002)(53936002)(256004)(305945005)(71190400001)(6512007)(11346002)(476003)(33656002)(81166006)(14454004)(486006)(6486002)(102836004)(478600001)(5660300002)(2906002)(76176011)(82746002)(2616005)(83716004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3945; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DXXBBGgPwWZCkG2bThNhdOvjqVLoi3NiMJOFpPQzMWCcgoEFbyhJgEM3x4gdBTSF/ndVKPYwds63hrY1L2iZP6vFBXsku2wGKmePKgBoR5fKrblUL4nCVy+HVirPgVSMsNnxDkFrkMg0bNyENTZoziPUSir28KQjrvQ40f6audcUzOLwgKJ7iYN0fD1/NodabHDsKYbDnbwTHFVKoN/pfUZ/ndIaVtQN4/VN6jI0eOEmaWCfNjsOL9JDrRC3drGrBRTXS6Kbv47tshHpOHBbkchSmIu9ca4FfgetRPsdwDjHBzegekFCj4dCGszpOmbqKpcPwOP7Y674z9s6bQeuImv1WbAjKNzNTEdppPiugCkF51YiQVHEQGv52f2Y9ECz5hRL9ipuN9CHSJP3qUS473AEkmy+NCzMYJ4alxdMTks= Content-Type: text/plain; charset="us-ascii" Content-ID: <820418AED8310942A4021A6C567E503B@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3547e061-b10e-42ae-54fe-08d6a738d74d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 22:19:49.0679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3945 Subject: Re: [dpdk-stable] [17.11] examples/bond: fix crash when there is no active slave X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 22:19:50 -0000 > On Mar 12, 2019, at 5:13 AM, Radu Nicolau wrote: >=20 > [ backported from upstream commit 292fdb76024f ] >=20 > If bond_ethdev_rx_burst() called more times with no active slaves > the active slave index will point out of bounds, resulting in a > segfault. > The configured slaves needs to be checked, and if none became active > there is no point going further. >=20 > Do not start the packet processing threads until all configured > slaves become active. >=20 > Fixes: cc7e8ae84faa ("examples/bond: add example application for link bon= ding mode 6") >=20 > Signed-off-by: Radu Nicolau > Acked-by: Chas Williams > --- applied to stable/17.11 Thanks, Yongseok=