From: Kevin Traynor <ktraynor@redhat.com>
To: Lance Richardson <lance.richardson@broadcom.com>, stable@dpdk.org
Cc: ajit.khaparde@broadcom.com
Subject: Re: [dpdk-stable] [PATCH 18.11] net/bnxt: advertise scatter Rx offload capability
Date: Thu, 5 Dec 2019 10:54:26 +0000 [thread overview]
Message-ID: <6708379b-f293-3d2a-0869-7f88e2896fe3@redhat.com> (raw)
In-Reply-To: <20191204210509.19869-1-lance.richardson@broadcom.com>
Hi Lance,
On 04/12/2019 21:05, Lance Richardson wrote:
> [ upstream commit 94d4afd2d167886f9eb4833443478e048cd60588 ]
>
> Scattered receive is supported but not included in receive offload
> capabilities. Fix by adding it to the receive offload capabilities..
>
> Fixes: 9c1507d96ab8 ("net/bnxt: switch to the new offload API")
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> Note: this patch drops the upstream hunk related to vector
> mode support, which is not present in 18.11.
>
The hunk below would have applied, but I was not confident to do it
because there bnxt_scattered_rx() was missing. Thanks for the backport,
I've added to the queue [1] and will be pushed next week.
Kevin.
[1]
https://github.com/kevintraynor/dpdk-stable-queue/commit/2d4e5e8980657fa2194203b9cd01d56446d00991
> drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 2f3e067ed..47dde067a 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -150,7 +150,8 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
> DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
> DEV_RX_OFFLOAD_JUMBO_FRAME | \
> DEV_RX_OFFLOAD_KEEP_CRC | \
> - DEV_RX_OFFLOAD_TCP_LRO)
> + DEV_RX_OFFLOAD_TCP_LRO | \
> + DEV_RX_OFFLOAD_SCATTER)
>
> static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
> static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
>
prev parent reply other threads:[~2019-12-05 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 21:05 Lance Richardson
2019-12-05 10:54 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6708379b-f293-3d2a-0869-7f88e2896fe3@redhat.com \
--to=ktraynor@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=lance.richardson@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).