From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by dpdk.org (Postfix) with ESMTP id AC8021B43F for ; Mon, 14 Jan 2019 10:08:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ROMHr14M2DIh0feI+t6mWzpdvwMMOH/oY2QR80fRXVg=; b=SG1pBs5bk6sGyqTie4Qzn/E2MeVGi0TuhJgL+W8qdk4gYy2Ipew61vuCpJBnQitfC4lWLc86Qi86CF4I8PYENUNYvcbUmHQeK/itY0SS27qaSWgdqHiwbrMDtZSkt2CdcAxiamiwHYjpSsR4oqkOty56+1Fr+peyrNszkzIWgv4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4074.eurprd05.prod.outlook.com (52.134.72.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Mon, 14 Jan 2019 09:08:21 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c%2]) with mapi id 15.20.1516.019; Mon, 14 Jan 2019 09:08:21 +0000 From: Yongseok Koh To: Raslan Darawsheh CC: "stable@dpdk.org" Thread-Topic: [17.11] net/tap: fix reported number of Tx packets Thread-Index: AQHUqxveirlyhoE8LEqDZrXnL6n2OqWuK6qAgAA4AyCAABd+AA== Date: Mon, 14 Jan 2019 09:08:21 +0000 Message-ID: <684043D8-0B9F-4ED6-A4CE-785B66EADAB1@mellanox.com> References: <1547368916-22381-1-git-send-email-rasland@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4074; 6:01yyuP4nACy6L+chiiG2Qdvmubi9SSGJ02wfnnskUULSyTsMZlEd+i8PZPMzurrIRwrK6IRmiuOwXfaLqJNxJnv5EeJCo3/ZUQmAmSWtEvoV15sT5rzIFHC6OpZck6XCwXUlU39VTHEbJIklxEDorHvh3TiTBNNUgu3iEb1U24CibP/8ISwaBTRj2rabN9ukv/jk39M7Jk2xyccj0ikj7MyfbpgT0Z4fwnYX1WcUVJR2FRgy8FKj1awLuu94cgpKMIf4LIQS6X2StfsCUtYeBIJZVJobOB1rO+olwFph8MAAgP6qYrSd+1GtHP5dVufiECb6gYpCJ7gKqx9Vz2mI7uQQQBwtI/sBDHovx1K52gaTDRZw8SyP1Xdf2SO3WqhaelkYWYSjqxR1vjr7a+Wv9cgsS25p6GjvducKWDPHyFRj0Ia8l+xIuRyUYym7Kqyh4IXIf51lQKTRJNpSK/aeUQ==; 5:jtgvWYerM1fT3dMpRRplvqZK5OTyjLVaYxPv2zDyvaOKCWeTHMMwK2bfV9KjUB0OMPBkZXlwBGYE4uJ9cpbxhd1aAQkhFzjF33w5psNQMX2z8RNc0cGfWpItPwdMEtvlyFX1fdDI3f4uuR7mvRfphBeGiqbLXJ7OK5Q6drpSI5TvGErRkQQohhfn3zEFInXjw4V6hf5mKxQ9N7THKC7OAg==; 7:r+6Y6MJZ9Oe6YPdJSvIiNxobhHEym400uCmhx1oF8XhEbWy6opJ9dKVXbAfamXhm0r8P4Kv1h1rD81kuBSc+l+vPU8Dcg8282mIcsfalXCaQhAd6X0qdH4EVjFyM8p5ourtwI9H5+CdtM5pRoqMBHg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e86375fc-eec5-488b-172c-08d679ffd4d5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4074; x-ms-traffictypediagnostic: DB3PR0502MB4074: x-microsoft-antispam-prvs: x-forefront-prvs: 0917DFAC67 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(396003)(39860400002)(376002)(13464003)(189003)(199004)(53546011)(6506007)(71200400001)(83716004)(229853002)(71190400001)(26005)(2906002)(102836004)(6486002)(14454004)(478600001)(6116002)(68736007)(76176011)(6246003)(3846002)(256004)(14444005)(446003)(36756003)(33656002)(11346002)(476003)(2616005)(106356001)(53936002)(8936002)(6512007)(81156014)(5660300001)(8676002)(37006003)(105586002)(316002)(81166006)(97736004)(99286004)(486006)(4326008)(82746002)(305945005)(86362001)(575784001)(186003)(6436002)(7736002)(25786009)(6862004)(6636002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4074; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gS/BbjnbSb3SM1SGWKHqSYsmwLS9q35NE9Vn63iaRpgVRwMbIt76wLPAt8uQPlE44a5FgpB7dCutZojRueYzzT2W38/6EsxPeZbctqd0fAmVLTiYH3iUTPi3zEPzZilLo+yDaMCmxQyY56DRzMD9+ThvEebNcnByoJi8Ik7ZiXdss3ouWkMysKx8UqrG0xy3j4azED8ftAGm8LpmBq/cv3T0GcavLTi39G8yHtIusdt83fUCjA+zlgFWIQADPhyM04vtI9cI3v3JBCqzPt84+4//Bx0iMZ0SrhLuQK6tkNL6nXZ5Hz9uqtdNOQo0TS0IPoOpnL7ZVdCAAvYvxFsz1J5aVW+OvakiKGCrvs3K0ZI0jlswrvNY1KiKOpovsbF7A+WIcTf+BLs+Pbi1BD3gsD3yf48JQTFAXcxqK9UdQRY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <80ACF6B6C7F37D479AF26A164DBE4A41@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e86375fc-eec5-488b-172c-08d679ffd4d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2019 09:08:21.3391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4074 Subject: Re: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 09:08:25 -0000 > On Jan 13, 2019, at 11:46 PM, Raslan Darawsheh wro= te: >=20 > Hi Yongseok, >=20 > I've just double check that, sorry for this issue, but it seems that we d= on't really need this patch for stable. >=20 > The issue that this patch solves came from the fact that when the call to= writev fails It was updating num_tx, > but this is not the case for 17.11 so I believe we can drop this patch fo= r 17.11 Got it. Thanks, Yongseok >> -----Original Message----- >> From: Yongseok Koh >> Sent: Monday, January 14, 2019 6:24 AM >> To: Raslan Darawsheh >> Cc: stable@dpdk.org >> Subject: Re: [17.11] net/tap: fix reported number of Tx packets >>=20 >>=20 >>> On Jan 13, 2019, at 12:42 AM, Raslan Darawsheh >> wrote: >>>=20 >>> When writev fails to send packets it doesn't update the number of Tx >>> packets, but it still num_tx is updated. >>>=20 >>> The value that should be returned is the actual number of sent packets >>> which is num_packets. >>>=20 >>> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") >>> CC: stable@dpdk.org >>>=20 >>> Signed-off-by: Raslan Darawsheh >>> Acked-by: Keith Wiles >>> --- >>=20 >> Raslan, it doesn't get compiled on stable/17.11 >>=20 >> Thanks, >> Yongseok >>=20 >>> drivers/net/tap/rte_eth_tap.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>=20 >>> diff --git a/drivers/net/tap/rte_eth_tap.c >>> b/drivers/net/tap/rte_eth_tap.c index 466624a..50757ef 100644 >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf >> **bufs, uint16_t nb_pkts) >>> txq->stats.errs +=3D nb_pkts - num_tx; >>> txq->stats.obytes +=3D num_tx_bytes; >>>=20 >>> - return num_tx; >>> + return num_packets; >>> } >>>=20 >>> static const char * >>> -- >>> 2.7.4 >>>=20 >=20