[PATCH] pdump: clear statistics when enabled

[PATCH] pdump: clear statistics when enabled

[Stephen Hemminger]

The pdump statistics are used to keep track of the number
of packets captured, filtered, etc. These need not be cumalative
and instead should be start counting when capture starts.

This fixes the issue where multiple invocations of dumpcap
would include counts from previous invocations.

Bugzilla ID: 1604
Fixes: 10f726efe26c ("pdump: support pcapng and filtering")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/pdump/rte_pdump.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 679c3dd0b5..0e6ffc167b 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -199,6 +199,8 @@ pdump_register_rx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+
+			memset(&pdump_stats->rx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
@@ -257,6 +259,7 @@ pdump_register_tx_callbacks(enum pdump_version ver,
 					rte_errno);
 				return rte_errno;
 			}
+			memset(&pdump_stats->tx[port][qid], 0, sizeof(struct rte_pdump_stats));
 		} else if (operation == DISABLE) {
 			int ret;
 
-- 
2.45.2

Re: [PATCH] pdump: clear statistics when enabled

[Thomas Monjalon]

20/12/2024 00:58, Stephen Hemminger:
> The pdump statistics are used to keep track of the number
> of packets captured, filtered, etc. These need not be cumalative
> and instead should be start counting when capture starts.
> 
> This fixes the issue where multiple invocations of dumpcap
> would include counts from previous invocations.
> 
> Bugzilla ID: 1604
> Fixes: 10f726efe26c ("pdump: support pcapng and filtering")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Sorry this "christmas" patch was forgotten.

Applied, thanks.