From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3761FA0A02 for ; Wed, 14 Apr 2021 23:10:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E3E5161D33; Wed, 14 Apr 2021 23:10:58 +0200 (CEST) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by mails.dpdk.org (Postfix) with ESMTP id 02E23161D29; Wed, 14 Apr 2021 23:10:54 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id 40BEBFF3; Wed, 14 Apr 2021 17:10:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 17:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= ypN0vdJ3iBhYOSIDq1DhRupUInG4Qbe57KiCkIU5mew=; b=vpIeZDTo2L5NbmD5 uipqYOTQhtMXXI6uKNDK4j+8fQ6cr6ydmLuZbhnbPNMN0RDm5RTXF7XoiXy+rDS5 72ktINwPq0VICok48q1cyNMW/juFMh1VtkP5zGqjcKfHjHSvKhGr7Z+V1hyGg9ZH f9zw2UnNQjvECcU4KDOwFLogbIDPHo1scwY9eSo3zHgPwCADPmL6q0iR6jxVSJn9 wfdnooQDaf9zi6ZQRHr/8EjwFc8lrvMCoieN2AEI80yw/cmhWnL7FD/r3gubYjRJ Ycnp+uAiRdvWmBSFEiAzCqdEkB/v1kQWh+lNpjFqr+VYM/Anq5Yu5hAp3wXIn3DG 8YzNeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ypN0vdJ3iBhYOSIDq1DhRupUInG4Qbe57KiCkIU5m ew=; b=wquUJQ2OapO8CslMwiY1548BOhKHdMJkrzU92y8i+jwbknoUJS3Ury4AN uIyadPsmf/sKUV4oqf61LPh/B1sQ5Gf/BJ56vS50Y8KiJZ8Orl6l2rhpLVQ8Z6lm vZIMAdrc29tQFpqxE2okJxl3gGHL2ivChI+UULfDW4ZvhdPwbSCD6YvT6e0sJFaH FS2774LUm3v2lzBH7+pV3lrbTiBIgy+vMjKCdVC/KFYiVFDul+ZnAWODG3yek2ag AoYNyAZZvgFlPMDfMubgtGtTKRKgcFn3WFMKzYIaVJepi2r65DAMto4hjSJIVQIu j03D0L1vqbsno2KEjjxVU6KY8Mxfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0444E108005B; Wed, 14 Apr 2021 17:10:47 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, bruce.richardson@intel.com, bluca@debian.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Gabriel Ganne , stable@dpdk.org, Harry van Haaren , Luca Boccassi , Keith Wiles , david.marchand@redhat.com Date: Wed, 14 Apr 2021 23:10:46 +0200 Message-ID: <6947263.kiK9OB8DAI@thomas> In-Reply-To: <20210415000245.0b1d45c1@sovereign> References: <20210409083927.8345-1-gabriel.ganne@6wind.com> <3119483.LeJDoi8FaI@thomas> <20210415000245.0b1d45c1@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5] build: remove redundant libpcap link X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 14/04/2021 23:02, Dmitry Kozlyuk: > 2021-04-14 11:41 (UTC+0200), Thomas Monjalon: > > 09/04/2021 14:25, Thomas Monjalon: > > > From: Gabriel Ganne > > > > > > The pcap PMD and the librte_port both declare their dependency to libpcap > > > with a line "ext_deps += pcap_dep". > > > Then meson automatically adds this dependency to the pkg-config file > > > in the "Requires.private" section for static builds. > > > > > > The additional update of dpdk_extra_ldflags was adding the dependency > > > in the "Libs.private" section of the pkg-config, that is unnecessary. > > > > > > Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson") > > > Fixes: 268fa581b1ff ("port: fix pcap support with meson") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gabriel Ganne > > > Signed-off-by: Thomas Monjalon > > > --- > > > I have a doubt whether this option is really always useless. > > > In the case of an old pcap (<1.9) without pkg-config support, > > > and with the minimum meson supported (0.47.1), > > > are we sure the generated pkg-config file will include -lpcap? > > > > Any volunteer to test please? > > Ubuntu 16.04, Meson 0.47.1, libpcap 1.7.4-2ubuntu0.1, after the patch > libdpdk.pc contains: > > Libs.private: -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap > -lpcap -lpcap [...DPDK libraries...] > > Note that -lpcap comes _before_ DPDK libraries that require it. > As a consequence, this doesn't link with unresolved libpcap symbols: > > gcc test.c `pkg-config --static --cflags --libs libdpdk` > > Before the patch -lpcap was _after_ DPDK libraries, > link succeeded (there was also _one_ -lpcap before DPDK libraries). > > Meson 0.55.1 places -lpcap _after_ DPDK libraries, > link succeeds both before and after the patch. > > Conclusion: this patch really breaks .pc file for older meson. Thanks for the test. I propose to defer this patch. It could be merged when we upgrade meson requirement. In the meantime, we could document why this line is required. > If it can't be merged, dependent patches for net/pcap on Windows > can be easily adjusted to work without it.