patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: [dpdk-stable] [PATCH 17.11] test/bonding: assign non-zero MAC to null devices
Date: Fri, 19 Jul 2019 08:55:09 +0000	[thread overview]
Message-ID: <696B43C21188DF4F9C9091AAE4789B8260FFEB2E@IRSMSX108.ger.corp.intel.com> (raw)

From: Radu Nicolau <radu.nicolau@intel.com>
[backported from upstream commit e8df563bac263e55b7dd9d45a00417aa92ef66cb]

Prevent failure in rte_eth_dev_default_mac_addr_set() that
results in bonding add slave failure.

Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 test/test/test_link_bonding_rssconf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c
index 54cbf12..a637453 100644
--- a/test/test/test_link_bonding_rssconf.c
+++ b/test/test/test_link_bonding_rssconf.c
@@ -534,6 +534,7 @@ test_setup(void)
 	int port_id;
 	char name[256];
 	struct slave_conf *port;
+	struct ether_addr mac_addr = {0};
 
 	if (test_params.mbuf_pool == NULL) {
 
@@ -565,6 +566,10 @@ test_setup(void)
 		TEST_ASSERT_SUCCESS(retval, "Failed to configure virtual ethdev %s\n",
 				name);
 
+		/* assign a non-zero MAC */
+		mac_addr.addr_bytes[5] = 0x10 + port->port_id;
+		rte_eth_dev_default_mac_addr_set(port->port_id, &mac_addr);
+
 		rte_eth_dev_info_get(port->port_id, &port->dev_info);
 	}
 
-- 
2.7.4


             reply	other threads:[~2019-07-19  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  8:55 Rybalchenko, Kirill [this message]
2019-07-23  1:32 ` Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=696B43C21188DF4F9C9091AAE4789B8260FFEB2E@IRSMSX108.ger.corp.intel.com \
    --to=kirill.rybalchenko@intel.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).