* [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities
@ 2018-07-25 7:14 Xiaoyun Li
2018-08-01 1:18 ` Lu, Wenzhuo
0 siblings, 1 reply; 5+ messages in thread
From: Xiaoyun Li @ 2018-07-25 7:14 UTC (permalink / raw)
To: wenzhuo.lu, jingjing.wu; +Cc: dev, Xiaoyun Li, stable
There are several tx/rx offload capabilities missing in AVF.
Add them in this patch since AVF supports them.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: stable@dpdk.org
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 0e21f8c..3a2baaf 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX;
dev_info->rx_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
+ DEV_RX_OFFLOAD_QINQ_STRIP |
DEV_RX_OFFLOAD_IPV4_CKSUM |
DEV_RX_OFFLOAD_UDP_CKSUM |
- DEV_RX_OFFLOAD_TCP_CKSUM;
+ DEV_RX_OFFLOAD_TCP_CKSUM |
+ DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+ DEV_RX_OFFLOAD_CRC_STRIP |
+ DEV_RX_OFFLOAD_KEEP_CRC |
+ DEV_RX_OFFLOAD_SCATTER |
+ DEV_RX_OFFLOAD_JUMBO_FRAME |
+ DEV_RX_OFFLOAD_VLAN_FILTER;
dev_info->tx_offload_capa =
DEV_TX_OFFLOAD_VLAN_INSERT |
+ DEV_TX_OFFLOAD_QINQ_INSERT |
DEV_TX_OFFLOAD_IPV4_CKSUM |
DEV_TX_OFFLOAD_UDP_CKSUM |
DEV_TX_OFFLOAD_TCP_CKSUM |
DEV_TX_OFFLOAD_SCTP_CKSUM |
- DEV_TX_OFFLOAD_TCP_TSO;
+ DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+ DEV_TX_OFFLOAD_TCP_TSO |
+ DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+ DEV_TX_OFFLOAD_GRE_TNL_TSO |
+ DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ DEV_TX_OFFLOAD_MULTI_SEGS;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_free_thresh = AVF_DEFAULT_RX_FREE_THRESH,
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities 2018-07-25 7:14 [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities Xiaoyun Li @ 2018-08-01 1:18 ` Lu, Wenzhuo 2018-08-01 1:34 ` Li, Xiaoyun 0 siblings, 1 reply; 5+ messages in thread From: Lu, Wenzhuo @ 2018-08-01 1:18 UTC (permalink / raw) To: Li, Xiaoyun, Wu, Jingjing; +Cc: dev, stable Hi Xiaoyun, > -----Original Message----- > From: Li, Xiaoyun > Sent: Wednesday, July 25, 2018 3:15 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org > Subject: [PATCH] net/avf: fix missing offload capabilities > > There are several tx/rx offload capabilities missing in AVF. > Add them in this patch since AVF supports them. > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > Cc: stable@dpdk.org > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > --- > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index > 0e21f8c..3a2baaf 100644 > --- a/drivers/net/avf/avf_ethdev.c > +++ b/drivers/net/avf/avf_ethdev.c > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX; > dev_info->rx_offload_capa = > DEV_RX_OFFLOAD_VLAN_STRIP | > + DEV_RX_OFFLOAD_QINQ_STRIP | > DEV_RX_OFFLOAD_IPV4_CKSUM | > DEV_RX_OFFLOAD_UDP_CKSUM | > - DEV_RX_OFFLOAD_TCP_CKSUM; > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_RX_OFFLOAD_CRC_STRIP | > + DEV_RX_OFFLOAD_KEEP_CRC | Don't find this flag. Does this path depend on another? Do we need to announce this capa? > + DEV_RX_OFFLOAD_SCATTER | > + DEV_RX_OFFLOAD_JUMBO_FRAME | > + DEV_RX_OFFLOAD_VLAN_FILTER; > dev_info->tx_offload_capa = > DEV_TX_OFFLOAD_VLAN_INSERT | > + DEV_TX_OFFLOAD_QINQ_INSERT | > DEV_TX_OFFLOAD_IPV4_CKSUM | > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM | > DEV_TX_OFFLOAD_SCTP_CKSUM | > - DEV_TX_OFFLOAD_TCP_TSO; > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > + DEV_TX_OFFLOAD_TCP_TSO | > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > + DEV_TX_OFFLOAD_MULTI_SEGS; > > dev_info->default_rxconf = (struct rte_eth_rxconf) { > .rx_free_thresh = AVF_DEFAULT_RX_FREE_THRESH, > -- > 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities 2018-08-01 1:18 ` Lu, Wenzhuo @ 2018-08-01 1:34 ` Li, Xiaoyun 2018-08-02 1:56 ` Lu, Wenzhuo 0 siblings, 1 reply; 5+ messages in thread From: Li, Xiaoyun @ 2018-08-01 1:34 UTC (permalink / raw) To: Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, stable Hi > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, August 1, 2018 09:19 > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > Hi Xiaoyun, > > > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Wednesday, July 25, 2018 3:15 PM > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com> > > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org > > Subject: [PATCH] net/avf: fix missing offload capabilities > > > > There are several tx/rx offload capabilities missing in AVF. > > Add them in this patch since AVF supports them. > > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > > --- > > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/avf/avf_ethdev.c > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644 > > --- a/drivers/net/avf/avf_ethdev.c > > +++ b/drivers/net/avf/avf_ethdev.c > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, struct > > rte_eth_dev_info *dev_info) > > dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX; > > dev_info->rx_offload_capa = > > DEV_RX_OFFLOAD_VLAN_STRIP | > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > DEV_RX_OFFLOAD_UDP_CKSUM | > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_RX_OFFLOAD_CRC_STRIP | > > + DEV_RX_OFFLOAD_KEEP_CRC | > Don't find this flag. Does this path depend on another? > Do we need to announce this capa? You mean KEEP_CRC? I copy the flags from i40evf. In release note: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, default behavior without any flag will be changed to CRC strip. To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. ``KEEP_CRC``: Keep CRC in packet No flag: Strip CRC from packet > > > + DEV_RX_OFFLOAD_SCATTER | > > + DEV_RX_OFFLOAD_JUMBO_FRAME | > > + DEV_RX_OFFLOAD_VLAN_FILTER; > > dev_info->tx_offload_capa = > > DEV_TX_OFFLOAD_VLAN_INSERT | > > + DEV_TX_OFFLOAD_QINQ_INSERT | > > DEV_TX_OFFLOAD_IPV4_CKSUM | > > DEV_TX_OFFLOAD_UDP_CKSUM | > > DEV_TX_OFFLOAD_TCP_CKSUM | > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > - DEV_TX_OFFLOAD_TCP_TSO; > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > + DEV_TX_OFFLOAD_TCP_TSO | > > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | > > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > > + DEV_TX_OFFLOAD_MULTI_SEGS; > > > > dev_info->default_rxconf = (struct rte_eth_rxconf) { > > .rx_free_thresh = AVF_DEFAULT_RX_FREE_THRESH, > > -- > > 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities 2018-08-01 1:34 ` Li, Xiaoyun @ 2018-08-02 1:56 ` Lu, Wenzhuo 2018-08-02 2:21 ` Zhang, Qi Z 0 siblings, 1 reply; 5+ messages in thread From: Lu, Wenzhuo @ 2018-08-02 1:56 UTC (permalink / raw) To: Li, Xiaoyun, Wu, Jingjing; +Cc: dev, stable Hi Xiaoyun, > -----Original Message----- > From: Li, Xiaoyun > Sent: Wednesday, August 1, 2018 9:35 AM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > Hi > > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Wednesday, August 1, 2018 09:19 > > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com> > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > Hi Xiaoyun, > > > > > > > -----Original Message----- > > > From: Li, Xiaoyun > > > Sent: Wednesday, July 25, 2018 3:15 PM > > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > > <jingjing.wu@intel.com> > > > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; > > > stable@dpdk.org > > > Subject: [PATCH] net/avf: fix missing offload capabilities > > > > > > There are several tx/rx offload capabilities missing in AVF. > > > Add them in this patch since AVF supports them. > > > > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > > > --- > > > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/avf/avf_ethdev.c > > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644 > > > --- a/drivers/net/avf/avf_ethdev.c > > > +++ b/drivers/net/avf/avf_ethdev.c > > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, > > > struct rte_eth_dev_info *dev_info) > > > dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX; > > > dev_info->rx_offload_capa = > > > DEV_RX_OFFLOAD_VLAN_STRIP | > > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > > DEV_RX_OFFLOAD_UDP_CKSUM | > > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > > + DEV_RX_OFFLOAD_CRC_STRIP | > > > + DEV_RX_OFFLOAD_KEEP_CRC | > > Don't find this flag. Does this path depend on another? > > Do we need to announce this capa? > > You mean KEEP_CRC? I copy the flags from i40evf. > In release note: > In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, > default > behavior without any flag will be changed to CRC strip. > To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. > ``KEEP_CRC``: Keep CRC in packet > No flag: Strip CRC from packet O, got the history. Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> > > > > > > + DEV_RX_OFFLOAD_SCATTER | > > > + DEV_RX_OFFLOAD_JUMBO_FRAME | > > > + DEV_RX_OFFLOAD_VLAN_FILTER; > > > dev_info->tx_offload_capa = > > > DEV_TX_OFFLOAD_VLAN_INSERT | > > > + DEV_TX_OFFLOAD_QINQ_INSERT | > > > DEV_TX_OFFLOAD_IPV4_CKSUM | > > > DEV_TX_OFFLOAD_UDP_CKSUM | > > > DEV_TX_OFFLOAD_TCP_CKSUM | > > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > > - DEV_TX_OFFLOAD_TCP_TSO; > > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > > + DEV_TX_OFFLOAD_TCP_TSO | > > > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | > > > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | > > > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | > > > + DEV_TX_OFFLOAD_MULTI_SEGS; > > > > > > dev_info->default_rxconf = (struct rte_eth_rxconf) { > > > .rx_free_thresh = AVF_DEFAULT_RX_FREE_THRESH, > > > -- > > > 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities 2018-08-02 1:56 ` Lu, Wenzhuo @ 2018-08-02 2:21 ` Zhang, Qi Z 0 siblings, 0 replies; 5+ messages in thread From: Zhang, Qi Z @ 2018-08-02 2:21 UTC (permalink / raw) To: Lu, Wenzhuo, Li, Xiaoyun, Wu, Jingjing; +Cc: dev, stable > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Thursday, August 2, 2018 9:56 AM > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities > > Hi Xiaoyun, > > > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Wednesday, August 1, 2018 9:35 AM > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com> > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > Hi > > > > > -----Original Message----- > > > From: Lu, Wenzhuo > > > Sent: Wednesday, August 1, 2018 09:19 > > > To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing > > > <jingjing.wu@intel.com> > > > Cc: dev@dpdk.org; stable@dpdk.org > > > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > > > > > Hi Xiaoyun, > > > > > > > > > > -----Original Message----- > > > > From: Li, Xiaoyun > > > > Sent: Wednesday, July 25, 2018 3:15 PM > > > > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > > > <jingjing.wu@intel.com> > > > > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; > > > > stable@dpdk.org > > > > Subject: [PATCH] net/avf: fix missing offload capabilities > > > > > > > > There are several tx/rx offload capabilities missing in AVF. > > > > Add them in this patch since AVF supports them. > > > > > > > > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > > > > --- > > > > drivers/net/avf/avf_ethdev.c | 18 ++++++++++++++++-- > > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/net/avf/avf_ethdev.c > > > > b/drivers/net/avf/avf_ethdev.c index 0e21f8c..3a2baaf 100644 > > > > --- a/drivers/net/avf/avf_ethdev.c > > > > +++ b/drivers/net/avf/avf_ethdev.c > > > > @@ -518,16 +518,30 @@ avf_dev_info_get(struct rte_eth_dev *dev, > > > > struct rte_eth_dev_info *dev_info) > > > > dev_info->max_mac_addrs = AVF_NUM_MACADDR_MAX; > > > > dev_info->rx_offload_capa = > > > > DEV_RX_OFFLOAD_VLAN_STRIP | > > > > + DEV_RX_OFFLOAD_QINQ_STRIP | > > > > DEV_RX_OFFLOAD_IPV4_CKSUM | > > > > DEV_RX_OFFLOAD_UDP_CKSUM | > > > > - DEV_RX_OFFLOAD_TCP_CKSUM; > > > > + DEV_RX_OFFLOAD_TCP_CKSUM | > > > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | > > > > + DEV_RX_OFFLOAD_CRC_STRIP | > > > > + DEV_RX_OFFLOAD_KEEP_CRC | > > > Don't find this flag. Does this path depend on another? > > > Do we need to announce this capa? > > > > You mean KEEP_CRC? I copy the flags from i40evf. > > In release note: > > In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, > > default > > behavior without any flag will be changed to CRC strip. > > To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required. > > ``KEEP_CRC``: Keep CRC in packet > > No flag: Strip CRC from packet > O, got the history. > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> Applied to dpdk-next-net-intel. Thanks! Qi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-02 2:22 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-25 7:14 [dpdk-stable] [PATCH] net/avf: fix missing offload capabilities Xiaoyun Li 2018-08-01 1:18 ` Lu, Wenzhuo 2018-08-01 1:34 ` Li, Xiaoyun 2018-08-02 1:56 ` Lu, Wenzhuo 2018-08-02 2:21 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).