From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 986B9A04C2 for ; Tue, 26 Nov 2019 03:05:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 660F1235; Tue, 26 Nov 2019 03:05:47 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D8FCDCF3; Tue, 26 Nov 2019 03:05:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 18:05:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,243,1571727600"; d="scan'208";a="202568018" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 25 Nov 2019 18:05:40 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 18:05:40 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 18:05:40 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Tue, 26 Nov 2019 10:05:38 +0800 From: "Lu, Wenzhuo" To: "Cui, LunyuanX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4] net/ixgbe: fix link status Thread-Index: AQHVneQhs2e0Lnw/mEm9PgbWySfs4KecwBrw Date: Tue, 26 Nov 2019 02:05:37 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909408A3B6E@shsmsx102.ccr.corp.intel.com> References: <20191118101345.42181-1-lunyuanx.cui@intel.com> <20191118153744.78987-1-lunyuanx.cui@intel.com> In-Reply-To: <20191118153744.78987-1-lunyuanx.cui@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v4] net/ixgbe: fix link status X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, > -----Original Message----- > From: Cui, LunyuanX > Sent: Monday, November 18, 2019 11:38 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Cui, LunyuanX > ; stable@dpdk.org > Subject: [PATCH v4] net/ixgbe: fix link status >=20 > The link status for 82599eb got from link status register was not correct= . > Check the enable/disable flag of tx laser, set the link status down if tx= laser > disabled. Then, we can get correct status. > But after port reset, tx laser register will be reset enable. > Link status will always be up. So set tx laser disable when port resets. >=20 > When hw->mac.autotry_restart is true, whether tx laser is disable or enab= le, > it will be set enable in ixgbe_flap_tx_laser_multispeed_fiber(). > hw->mac.autotry_restart can be set true in both port init and port start. > Because we don't need this treatment before port starts, set > hw->mac.autotry_restart false when port init. >=20 > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update= ") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lunyuan Cui Acked-by: Wenzhuo Lu