From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C23C0A055F for ; Thu, 27 Feb 2020 14:13:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA7851F1C; Thu, 27 Feb 2020 14:13:57 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id DD1011F1C for ; Thu, 27 Feb 2020 14:13:55 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id p9so3530228wmc.2 for ; Thu, 27 Feb 2020 05:13:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=hIygYhiBf5ywvbxIj0m7SavNzvN/Eiu6iPScvinLSTk=; b=RaHGBzRXfIvZrfxl3+5wnJcJuHN326ZkcMQB9uDiKkbYgHc+JalCem2jAEgaWWh+lm nvyzpGW/ZWdSmP4MfZvxk3QgvnaUr9L3k2wq2TfZbAuEIPwgymM+9zOFZA4wYmoExxK8 RlSeRm5ElLiInW07me6bv3SGU6Zm5oBwMCEEv+e/B9bSCMdcVZaXKrQfwKga3+BCKj9p gElniIVMl55fr/pV1KeqremckngPc9syd9Yxp3QBpymEhRRAJO8kGYiXrLdx4VgRINN/ oaKyHocqZgbXYN/oE3ewvelbPZDZmK6+KNCrf0LhKFaPN2qL1vmQ1jpojhcbYDBfu9F9 qo+w== X-Gm-Message-State: APjAAAWhy57J1Z8peINueqKONG4c6HsNC0M9STXG/jmrIxlVAgQb5y87 qJjAVg0ddrKu4qnNRNUvODEu97YtlkY= X-Google-Smtp-Source: APXvYqy4wM2saDPES7mgsT0fJ4bk49ZkuOmHvRXOXgbkZE9sivuTazUB/E8EAx1sBo/rbRdLJGSYVQ== X-Received: by 2002:a1c:7419:: with SMTP id p25mr5053374wmc.129.1582809235644; Thu, 27 Feb 2020 05:13:55 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a22sm7671254wmd.20.2020.02.27.05.13.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 05:13:54 -0800 (PST) Message-ID: <6abeb72992b4a471765c7b095c02dc3a0f5bb26a.camel@debian.org> From: Luca Boccassi To: Viacheslav Ovsiienko , stable@dpdk.org Date: Thu, 27 Feb 2020 13:13:54 +0000 In-Reply-To: <1582807239-17462-1-git-send-email-viacheslavo@mellanox.com> References: <1582807239-17462-1-git-send-email-viacheslavo@mellanox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11 v2] net/mlx5: fix last completed built descriptor X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 2020-02-27 at 12:40 +0000, Viacheslav Ovsiienko wrote: > The routine sending packets with Multi-Packet Write method assigns > the wqe_last variable with transmit descriptor (WQE - work queue > entry) > being built. If send queue is close to full state, the WQE has no > data > yet (trying to put the first packet) and there is no enough space > in descriptor for the next packet the WQE is discarded and the stored > wqe_last value becomes invalid - points to the discarded WQE. >=20 > The mlx5_tx_burst_request_completion() routine might set the > completion > request flags in the WQE pointed by wqe_last, it is safe, but the > next > mlx5_tx_burst call uses the WQE as the first free one and request > completion flags might be overwritten and completion request will be > lost causing the transmit datapath malfunction. >=20 > Fixes: aa7c60a80997 ("net/mlx5: move Tx complete request routine") > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Viacheslav Ovsiienko < > viacheslavo@mellanox.com > > > Acked-by: Matan Azrad < > matan@mellanox.com > > > --- > drivers/net/mlx5/mlx5_rxtx.c | 51 +++++++++++++++++++++++++++------- > ---------- > 1 file changed, 31 insertions(+), 20 deletions(-) Thanks, applied. --=20 Kind regards, Luca Boccassi