* [dpdk-stable] [dpdk-dev] [PATCH] bus/dpaa: remove logically dead code
@ 2020-08-24 13:02 wangyunjian
2020-09-03 16:23 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: wangyunjian @ 2020-08-24 13:02 UTC (permalink / raw)
To: dev
Cc: hemant.agrawal, sachin.saxena, jerry.lilijun, xudingke,
Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
This patch removes logically dead code reported by coverity.
Coverity issue: 349930
Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/bus/dpaa/base/qbman/qman_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c
index 1166d68e2..a466c698f 100644
--- a/drivers/bus/dpaa/base/qbman/qman_driver.c
+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c
@@ -189,8 +189,6 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd)
*fd = q_fd;
return portal;
err:
- if (portal)
- qman_free_global_portal(portal);
if (q_fd)
close(q_fd);
process_portal_unmap(&q_map.addr);
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] bus/dpaa: remove logically dead code
2020-08-24 13:02 [dpdk-stable] [dpdk-dev] [PATCH] bus/dpaa: remove logically dead code wangyunjian
@ 2020-09-03 16:23 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-09-03 16:23 UTC (permalink / raw)
To: wangyunjian, dev
Cc: hemant.agrawal, sachin.saxena, jerry.lilijun, xudingke, stable
On 8/24/2020 2:02 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch removes logically dead code reported by coverity.
>
> Coverity issue: 349930
> Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 13:02 [dpdk-stable] [dpdk-dev] [PATCH] bus/dpaa: remove logically dead code wangyunjian
2020-09-03 16:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).