* Re: [dpdk-stable] [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode
[not found] <20190107144051.7097-1-david.hunt@intel.com>
@ 2019-02-06 15:47 ` Kevin Traynor
2019-02-06 16:24 ` Hunt, David
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Traynor @ 2019-02-06 15:47 UTC (permalink / raw)
To: David Hunt, dev; +Cc: liang.j.ma, stable, Thomas Monjalon
On 01/07/2019 02:40 PM, David Hunt wrote:
> The cpufreq test breakes when the system is using the intel_pstate
> driver for frequency management. The power library has recentyly been
> updated to allow use of the intel_pstate driver, this patch fixes the
> cpufreq test so that it can now use either acpi or pstate modes.
> The library will auto-detect, and set the environment appropriately.
>
> Fixes: ed7c51a6a680 ("app/test: vm power management")
>
I think this should have been:
Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
Presumably based on the Fixes tag, it got a stable tag added also, but
it does not look correct for 18.11 and breaks the build. If that's
incorrect, please let me know.
> Signed-off-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode
2019-02-06 15:47 ` [dpdk-stable] [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode Kevin Traynor
@ 2019-02-06 16:24 ` Hunt, David
0 siblings, 0 replies; 2+ messages in thread
From: Hunt, David @ 2019-02-06 16:24 UTC (permalink / raw)
To: Kevin Traynor, dev; +Cc: liang.j.ma, stable, Thomas Monjalon
Hi Kevin,
On 6/2/2019 3:47 PM, Kevin Traynor wrote:
> On 01/07/2019 02:40 PM, David Hunt wrote:
>> The cpufreq test breakes when the system is using the intel_pstate
>> driver for frequency management. The power library has recentyly been
>> updated to allow use of the intel_pstate driver, this patch fixes the
>> cpufreq test so that it can now use either acpi or pstate modes.
>> The library will auto-detect, and set the environment appropriately.
>>
>> Fixes: ed7c51a6a680 ("app/test: vm power management")
>>
> I think this should have been:
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>
> Presumably based on the Fixes tag, it got a stable tag added also, but
> it does not look correct for 18.11 and breaks the build. If that's
> incorrect, please let me know.
>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
You are correct. Your suggested Fixes: line is the correct one. It's
only relevant after the pstate compatibility was added.
Regards,
Dave.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-06 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190107144051.7097-1-david.hunt@intel.com>
2019-02-06 15:47 ` [dpdk-stable] [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode Kevin Traynor
2019-02-06 16:24 ` Hunt, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).