patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Huisong Li <lihuisong@huawei.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dpdk stable <stable@dpdk.org>, Xiaoyun Li <xiaoyun.li@intel.com>
Subject: Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series
Date: Fri, 4 Jun 2021 14:35:32 +0800
Message-ID: <6e45c5cc-1643-910e-5963-dfa20b4d134c@huawei.com> (raw)
In-Reply-To: <CAATJJ0+i8uF3X44u90RfOAXrj8sjwvgMbuNQh+c6BQ0q=W4QCg@mail.gmail.com>


在 2021/6/4 13:01, Christian Ehrhardt 写道:
> On Fri, Jun 4, 2021 at 3:52 AM Huisong Li <lihuisong@huawei.com> wrote:
>>
>> 在 2021/6/1 19:24, Christian Ehrhardt 写道:
>>> Hi,
>>> this commit was targted at the stable series:
>>>
>>> commit 43f1f8261136852357057b78aa49d354beaf3931
>>> Author: Huisong Li <lihuisong@huawei.com>
>>> Date:   Wed Apr 28 14:40:44 2021 +0800
>>>
>>>       app/testpmd: verify DCB config during forward config
>> The above patch does not need to be applied to 19.11.x, it is ok.
>>> As part of that it removes pt_id as it was the last user.
>>> But this does not work out without the following also in place.
>>>
>>> commit 08dcd187068666c96e8a16604a1c96160ed310e9
>>> Author: Huisong Li <lihuisong@huawei.com>
>>> Date:   Wed Dec 2 20:48:55 2020 +0800
>>>
>>>       app/testpmd: fix queue stats mapping configuration
>>>
>>> Since the latter is rather massive I have for now dropped 43f1f8261
>>> from the queue for 19.11.9.
>>> Please consider creating a backport or letting me know that this change
>>> isn't meant to be applied to 19.11.x
>>>
>> BTW, the first patch does not conflict if the second patch is applied to
>> 19.11.x first.
> Hi Huisong Li,
> Yes it would apply, but it would not build.
> On 19.11 there would still be uses of portid_t  pt_id left and since
> in this patch it was removed from start_packet_forwarding it breaks
> the build.
> Just adding back the variable as a backport without further
> investigation if that really would work out well and some testing
> seemed too risky.
>
The "portid_t pt_i" is just a local variabl. If it is still be used in

start_packet_forwarding() on19.11, let's just leave it where it is.

I don't think it affects anything.

If that might be a bit risky, we can ignore this patch.



      reply	other threads:[~2021-06-04  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 11:24 Christian Ehrhardt
2021-06-04  1:52 ` Huisong Li
2021-06-04  5:01   ` Christian Ehrhardt
2021-06-04  6:35     ` Huisong Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e45c5cc-1643-910e-5963-dfa20b4d134c@huawei.com \
    --to=lihuisong@huawei.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git