From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 959A9426AE for ; Tue, 3 Oct 2023 18:10:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76ED7402A2; Tue, 3 Oct 2023 18:10:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2786840262 for ; Tue, 3 Oct 2023 18:10:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696349440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Izsc+ksqPLEQH0ubEr8ue2oLls9lddetTHCtVR8oY/w=; b=IzAu7X51d3vBqbEmXdy2SyqYeNRm6HSBXECcVrIxKcPlPM+WDc7zHUXPH5hiwYH1AK0RUp hWKsjaoPpCsxxP4T44NyTlLz+5AUevh3Qu7HCQ9ZAw4eTxNJn8phRGAhwc/sKcZ8oBhd5x mruYfq9wl8vLJHVrxU84fpXXWButIcM= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-Ds4HbVOSOou2SC0UiHqVXw-1; Tue, 03 Oct 2023 12:10:27 -0400 X-MC-Unique: Ds4HbVOSOou2SC0UiHqVXw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3D1F29AA383; Tue, 3 Oct 2023 16:10:26 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BEBC40C2015; Tue, 3 Oct 2023 16:10:25 +0000 (UTC) Message-ID: <709ee651-7948-5406-741f-40c33bfe1637@redhat.com> Date: Tue, 3 Oct 2023 18:10:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v1 1/1] baseband/acc: fix ACC100 HARQ input is alignment To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20230919182417.93374-1-hernan.vargas@intel.com> <20230919182417.93374-2-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230919182417.93374-2-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/19/23 20:24, Hernan Vargas wrote: > Some constraints are imposed onto the ACC100 HARQ input size, > but that value is incorrectly aligned down when getting close to > max (Ncb-F) which is not required. > The wireless performance impact is negligeable but still causes a > few LLRs no to be combined at the very end of the circular buffer. > > Fixes: 5802f36dd492 ("baseband/acc100: enforce additional check on FCW") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 5362d39c302f..c736f3e4201c 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -1218,7 +1218,7 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, > - op->ldpc_dec.n_filler); > > /* Alignment on next 64B - Already enforced from HC output */ > - harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC_HARQ_ALIGN_64B); > + harq_in_length = RTE_ALIGN_CEIL(harq_in_length, ACC_HARQ_ALIGN_64B); > > /* Stronger alignment requirement when in decompression mode */ > if (fcw->hcin_decomp_mode > 0) Reviewed-by: Maxime Coquelin Thanks, Maxime