From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50062.outbound.protection.outlook.com [40.107.5.62]) by dpdk.org (Postfix) with ESMTP id 6361F1B54A for ; Fri, 30 Nov 2018 18:53:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/9z9Yl8dqDrCqgi1I1dy8msF6Zyg1oUIxJy367P/Qc=; b=sERQTacvPvYUBWJgwsGI+RXCAurNEnvo9+iTd/Fd4r0jjORfmRm8i8CmoiVMuHd0BugGzFm/VN+VIKdAKtifQwSpkx0zkGIPkpWtxBHBc2JehxG9cogVYV41u7ekimDYSP9nTYFuqgWp3qj+3Ero7DT5zjZ8IIrNzgdltj0Tr7M= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Fri, 30 Nov 2018 17:53:40 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::dcbc:4578:3018:50f3]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::dcbc:4578:3018:50f3%4]) with mapi id 15.20.1361.022; Fri, 30 Nov 2018 17:53:40 +0000 From: Yongseok Koh To: Lee Daly CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH 17.11] net/bonding: fix possible silent failure in config Thread-Index: AQHUiJmEuGjq+LECEEW5SoSOUfEptqVomgyA Date: Fri, 30 Nov 2018 17:53:39 +0000 Message-ID: <71F3AADE-64C0-46E8-8795-61A8EAF22419@mellanox.com> References: <1543574593-40390-1-git-send-email-lee.daly@intel.com> In-Reply-To: <1543574593-40390-1-git-send-email-lee.daly@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.17.37.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3995; 6:7j+6X5yUcb+IULSvJIsGoiJIcAAa2x9XDJbjgVXxzWPf0rxpvCceBQbpRPRxslDVxHTsFJ6qv/AEwoA7+tU5QoT7mkk6zFZ4oreu+cg3AvWHM5kd+cgoiGTZtI6LQdbDHgBURssSjJGd0XcUVDTgf6vpE3ZoNPIwIkQrn1sTzQExJe8irH6bpyV/VhkHwZxAgDLMsX8WGP19vsop91vwvODFr+LlWw+rrCUM+2dBKDzH11r0GI42CL2AT0CJnx2cvxT582mlU269DpCyi1edGnZAkpDvtX+pQ5nFIOI4PzAgaJ6k7wF1G9LCMvm2eLnNNXPBdHMm7RLz/BJvlds5EFsRU/9HBPF+bJk3ZBnRdz8IrT2R3rG/VDnGKNW1SmJUmzH29F/KXVYDDtxqexdhzLBaoJw/SBKKHuayp7JcMTJOEWtsq0X0451FFQ4yRyv17WQRx1v1Kptp/+bBvyk02A==; 5:F+apPC9LvyvzX+pFtg3v4k5m0o3+uHKYoP+5ch/+eBZvyEhrAbjDuM4paIW5mvaoGYdzu+Zqdw2bSgxao7iFtzDlMjaCULSGAqh0zXgiQJ+TXOeKg9HdavblxM4nMTEcU+uwUHSCSpr5/+PKgYykR6W4m/SX2J3Bt3YyAEZjUn4=; 7:i4TpY47XK7Qnsez7gkKbN4HafiC3XHQ0HNq5UAuaFRA7dQze8jw1BOAbTMFocVKtKOFERY6vNXpP5KsMLUPfHzJICdNTA3Sx5yTiGC2J7kUC86/RFvOHnCkG1zkYmbUKNZ2np73jvhgnJGgks8BNiw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6ba0da47-ec78-4b2a-5ec5-08d656ecc2d9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231453)(999002)(944501466)(52105112)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB3995; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3995; x-forefront-prvs: 087223B4DA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(199004)(189003)(102836004)(316002)(99286004)(229853002)(66066001)(33656002)(25786009)(6512007)(476003)(305945005)(97736004)(36756003)(6916009)(86362001)(7736002)(105586002)(478600001)(5660300001)(14454004)(106356001)(68736007)(83716004)(486006)(81156014)(26005)(71190400001)(2906002)(81166006)(6246003)(82746002)(71200400001)(2616005)(6506007)(4326008)(11346002)(186003)(446003)(8936002)(256004)(3846002)(6486002)(53936002)(76176011)(6116002)(53546011)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: vqcBcd0leLp/d+9e2XMMdy+9dfiFHUqeuihWravERC3li5VQaan+C8cMDbR6Qb/0dF6YC9qsvj6BjD51kmocD0a2FW/7eAyJxNB3eBOXu2viOCgLfpBeQ53uNZLbsQgJYbzlX54NuGrunWQ8Px86J7ALip5SbwcPcLpgEyaIh2oH38w/SGLbY4r2j/O2HF05GN3VW08g4e0njNygYZTcjpqJEj4bk69VAhMmq478q2wCsKz3YlnF//S1YQvumLNWWEkWfTDL8LAZ1gGfIIso0XvxTqQAaSCoyVUVVQE+gN/ixjf/Rbnz6QS4KUHX4EwlrGfaYCQ3sgVvXXmzqZgIfvBEL8HNEQtC17Eva+/5gqs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba0da47-ec78-4b2a-5ec5-08d656ecc2d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2018 17:53:39.9081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: Re: [dpdk-stable] [PATCH 17.11] net/bonding: fix possible silent failure in config X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 17:53:41 -0000 > On Nov 30, 2018, at 2:43 AM, Lee Daly wrote: >=20 > [ backported from upstream commit 6d72657ce379e159b745be27edcad72ac0266aa= c] >=20 > This patch checks the return value of function > rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure > for error return value. >=20 > Signed-off-by: Lee Daly > --- Applied to stable/17.11 Thanks, Yongseok > drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding= /rte_eth_bond_pmd.c > index fe23289..60d958b 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2910,9 +2910,16 @@ bond_probe(struct rte_vdev_device *dev) > goto parse_error; > } >=20 > - if (internals->mode =3D=3D BONDING_MODE_8023AD) > - rte_eth_bond_8023ad_agg_selection_set(port_id, > + if (internals->mode =3D=3D BONDING_MODE_8023AD) { > + int ret =3D rte_eth_bond_8023ad_agg_selection_set(port_id, > agg_mode); > + if (ret < 0) { > + RTE_BOND_LOG(ERR, > + "Invalid args for agg selection set " > + "for bonded device %s", name); > + return -1; > + } > + } > } else { > rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE); > } > --=20 > 2.7.4 >=20