From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCF04431FB for ; Wed, 25 Oct 2023 11:02:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD829402EA; Wed, 25 Oct 2023 11:02:10 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B911D402BD; Wed, 25 Oct 2023 11:02:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698224528; x=1729760528; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Csn+An78sMHq0KWxakAOx5XdUpXkbV+W3sbJWI4/Y4o=; b=hvjiBHbGVdV5kbFsEqAMgYltmFluWjeAD3YWxS5D03fSwJq6xJ/PcCF8 c13fk4mdXWl0WG020AwFj2LzdHQlbBF8La8vIhfWMqoL+yrGo/AAk+ybD 97m1adJMffylXn6lXL5S/YUyav6KyY4jnL55hED4di0ERIvriHmwhqE8M DZekp9Iw1vndFWhpqSXNPTaEj8EpOu3OQjRlE6stGjWjSUJ4yBi2b5MtH YoYNpump1I8Xin0kCCLaMkh6dhtpLDGlfX+8vKpb0rhvqrzLrEWr9YzZ2 6rbnnk6tMq5lcNNcDujr9eKvDcyhNVUH+88m3gISNB8JborH1ot1D+ZkE w==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="367481683" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="367481683" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 02:02:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="29235" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2023 02:01:31 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 25 Oct 2023 02:02:05 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 25 Oct 2023 02:02:05 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 25 Oct 2023 02:02:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=daREWCI1An/WaXqji4Rt0+U3eFlkVbW8hMVE3qzoou4uYWEaxJfc88ERwvvgSoN0dKMdbFCPum1C6FwSUAWKGuHIPg/SOiuh9YUKw0MfX99XvqaTRk/54JIWSQjLz0mkc7Ln+jNdYJh2BkiQmTCawaNGm6S2QyzbvhRk4FhyafwPAFlVTYlM29bRz4dD8DW1Rc9Z3+Z7TYzTDTT4K9KY4f2hhXbJysgTkpGdkcvTaRBAunzQ3TYN5/2hdJrNb4JhxHVy6mm8iV01hzNwrQq3Zb7DkVNDqVvleR9aO7RqoOINzVGzr6vPK/tW1qbP/VhK7hPxZmnb+pc0Advn9Dlg/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rouk4G8COt3gAGREvMrqn0TDBMzhgTrO5bWvmeRaMK4=; b=P+wZl2BCd+h9aPawKsoqhHvP5yoNaZFy8zFS28WwBvRFMvbXodB8BqQ6FBG0BYFADNiwABQk6CKdUxoOq9gZJL48FM/AWUr0TGb9hyIueThtmQ3vT/Mmi8R19P0WB+RF8ssCqSqfcyYt6TLVN190YXm2CNYVILWc7vVePgE0lkF/WMwhcqn0i/Mj1cRy/Vw4bsV+nzlrf3w9MK1QtbIBhSfAllNybcfuCV8TAkn9vRlMTgo3qWqgvyV2jAPm5la2piLGqCH7LXoxnljj+8otLoaS0PDLYGHTRZAQnFdQplH6YtIXEsiEM7aseLzirncsJKnWce45kwfbxDq0LjElDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by DS0PR11MB8206.namprd11.prod.outlook.com (2603:10b6:8:166::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Wed, 25 Oct 2023 09:02:02 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Wed, 25 Oct 2023 09:02:02 +0000 Message-ID: <71a76142-86f6-729c-c0bc-4be7a41fb77a@intel.com> Date: Wed, 25 Oct 2023 10:01:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition Content-Language: en-US To: "Zhang, Qi Z" , "Marchand, David" CC: "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "stable@dpdk.org" References: <20231024091328.11933-1-radu.nicolau@intel.com> <54859de7-c108-8389-43bc-9602a9897afc@intel.com> <59156c1c-c023-2504-6de5-6a84457e5ede@intel.com> From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU6P191CA0047.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::12) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|DS0PR11MB8206:EE_ X-MS-Office365-Filtering-Correlation-Id: 99655fd2-f5f9-444c-07d6-08dbd5390d77 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Iasx72g9S1UaskF0dCU0AnwVkZOxjQbaCnyPG6bgkRGa4JMGpWdC43jtY1vYOal0ze4xgtqJywiosqS5/xeikq+HTaSmqqP6r/n7ebuUeXI9rQB97qqN9ipAazV/V0DTGe2ys5uMLVaoBlLtxM3eqE2/pGHIbr3UEztsgkAXenjAY3A09g3XZbmCXk7Ll8e6ge+XU5qn55/UTfy3AC8MkRLWdmlbEyhzdtnodY8zgLBTyPWNwDNMxmmGfbHyVdx8G7eh7mNI/SOYYG7cmOCYUMc4udxfyT2l24gI65tDZp+fy+NQrDxQisUTOWtsUCrYVQF2hN/uHtaB8kf7hv+YobCHXZYK+Hwu12sviTJ2DOj4x8usAuE4qv7Zo8J/DyCan6CuOxKhNiRFp8evZtXu9ID/vEqJ6Uv/Jxlwp9Rgh9lNwuHntvC9/qPfAYMTZF5Wsvp6gI6AFttm0TysOrkyKO005g5Hc92rJXJodeA+MW9gIXODU7mxe5nh0GxTxPQAFzE4b5lWsuo2jT/zKQbrO2NmWpOEf5yH5OxxCIHppApicy9sHglX7ddHC/ymPP4YRVD5b06pxtdzrjdDdtioGvatI6C7aL3NBUIltm7i27CfaJSnwZNPbqCESuE2XTQQuuqMGkSzu1OjpexNE8oeA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(136003)(346002)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(31696002)(83380400001)(2616005)(82960400001)(26005)(6512007)(6666004)(53546011)(55236004)(38100700002)(6506007)(2906002)(316002)(110136005)(41300700001)(6486002)(4326008)(66946007)(478600001)(44832011)(8936002)(8676002)(66556008)(5660300002)(54906003)(66476007)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkZXSGp4dFVsM0k5cHN0U2xFcHVzeTVaZnRaeGNHRWdHYy9LRXZBby9KajRV?= =?utf-8?B?SHlWR3VEbS9taFdWaHQ2Q3Vtc2hHK0pwUjNtZkh4TEkxUTM0VzEzd2ZjclVP?= =?utf-8?B?bVBHMnV0OXJoN3Fpam5OTjU0V0w4d0FQVFhsWTZZT3ZkMGZOOVBHU0l4aFRY?= =?utf-8?B?TVZNSDhFalg5N3kwaTN0TmFFZ2ZubUxpWmZ1Q2l3QTVGanowb2JpRFJlS0xt?= =?utf-8?B?LzhES09LRFcwUUNzOXI3WVFBenlJRTl2WWJVanNWRDcwNXNPTzU5T052ZXZp?= =?utf-8?B?TElUcnN6RC9WSitjTDQ1bDNjK0VzSFJIeDFxa0Ewc2p0UnRpT1V0cGFKSGZP?= =?utf-8?B?VVljL29hZnVYRUZWWXk5MytBRUlMdDlVZzBnUlVWdFoybDBVVDE3eU9ldEJE?= =?utf-8?B?aFhEdjVzQU8wUmhRWnY0SWZTekZrRjZCMWdUU3NlYm4rQXdydnJQKyt2QWhN?= =?utf-8?B?K2t6NFFFaG1DU1pQc2ptVlhjeHNPTEdqa0wyTHcyMUZkUCtBM1FrWGJnMnlI?= =?utf-8?B?NXB5YnBMcEZDZzNFa2xFb001SW9DemgzSnkvZ3dmSUxDUDFnUlhXQm12UFlQ?= =?utf-8?B?MS94c0ZCRGY3NWwza3hhR0lPS1Rtcit6cC9CRUJDN3pPNEJQeXMxeTNxOHZt?= =?utf-8?B?NjNjT1M0OTl3aEI2LzhMaXE0ZGFiemVsa051d1hiQkZ1NzJ6TW1MK2ZPckZB?= =?utf-8?B?Y1VaVWJENWNsT3J5NmdZSVB0YnRKVmJEZzd5Mktvbzd4bDQ2bmF0Yk5PTmpI?= =?utf-8?B?QXh3cS9QMzRwbDZWZEZaUGkzSlh6cGZacWhyczBsUm9XZFk5TmhQNzBPa0NV?= =?utf-8?B?Vlo1aDh6SWRuWXFyZStNZmcrOUJydGgvSDY3SHlINk1IVktNOW1ETXA3cUFv?= =?utf-8?B?S2xleUk1eVQ2d1AvRUZYcGpmeklXYkdMajdhQmx2N05sTTNsTStQUi9lZEFS?= =?utf-8?B?VVEzVzZvaklKT3V2N1h1dVQ5NjZwV3dnVzFwN3JRdUJ6WW9oUnE1SEtLWGlR?= =?utf-8?B?MDJzWUIyS1U0Mm9ueHRxWFlvRk8wRGJsL0RJZWIvemlWekdaWWEvQ3RGZTR0?= =?utf-8?B?aDI2VFUrb0NsWFNXQ29xa2w2Smx6bXNXd1Z1SjkxU0pUcVVLNnF0L2RvTnN3?= =?utf-8?B?NFVXTTV0c1BqZUhydUhtRVJ3QTlmTzMyUlRTQXFkdFo0aU1IRWNOcmFCTXhq?= =?utf-8?B?NTRIYXhWaFpKbUQyQ0lNZi9NYnNEK3YwZE5DNTV2UzhsVmxxN2Q4dklVYkN4?= =?utf-8?B?WDZsa2V6b3oyVzY4Wk1sTDB4QnYxZDYyd2xabW1QQVB0ZlpqMDI0SHlueS9P?= =?utf-8?B?ZklET1ZtOUtTa3NZbTVJNjNyL1ZES1dVN3dBL2lrVGlzZHIwMEtyYXF0UjJZ?= =?utf-8?B?MmFyUW9LTE02SThYSGhybG83SS9vZDdhcFVlNU9mUzFRQUpFMXUwZEQ5aEJX?= =?utf-8?B?dmJwVGw0ekdmcjh3TnluWlYwa2pOV0pKMFkwQ2NIeXBrQVUwaHkzTlNqN2ZL?= =?utf-8?B?R1RYemlnb2NxU3UzZUc2YXkvbURJZW5LbmlSQlFwYjNQaGJGTzNRUGVFbW0y?= =?utf-8?B?dnJ5d3V4ckx6bHU1bXpTc25ldW5OTkZlQTlIOGJ3QXNNblRmRFNXeUxob1pr?= =?utf-8?B?TDJlTnFOMkU3TU5XNVJzUThUZ3VEa0xwM244WDRxTGlXV0Y5L25Zbk1Vb29j?= =?utf-8?B?Y3YraFlvQ3JxUkJmT2t4dGZQRUZ2aERjSjF6Q1pRckZUZk1ESHRnbTJaRmkv?= =?utf-8?B?NjdBSC91MW5oWGJBb3ZKaWZBTE9KaTNRYXlwYTFBNFpiekRYMHNiM3NYQ0lp?= =?utf-8?B?ZVFBUk5WWDZMVjAreEZKNXVVMnBmL2VjemRveEdqVjFnMWhJYlAzVndmNlRJ?= =?utf-8?B?RjhZTDV6SDM2RDY2WnB0SmxMZ0JxZUhuUGc2eGFQSEpucGdoQ0JLd2h4ajNJ?= =?utf-8?B?dEg4Y0kveHR4SlBYbjFtRitSMFQrQ2ZKWEZhRVBVM3ZNK3RxZ3poZHpPc0VG?= =?utf-8?B?dEx0Umh3clBXdHhkUEJSZ3Z1Vi9PUUpxeTRaajRLR3QwUHNDeEJadWZuT21I?= =?utf-8?B?WHJOelY1bVdTY1cyVWVwMWVGMG42SVVORmJIaVpxdGkrWVRrOXpZRWNHZ2h6?= =?utf-8?B?SktXOHpyYXBQT0ozSWVwT0R1RC8zQjVydUZoWU1oVWFDZTRUWUJyOVBiR0RS?= =?utf-8?B?Z3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 99655fd2-f5f9-444c-07d6-08dbd5390d77 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 09:02:02.3368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8SxALvKwfYLUql/sRQ68kwt/cOl7aq+UaKNyBQsIKuZMEFr00t6ZU8jp5PE1Xj1B6fpaAxSNvMK2COlDrL20OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8206 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 25-Oct-23 12:30 AM, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Nicolau, Radu >> Sent: Tuesday, October 24, 2023 10:49 PM >> To: Zhang, Qi Z ; Marchand, David >> >> Cc: Wu, Jingjing ; Xing, Beilei ; >> dev@dpdk.org; stable@dpdk.org >> Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition >> >> >> On 24-Oct-23 12:24 PM, Zhang, Qi Z wrote: >>>> -----Original Message----- >>>> From: Radu Nicolau >>>> Sent: Tuesday, October 24, 2023 6:23 PM >>>> To: Marchand, David >>>> Cc: Wu, Jingjing ; Xing, Beilei >>>> ; dev@dpdk.org; stable@dpdk.org >>>> Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition >>>> >>>> >>>> On 24-Oct-23 10:49 AM, David Marchand wrote: >>>>> On Tue, Oct 24, 2023 at 11:13 AM Radu Nicolau >>>>> >>>> wrote: >>>>>> IAVF_TX_OFFLOAD_MASK definition contained >>>> RTE_ETH_TX_OFFLOAD_SECURITY >>>>>> instead of RTE_MBUF_F_TX_SEC_OFFLOAD. >>>>>> >>>>>> Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Radu Nicolau >>>>> Something is not clear to me. >>>>> How was the IPsec inline crypto feature supposed to work with this >>>>> driver so far? >>>>> >>>>> Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have >> been >>>>> refused in iavf_prep_pkts. >>>>> >>>> It worked because the IPsec sample app doesn't call >>>> rte_eth_tx_prepare, and from what I can see no other sample app does. >>> To keep consistent, its better to refine the >> IAVF_TX_OFFLOAD_NOTSUP_MASK definition. >> >> You mean like this? >> >> >> #define IAVF_TX_OFFLOAD_NOTSUP_MASK ( \ >>         RTE_MBUF_F_TX_OFFLOAD_MASK ^ (  \ >>             RTE_MBUF_F_TX_OUTER_IPV6 |         \ >>             RTE_MBUF_F_TX_OUTER_IPV4 |         \ >>             RTE_MBUF_F_TX_IPV6 |             \ >>             RTE_MBUF_F_TX_IPV4 |             \ >>             RTE_MBUF_F_TX_VLAN |         \ >>             RTE_MBUF_F_TX_IP_CKSUM |         \ >>             RTE_MBUF_F_TX_L4_MASK |         \ >>             RTE_MBUF_F_TX_TCP_SEG |         \ >>             RTE_MBUF_F_TX_UDP_SEG |      \ >>             RTE_MBUF_F_TX_TUNNEL_MASK |    \ >>             RTE_MBUF_F_TX_OUTER_IP_CKSUM |  \ >>             RTE_MBUF_F_TX_OUTER_UDP_CKSUM | \ >>             RTE_MBUF_F_TX_SEC_OFFLOAD)) > Sorry, I miss understanding this code change, actually you didn't remove a flag, but just replace it, NOTSUP_MASK no need to be changed > > Then I don't understand why "Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have refused in iavf_prep_pkts" > But I assume tx_pkt_prepare should reject only invalid packets while still functioning correctly with inline IPsec. rte_eth_tx_prepare would have rejected the packets before this fix, but no app calls rte_eth_tx_prepare. The only app that calls it is testpmd.