From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE8A845D01 for ; Thu, 14 Nov 2024 08:46:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAC45402A1; Thu, 14 Nov 2024 08:46:02 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by mails.dpdk.org (Postfix) with ESMTP id 02985402A1; Thu, 14 Nov 2024 08:46:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H+w0ry5c7vOd5K2sNPh+Et1xgAjG9+L89mSmboBkMQb2UBFPoc/econ54tLPAfvTxy+XPJaq+GDDO77ZZByFVlEZgK2mBpUH6PlJk1YB7wxn7dknLMM64D2+J+kxONu/z7yLyPy7NlT8e2rjLSVh+S09n7/tPHswtWjXvoBfc5gec7986SCro85mKt27YlZALJ5GWKclQCq3ymmp2NK7wPgHMxuRNUDl81p7sA6m4ewjXfJpxIV/2IeCRTYNKanDb6IAgBmuq+CW3P8lZ984XK+/4s7D/4OG2rDY2erDblcmlvpRAHXy3H87zgzmZnwqFGZOWJqpdwJp66Oz74soQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BK5QPyEo+FzSCAUJEfdF8rAZ9WDDHeBRwp6hicQW+M8=; b=V5G+Q+RBsQPGBjqk2FWMFxfA0vBTLnNOPJ4N7fvGprsfRxyMu6DLMofcuJW1QxQz/9KPSxPe3EakXFxgfDvw3aWxSBB692E93ryUG8JgA//dnO+eRcw66lq32E1AxjDSJFZKGERG09/EencbCuTrV5Vj67m5JBOvObzc8u3uD5t6LBfLaEj5VW4ainU8wkyiYcanpXQ5VlbMDAl9vixeswXeSQrBGR0Y+pqozuOug9SVfTK4D+HzYTymHrPb+nCD59SnAdevfuWcjaRPkLy6HVbxBaDvxFAtexfv/1YMU3AbCI8uyaKNyl6685u4aX0FWdVHGy90qqI7gDBfwVHa3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BK5QPyEo+FzSCAUJEfdF8rAZ9WDDHeBRwp6hicQW+M8=; b=kVjWUIbjm23ht7Z+8JD1QFVQdCBX2xWCoUdq7xeGLYJEycu0hr9OZ5L7exMcY0fvZpVi1gGjZv+W35HN9B/RGRhq4jaCZrso0FI4/s5lX/1zRh0dyVm3akI+Y+jbsS5tWSnLt0CaZFtRpaxnWZA7xqhmNutCM5Qoj5ZmD1xZro/lcqmAIibDD0RzDgxNJMEw9GOk3vhh86esaULEVBSp0AJN4e2l27pLdIPZEwluj6vCeX/8JzOVsbyaEWKTrD+69X4r4/N0lBI4KaEwrNT2X/vFvLGn1zRHgXzhl1Nyg4jXi7ahGLnyV/9lQ+ebTOCxUjd+6pkqGW+1I3T2WuJ5kw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by GVXPR04MB10708.eurprd04.prod.outlook.com (2603:10a6:150:225::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Thu, 14 Nov 2024 07:45:58 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 07:45:58 +0000 Message-ID: <72de698d-d689-7448-ac16-76ca3762256f@oss.nxp.com> Date: Thu, 14 Nov 2024 13:15:52 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] bus/dpaa: fix lock condition during error handling Content-Language: en-US To: David Marchand , Hemant Agrawal Cc: thomas@monjalon.net, dev@dpdk.org, stephen@networkplumber.org, stable@dpdk.org References: <20241113161455.2649551-1-hemant.agrawal@nxp.com> From: Hemant Agrawal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0159.apcprd01.prod.exchangelabs.com (2603:1096:4:28::15) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|GVXPR04MB10708:EE_ X-MS-Office365-Filtering-Correlation-Id: 6714213d-12a2-4914-9c03-08dd048060b7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VlhJZUNPTVF4RHBFLzlRcTNXMTZFMEFvNVNjUTloemJVc1pNZUliVXN0V1VV?= =?utf-8?B?QXQxUUp2aFQrUWZ0eFpjUUh5bFcrTlR4aDhGYjlkRGdPUWVsM1pOM3UrOXlB?= =?utf-8?B?aEw3ZzgyMUpDMytQZkNldlFONVRFVTlnQTJLL2gvS0NoR2JZTGNXN3BTQzFh?= =?utf-8?B?M1FOMytLYklWaVU1RW5FNFJmb2liZDB0cUE1bVl3OHVicUoybUZ1MGpsNmFa?= =?utf-8?B?aG5JNnpjNnNObnhsa1cwZzRuQ2t1YnVvTUxMSHpya05vZ3F2NHNyT0IvZFI5?= =?utf-8?B?a3dvNFNtVlFOSFFkWUFVRWhqNzdaZTd5V0VBeGxURlpuN3Z0d3oxSWd4aXZy?= =?utf-8?B?TTFabGQ0VHp3aVByTEYzYVhZK0xlVEQvTmlNZDd3VXk4Tm5jQWJzRVNyVUl1?= =?utf-8?B?THFxbEJJRFJodjh0b3d1U0k2RWV4bTdIWksyeFlHeHJhWjdzTC91R3VyTEcr?= =?utf-8?B?QmprenVRclNYVVdpZThkem9ndWVaZkw2REh6eVF1NnVsRkpiVUtSUzIwYysz?= =?utf-8?B?NUg2T3d6dWR2aWpwanBGWUVteHNSVllMdmJqdUtPelRTMk95bUdsU21KQ3Ro?= =?utf-8?B?WHlpMENsazA1dmZnVGd3ZXRINHFNc3R1Vjl0RzBNZ0p6Yk9vbnkzOTlSSUYw?= =?utf-8?B?SlV5dWhiK2Y4d2NvMmlJKzhIR25vMUhIOVJ4WGtDNEFtUWR6bk5JaWpydWhm?= =?utf-8?B?WVJEMmxrNnlKRE5tN1ZKWlcwUmRoSWFaZ1p0ZU5xTjNUd2JDNnpqMmZuRVBl?= =?utf-8?B?MFZEeTVha2N2Rlo4Y0ptdURPZlJyTEZ6eXByR1JHeC95K2dDWW1Oa2dtd2Fk?= =?utf-8?B?TTNtR2JjcVpiTy9LKzVnckdvSUY0L1B1aTR2WUg5RGtiS21Mb1k5am9vZCtV?= =?utf-8?B?SHJiZXBhTUJMSWN0K0VxU2NSd3UyaTFMc01XR215VGxxblJIOENuZnBTcUhh?= =?utf-8?B?bDY5RDh3Zk5Vd3p4TnpPcmZWR053RWwxNVJqRnExMitFa240NndoUnJ1ODBh?= =?utf-8?B?enJMMlFCR3VtK3J6VHVsUHh1VG5ZdXlVaXdHWkZ1OWI5NHF6U05uME5ueitx?= =?utf-8?B?U2lyNkliMDg0dHlZSnFjTG9URHFnclR2OVFHQTV6VCtjVkRoRzYybFJPeS83?= =?utf-8?B?aFIrN1NzazhvR1R4a2FMeDNXdW1qVjlTaEp0dzFrbVhiYkNaVlJBVEFvY1R6?= =?utf-8?B?SENrQm5LRDZ1ZHBNcnNUaDRXMDlnOE1lSkM3djZyS0lFRjJEWTB3TDY3czFU?= =?utf-8?B?Y1NYaCtzMHRPRkVJZkpuUFpXbkJYeGFuemlWZDdCanlNbXlkOUF2bnVMYjFS?= =?utf-8?B?dmF6VkozUWdtZG5NSkFpRWE3bW9EZmZ5QjdLWlgraXdPZHBBcjhpL09YN2Ri?= =?utf-8?B?UEdHaWpOKzhkK0g2dDVmK1UrRm5SMWVuNE1TWFloV3o1djczZldnbXVHaEFm?= =?utf-8?B?eDhySEMwTk15Q3NaUS9ONFdmSXNCWDg1dnRVaWJqTU9EaHhlVGZaWStpTEtr?= =?utf-8?B?aWQxT1JrWjRSMm5CT2FyNk42RnFDWjRsaFFoN0pEZjFuZlNRTzhPRDF6NlVv?= =?utf-8?B?amw2amdEaURiNHgrbjdzemZudUNJNHQxMlJuR1ZiaWZGenArdFRFNTNzWmF3?= =?utf-8?B?OWF5QlYzSzRBbUltVGs0TmV0d1lYK01oR0FGYlRhY2tOR01DNHgxcndvL2la?= =?utf-8?B?K3d4bjY4NVQxRGRENENibFQya2w0QWprS2tKQ0FrekJwNEZydHhpUDJhU2hh?= =?utf-8?Q?C3o2bYALJdpHc5FB3Ua3MwsUCjRF5phIV9F2q4K?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0k1M3llT2RHRUNmdVBGQWVHZU10eXFydFg2VnF5SWc4ZUZHUmY5cDNFbmpN?= =?utf-8?B?dmhiUUxQaGVMcXlCbWRpaGh3dS9rS1pMRnRQQXpWSGxOZHhYZEdGaWZ6eG42?= =?utf-8?B?VWQzMWxXMEFvSDlIbUU4SEdTS09GdjdGU1orREtieVZ2NzJqMFI3SkpZZUpx?= =?utf-8?B?Z2hOMjZZMnBLS2tDN0JNTXZKVzB2azd4eHE3UUZGMmQ3dVVYMm5QMDB3SEZN?= =?utf-8?B?T1l4SS9RY2NOeDN4SHd0NGEyY0taa3YzaXpkb0NEYnVTRXYvMnRUTjJnMFAv?= =?utf-8?B?QVVMOTZ4Um9vbDk3RllYSGE1eUJEZitRZG9qZ095dFZsWlhSc1hkZVpnSG5p?= =?utf-8?B?SjloZGFVT3ZJTUkwR2hYUVZEUTY5RVErTHd4MUxMQmVNS2tQOVAzRDJVeWR6?= =?utf-8?B?d240clJCWFM2RWJ0VGZkYnZvTUI3UWNQdEtEbWREUjcxOVNOYm4wME9Db1NW?= =?utf-8?B?ODZWUy9hQ1VrUFA3ZkIrd1E0ampSS2ZmRzVDTkkydTRBSXZvR3JDTSt1VjVp?= =?utf-8?B?SU5vR3RGZXBGMjFVNWlSOWJobGNUbnVXMlk0VENycmJBYlFGUi9YSzcxTklG?= =?utf-8?B?ZGwrS21aVVNVbjU0Smd6RGUvTFQzaGFlUWhJZlpXUGVQdW9rc0JzOEJiN0hk?= =?utf-8?B?TXV3ZGluNTdGOUtacTIrck1uNndFdG54anJMTVc0c0ZVWjlFWnByendFSWU0?= =?utf-8?B?U0tHUUNGL0lYcHI5aHpHeUxNYmFrejM1bitJNkxSNGROVGdFQitMU0VJSVAz?= =?utf-8?B?RmRNV0pod1RXcFdvR1JhQXVMQTB0RVErWFBiMGZwT3lLQjZUS0diSU5teGE2?= =?utf-8?B?bU5hVDhVRnkxTGthMTQvOWY2TXJKcVJTbFdDQ0VxQWFuUmJmSnpFYWV2TXpX?= =?utf-8?B?UWFYUms2UHNGMU8rUHNpa1puTUVXT2U5NWJ5NWFCOTkyS1JxRHFWSkNMNzZ6?= =?utf-8?B?a2tzMGFwdVlVRVFVcklZRjQrU0FyY2ROcEh0bHFXWncvS0xjNWtPRFAzWGhC?= =?utf-8?B?TStFaXVmVDB6d0M4cWtHYTNVTkJ4VWZXZGpkL0VPSUtEbHNNeXUxNjdHdGpi?= =?utf-8?B?VVlkV2RCM1ROVEthUDBueFZwVjFjb0FqYThEVWkzbVNHdmlxa09KcFpFVGtn?= =?utf-8?B?b01SaldKNHNiYnZCYjkzTUJHRWxMY3JSU3FHemwzeU8yYksvcEVhOGxrb1Bv?= =?utf-8?B?SVVNQ085OXBhZjVRU2dxSGp3VFNITTdsTFJ0RmZqSlVBRk5LUmUxRGg2dUxs?= =?utf-8?B?ZGtwdEk2MVZ2eHVMQzl2SXh6WDRYUmxlM0xBeEpuaTlMNms2YTBKVE0reGJF?= =?utf-8?B?andmVUVSdmUvSWNkM3hVazJpZ3ZkYWgvUFlDR0tWaVd0L1pIcGJVUG03QjlX?= =?utf-8?B?cFJ1Ym04S1hLOVdJalR5QjZMWDNrUEhtWXovUHJwS0pjbXg0Zjd6UldaNlFI?= =?utf-8?B?UjRLWnpNTnNFNmtTQlFuS0NFbm9mczlBNnkxSmhvcEhHeHNJendoUDJ2VGpk?= =?utf-8?B?QjhQYi8rZk5OMmZvUlY2RUlvK3NkcUFuRlk2LzRTTjBIVnFqOERKVnN6c0xp?= =?utf-8?B?WE1meXAwQnFWVG91WUtRcit5T2dJVHBvb3J3RWRKZG1WcXpJdUE2ZG53Qy93?= =?utf-8?B?eE5ENlhLZDQzZzM3L1ozT2RxcmptQ1NjYlJhZVQxeHQxeldNR2Z2MEdYZXdz?= =?utf-8?B?RE8rUkV1SHQrQmo2a3QzZzhqeWZFSEZQV25sM0l5SGRiL0xhS01kUDlzejZ2?= =?utf-8?B?T3JZRlkvdlpITlBoU0Y1Q25BL3RUQXlzdyswc1EzTmxsSlpmNnEySE94aGxw?= =?utf-8?B?T09UbE9MMDNWWnk1V2k2ZVRBSkFUbERaQmRURUtPR1F5OGlLbGoxeFFuNXM5?= =?utf-8?B?TXFFcGF6N1Fta0c3TUVZL2J1a2tCY0lPWGFtMkRNN1QzWTMzdGZVUE1zRHQ5?= =?utf-8?B?RzZTT1RrN1dEZUR1dWNjSzYyN20xYWFmRVYyeFNaTUg0WlFtcW0rZzlxRmJi?= =?utf-8?B?WnU0WDN2Smlldk0rWUxWZ1hCNEdxRWxQMm1XdXoxWlRvUmVkM0hKaUJWdVRl?= =?utf-8?B?Q2xUdlFmSkFDOElVMENnWXZ0Q1ZwL1d5ZjUvakduMDFjblNEK2hkVkJGQmFP?= =?utf-8?B?akFwVHJ2Z1lUU1hEenVNSXU3QnVVd2JtUzdWdU1CMUVkcEFXYTJyK2FKTlBh?= =?utf-8?B?Umc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6714213d-12a2-4914-9c03-08dd048060b7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 07:45:58.4727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: irpUrflF3gM+7GFPbwKxuGSIh5efjmHFgXgC71fh/mKy4T79/UuXnMsklg+fC1JjrvMv57Diz5WP/4s8wjRq8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10708 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 13-11-2024 22:18, David Marchand wrote: > Hello Hemant, > > On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal wrote: >> The error handling is missing FQ unlock code. >> Detected by pvr-studio >> Bug 89-93: very suspicious synchronization >> The analyzer issued a pack of V1020 warnings that a resource >> might remain blocked. >> >> Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") >> Cc: stable@dpdk.org >> >> Signed-off-by: Hemant Agrawal > The fix looks good to me. > > To avoid regressions on this topic, could you look into enabling clang > thread safety check? > > I suppose that FQLOCK and FQUNLOCK always come in pairs (seems a safe > assumption), so enabling should be something like: Thanks for the suggestion and code snippet. It looks good.