patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	 Jeff Guo <jia.guo@intel.com>,
	Helin Zhang <helin.zhang@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	 Remy Horton <remy.horton@intel.com>,
	Jijiang Liu <jijiang.liu@intel.com>,
	Jing Chen <jing.d.chen@intel.com>,
	 Heqing Zhu <heqing.zhu@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/i40e: fix build for log format specifier
Date: Tue, 10 Nov 2020 18:07:49 +0000
Message-ID: <73c2ebdcae5cb9e7aa1eba3c86359c8e993935be.camel@debian.org> (raw)
In-Reply-To: <20201110175457.734922-1-ferruh.yigit@intel.com>

On Tue, 2020-11-10 at 17:54 +0000, Ferruh Yigit wrote:
> Build error:
> i40e_common.c: In function "i40e_parse_discover_capabilities":
> ../drivers/net/i40e/base/../i40e_logs.h:43:50:
>     error: format "%llX" expects argument of type "long long unsigned
>            int", but argument 7 has type "u64" {aka "long unsigned int"
>            [-Werror=format=]
>    43 |  rte_log(RTE_LOG_ ## level, i40e_logtype_driver, "%s(): " fmt, \
>       |                                                  ^~~~~~~~
> .../i40e_osdep.h:87:3: note: in expansion of macro "PMD_DRV_LOG_RAW"
>    87 |   PMD_DRV_LOG_RAW(DEBUG, "i40e %02x.%x " s,       \
>       |   ^~~~~~~~~~~~~~~
> .../base/i40e_common.c:4100:4: note: in expansion of macro "i40e_debug"
>  4100 |    i40e_debug(hw, I40E_DEBUG_INIT,
>       |    ^~~~~~~~~~
> 
> There are multiple build error because of same reason, all fixed.
> 
> Using 'PRIX64' to fix the build error.
> 
> Fixes: 889bc9f0cd3a ("i40e/base: unify the capability function")
> Fixes: 9b1041574cd4 ("i40e/base: enhance polling of NVM semaphore")
> Fixes: 8db9e2a1b232 ("i40e: base driver")
> Fixes: 3b7271f3958a ("i40e/base: catch NVM write semaphore timeout and retry")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: helin.zhang@intel.com
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: David Marchand <david.marchand@redhat.com>
> 
> v2:
> * Fix more build error from same reason
> ---
>  drivers/net/i40e/base/i40e_common.c | 4 +++-
>  drivers/net/i40e/base/i40e_nvm.c    | 8 +++++---
>  2 files changed, 8 insertions(+), 4 deletions(-)

Acked-by: Luca Boccassi <bluca@debian.org>

Thanks for the quick fix!

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2020-11-10 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 13:48 [dpdk-stable] [PATCH] " Ferruh Yigit
2020-11-10 17:54 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2020-11-10 18:07   ` Luca Boccassi [this message]
2020-11-11  8:16     ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73c2ebdcae5cb9e7aa1eba3c86359c8e993935be.camel@debian.org \
    --to=bluca@debian.org \
    --cc=beilei.xing@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=helin.zhang@intel.com \
    --cc=heqing.zhu@intel.com \
    --cc=jia.guo@intel.com \
    --cc=jijiang.liu@intel.com \
    --cc=jing.d.chen@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=remy.horton@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git