From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7C892A0A02
for <public@inbox.dpdk.org>; Tue, 27 Apr 2021 13:42:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 713674122D;
Tue, 27 Apr 2021 13:42:28 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by mails.dpdk.org (Postfix) with ESMTP id 2FFD64014E;
Tue, 27 Apr 2021 13:42:24 +0200 (CEST)
IronPort-SDR: wHUXvUkTCd5smSoUEBP62OuX5txVuNaKe+eGS402hOYj1dyObAvGdvSSzlGKtOk9uG08wcpdF7
UwKuZSUuGmtg==
X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="193306126"
X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="193306126"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Apr 2021 04:42:24 -0700
IronPort-SDR: 2ffZVY/HhI9L7BlzIr+3SCJzNNC0S980h0Gjnmb/OlzZFPrPUgpVAn89uZI7nJYU2topiih7t7
dvJi171dOclg==
X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457608387"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231])
([10.213.221.231])
by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Apr 2021 04:42:22 -0700
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
Chengchang Tang <tangchengchang@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
Andrew Boyer <aboyer@pensando.io>
References: <1607699265-5238-1-git-send-email-viacheslavo@nvidia.com>
<20210423160952.336272-1-ferruh.yigit@intel.com>
<DM4PR11MB5534365F8E1295CDD036972599429@DM4PR11MB5534.namprd11.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <741a5fc2-b50c-b354-d83c-839aaa1a9144@intel.com>
Date: Tue, 27 Apr 2021 12:42:18 +0100
MIME-Version: 1.0
In-Reply-To: <DM4PR11MB5534365F8E1295CDD036972599429@DM4PR11MB5534.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: fix segment number check
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 4/26/2021 12:23 PM, Li, Xiaoyun wrote:
> Hi
>
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Saturday, April 24, 2021 00:10
>> To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>;
>> Chengchang Tang <tangchengchang@huawei.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; stable@dpdk.org;
>> Andrew Boyer <aboyer@pensando.io>
>> Subject: [PATCH v2] app/testpmd: fix segment number check
>>
>> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>>
>> The --txpkts command line parameter was silently ignored due to application
>> was unable to check the Tx queue ring sizes for non configured ports [1].
>
> Remove this [1] or mark the following items as [1] [2] [3].
>
>>
>> The "set txpkts <len0[,len1]*>" was also rejected if there was some stopped or
>> /unconfigured port.
>>
>> This provides the following:
>>
>> - If fails to get ring size from the port, this can be because port is
>> not initialized yet, ignore the check and just be sure segment size
>> won't cause an out of bound access. The port descriptor check will
>> be done during Tx setup.
>>
>> - The capability to send single packet is supposed to be very basic
>> and always supported, the setting segment number to 1 is always
>> allowed, no check performed
>>
>> - At the moment of Tx queue setup the descriptor number is checked
>> against configured segment number
>>
>> Bugzilla ID: 584
>> Fixes: 8dae835d88b7 ("app/testpmd: remove restriction on Tx segments set")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Andrew Boyer <aboyer@pensando.io>
>>
>> v2:
>> * Become more flexible for the '--txpkts' command line, if not able to
>> get the descriptor size from port, ignore the check.
>>
>> ('nb_txd' check was proposed before, this will require '--txd'
>> parameter, but also enforces a specific order on the parameters,
>> instead going with the option to flex the checks for parameter.)
>> ---
>> app/test-pmd/cmdline.c | 4 ++++
>> app/test-pmd/config.c | 32 ++++++++++++++++++++++++--------
>> 2 files changed, 28 insertions(+), 8 deletions(-)
>
> Except the one comment above for commit log,
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
Applied to dpdk-next-net/main, thanks.
Above missing reference in the commit log removed while merging.