From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B2F843E9F for ; Thu, 18 Apr 2024 12:25:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42C32402CC; Thu, 18 Apr 2024 12:25:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 356DC40042 for ; Thu, 18 Apr 2024 12:25:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713435932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+danHTewaDSp17ejIw28UwHm1PyxmLGhJWprQLvbo6s=; b=cox2fX2VqSwc7FwIGsZK65/CZ0pA3wcmVNtl57MnEx9+F1ylBS8SnWXCN2MrfLRfyPcwv6 w9K7a/dGa/AavzGz1L+Cg/u8jAIN7928Ac6ZENY8FjlbCySPNCyw547jDJDYmMfg3c6CWH T8WFTyBxdt5WWrQBAaU7uAAmooFYgDs= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-F-fw_KtKNKClrvqaFQKLrA-1; Thu, 18 Apr 2024 06:25:31 -0400 X-MC-Unique: F-fw_KtKNKClrvqaFQKLrA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-516e6aa6bfcso629125e87.3 for ; Thu, 18 Apr 2024 03:25:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713435930; x=1714040730; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+danHTewaDSp17ejIw28UwHm1PyxmLGhJWprQLvbo6s=; b=hylkhvtoT5opa4rTEtZU+UL2MfWIwUVs5eohgNh8BaXHTLQWgtCp6da+m0RO+Gyu5j 1cTG3hawSWpnz2+OsdHN+D9f/8eKKaDdwwDvK1ZGAK2hWS1VY/N3tToFvdXtF99jT9dz vyNTmc9SmN7cJkCaB7/mdYTOcFzye8BhyGSbjpfwvcIU2gRZYHQ5xDmvx4S89FnrNKLT A7HHebSSq+o4Gn3wvT/e15V7NniYXEi1uno0HNL2QadVJD81QSLbO+Uk75Q/O4WO+RlF W1/FZke4LCj6Vp+RrP51Qm4VS635Ah5BSGVwbk/NWWWDPoYQtP/HCjmQX2YD4wToBlPy tTCw== X-Forwarded-Encrypted: i=1; AJvYcCUpgQSwub09uAEwBofRRt8R4/hEiiBY3hzUUyiFjvmA8zSNa4GGj4iYl/TWMZf3dWb1U9UR0/eMymGVIeqgT2k= X-Gm-Message-State: AOJu0Yy0usxdjBATe0CMEiKkJMrpPhbhfu2zsegLQj19sW2MA8Fm0eUZ Fnhi5FNVZw20BXSSiJ22JncNTMGDxwCs22io0zP/DhRKUQX127wQDv19yGu9IRiYMFcvopunkI7 G25ncVzOj5kSCmWxx1vOpgKDNZgZOxBqQPBW94clldHiI X-Received: by 2002:ac2:4c27:0:b0:516:10be:d7a9 with SMTP id u7-20020ac24c27000000b0051610bed7a9mr1318226lfq.30.1713435929049; Thu, 18 Apr 2024 03:25:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU7VjnA6S0RfqVVZeGo6mnldYi82b6B4n+WTSShJo2D183NocgCoMaorWcBag3FgwgW3XqCQ== X-Received: by 2002:ac2:4c27:0:b0:516:10be:d7a9 with SMTP id u7-20020ac24c27000000b0051610bed7a9mr1318210lfq.30.1713435928570; Thu, 18 Apr 2024 03:25:28 -0700 (PDT) Received: from [192.168.0.36] ([78.17.184.177]) by smtp.gmail.com with ESMTPSA id fj17-20020a0564022b9100b0056fe8f3eec6sm670752edb.62.2024.04.18.03.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 03:25:28 -0700 (PDT) Message-ID: <75c0abee-01b4-4b81-a779-1fdf664fa8d2@redhat.com> Date: Thu, 18 Apr 2024 11:25:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH stable-22.11] kni: fix build with Linux 6.8 From: Kevin Traynor To: Jiri Slaby , David Marchand Cc: Ferruh Yigit , Luca Boccassi , "Xueming(Steven) Li" , dpdk stable References: <20240312084914.92056-1-jslaby@suse.cz> <1c0b8110-34d9-4a4e-b9c9-35b06c7f0da8@redhat.com> Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <1c0b8110-34d9-4a4e-b9c9-35b06c7f0da8@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 12/03/2024 11:20, Kevin Traynor wrote: > On 12/03/2024 10:40, Jiri Slaby wrote: >> On 12. 03. 24, 11:26, Kevin Traynor wrote: >>> On 12/03/2024 08:59, David Marchand wrote: >>>> Hello Jiri, >>>> >>>> On Tue, Mar 12, 2024 at 9:57 AM Jiri Slaby wrote: >>>>> >>>>> strlcpy() was removed in commit d26270061ae6 (string: Remove strlcpy()), use >>>>> strscpy() instead. >>>>> >>>>> The patches fixes this: >>>>> kernel/linux/kni/kni_net.c: In function ‘kni_get_drvinfo’: >>>>> kernel/linux/kni/kni_net.c:835:9: error: implicit declaration of function ‘strlcpy’; did you mean ‘strscpy’? >>>>> >>>>> Intended esp. for stable/22.11. It should go wherever kni is still in >>>>> the tree. >>>> >>>> Thanks for the patch. >>>> >>>> Cc: stable and LTS maintainers. >>>> >>>>> >>>>> Signed-off-by: Jiri Slaby >>>> >>>> >>> >>> Thanks Jiri and David. I will take this for 21.11 LTS also. >> >> Just heads up: I've just realized, that strscpy() was introduces only in >> >> commit 30035e45753b708e7d47a98398500ca005e02b86 >> Author: Chris Metcalf >> Date: Wed Apr 29 12:52:04 2015 -0400 >> >> string: provide strscpy() >> >> in v4.3. If you support older kernels, the patch needs modifications. >> Like some #if's depending on the kernel version or some HAVE_STRSCPY >> defines. >> >> thanks, > > ok, thanks for letting us know. We should be fine for supported kernels > from kernel.org but it will probably an issue for Centos7 with older > DPDK LTS, though it is EoL very shortly. > I don't see this on 22.11 branch. Considering that 22.11 is almost ready for release and Centos7 will EoL in June. It might be just easier to wait and apply for the next release. Otherwise the patch is going to need to be reworked and tested on Centos7. Luca, what do you think ?