patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Shani Peretz <shperetz@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH v2] eal: fix DMA mask validation inconsistency in IOVA VA
Date: Fri, 19 Sep 2025 12:41:40 +0200	[thread overview]
Message-ID: <7662076.G0QQBjFxQf@thomas> (raw)
In-Reply-To: <MW4PR12MB74846210744CD9A67CAC7A92BF16A@MW4PR12MB7484.namprd12.prod.outlook.com>

18/09/2025 09:55, Shani Peretz:
> From: Shani Peretz <shperetz@nvidia.com>
> > 
> > When --iova-mode is explicitly specified in command line, DMA mask
> > constraints were not being validated, leading to potential runtime failures
> > when device DMA capabilities are exceeded.
> > 
> > The issue occurred because rte_bus_get_iommu_class() was only called during
> > IOVA mode auto-detection, but this function has the important side effect of
> > triggering DMA mask detection (e.g., Intel IOMMU address width checking via
> > pci_device_iommu_support_va()).
> > 
> > This created an inconsistency, when choosing explicit mode, the DMA checks
> > are bypassed, but when choosing auto-detection mode, the constraints are
> > checked and enforced.
> > 
> > The fix moves rte_bus_get_iommu_class() outside the conditional logic to
> > ensure it's always called during EAL initialization.
> > 
> > Fixes: 4374ebc24bc1 ("malloc: modify error message for DMA mask check")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> 
> Rebased on latest main. Patch was already acked
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks.



      reply	other threads:[~2025-09-19 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 16:34 [PATCH] " Shani Peretz
2025-09-09 10:17 ` Burakov, Anatoly
2025-09-18  6:47 ` [PATCH v2] " Shani Peretz
2025-09-18  7:55   ` Shani Peretz
2025-09-19 10:41     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7662076.G0QQBjFxQf@thomas \
    --to=thomas@monjalon.net \
    --cc=alejandro.lucero@netronome.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=shperetz@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).