From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF423A034C for ; Sun, 6 Nov 2022 10:35:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF43427EB; Sun, 6 Nov 2022 10:35:52 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id D45B84003C; Sun, 6 Nov 2022 10:35:49 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B7DFA62; Sun, 6 Nov 2022 12:35:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B7DFA62 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667727348; bh=RnplY7zBTfcscHQy9EYS4MTq9xbX0ML1SF0JyTG9fgo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LOaiJVK0/++K8KkGmnRQAzmImv4Lup3lxGdzoUHfAKxUnI2i+3dxtmtb7pvReCN/b X086+xRPjBIOEzs+2LN8+HqWAEC1eyokrUtO+zvLcXzjJ2gT+XmbvoY1FXpnMfkgZN V4or4iWGOt40B/eSYnHTMAHc8Oqkk+EPVABMkZO8= Message-ID: <784e8d7d-975b-b2bd-efe9-5b4324a1e776@oktetlabs.ru> Date: Sun, 6 Nov 2022 12:35:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] net/bonding: fix device configure reentrancy Content-Language: en-US To: Stephen Hemminger , Ivan Malov Cc: dev@dpdk.org, "Jiang, YuX" , Chas Williams , "Min Hu (Connor)" , "Burakov, Anatoly" , stable@dpdk.org References: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> <20221101123235.7d321376@hermes.local> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221101123235.7d321376@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/1/22 22:32, Stephen Hemminger wrote: > On Tue, 1 Nov 2022 19:18:53 +0300 > Ivan Malov wrote: > >> diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h >> index d067ea8c9a..7171516d0d 100644 >> --- a/drivers/net/bonding/eth_bond_private.h >> +++ b/drivers/net/bonding/eth_bond_private.h >> @@ -184,6 +184,8 @@ struct bond_dev_private { >> >> void *vlan_filter_bmpmem; /* enabled vlan filter bitmap */ >> struct rte_bitmap *vlan_filter_bmp; >> + >> + bool kvargs_processing_is_done; >> }; > > Minor nit: why not use existing hole in data structure after slave_update_idx? > Good idea, I'll update it on applying. Thanks.